fanotify: remove variable set but not used
Subsystems (3)
PATCH 1/1 fanotify: remove variable set but not used
The code that uses the pointer info has been removed in 'https://lore.kernel.org/all/[email protected]/' and fanotify_event_info() doesn't change 'event', so the declaration and assignment of info can be removed.
Eliminate the following clang warning:fs/notify/fanotify/fanotify_user.c:161:24: warning: variable ‘info’ set but not used
--- fs/notify/fanotify/fanotify_user.c | 3 --- 1 file changed, 3 deletions(-)
fs/notify/fanotify/fanotify_user.c +0 -3
@@ -158,7 +158,6 @@ static size_t fanotify_event_len(unsigned int info_mode, struct fanotify_event *event) {size_t event_len =FAN_EVENT_METADATA_LEN ; -struct fanotify_info *info;int fh_len;int dot_len =0 ;
@@ -168,8 +167,6 @@ static size_t fanotify_event_len(unsigned int info_mode,if (fanotify_is_error_event (event->mask)) event_len +=FANOTIFY_ERROR_INFO_LEN ; - info =fanotify_event_info (event); -if (fanotify_event_has_any_dir_fh (event)) { event_len +=fanotify_dir_name_info_len (event); } else if ((info_mode & FAN_REPORT_NAME) &&
Signature · 1 line
2.20.1.7.g153144c
Jan Kara
maintainerQuoted 11 lines · Yang Li
The code that uses the pointer info has been removed in 'https://lore.kernel.org/all/[email protected]/' and
fanotify_event_info()doesn't change 'event', so the declaration and assignment of info can be removed.Eliminate the following clang warning:
fs/notify/fanotify/fanotify_user.c:161:24: warning: variable ‘info’ set but not usedReported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Thanks! I've added the patch to my tree.
Honza
Quoted 28 lines
--- fs/notify/fanotify/fanotify_user.c | 3 --- 1 file changed, 3 deletions(-)fs/notify/fanotify/fanotify_user.c +0
-3@@ -158,7 +158,6 @@ static size_t fanotify_event_len(unsigned int info_mode, struct fanotify_event *event) {size_t event_len =FAN_EVENT_METADATA_LEN ; -struct fanotify_info *info;int fh_len;int dot_len =0 ;@@ -168,8 +167,6 @@ static size_t fanotify_event_len(unsigned int info_mode,if (fanotify_is_error_event (event->mask)) event_len +=FANOTIFY_ERROR_INFO_LEN ; - info =fanotify_event_info (event); -if (fanotify_event_has_any_dir_fh (event)) { event_len +=fanotify_dir_name_info_len (event); } else if ((info_mode & FAN_REPORT_NAME) &&Signature · 1 line
2.20.1.7.g153144c
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR