Skip to contentSkip to conversation

drm/amdgpu: Fix kernel compilation; style

PATCH In review Luben Tuikov 3 participants 3 messages Jan 20, 2022 – Jan 21, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Fix kernel compilation; style

Problem:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c: In function ‘is_fru_eeprom_supported’:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:47:3: error: expected ‘)’ before ‘return’

   47 |   return false;
      |   ^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:46:5: note: to match this ‘(’
   46 |  if (amdgpu_sriov_vf(adev)
      |     ^

Fix kernel compilation:

	if (amdgpu_sriov_vf(adev)
		return false;

missing closing right parenthesis for the "if".

Fix style:

	/* The i2c access is blocked on VF
	 * TODO: Need other way to get the info
         */

Has white space after the closing */.

Cc Alex Deucher <[email protected]>
Cc shaoyunl <[email protected]>
Cc Kent Russell <[email protected]>
Fixes 824c2051039dfc ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c +2 -2
index 0548e279cc9fc4..60e7e637eaa33d 100644
@@ -42,8 +42,8 @@ static bool is_fru_eeprom_supported(struct amdgpu_device *adev)
 
 	/* The i2c access is blocked on VF
 	 * TODO: Need other way to get the info
-	 */  
-	if (amdgpu_sriov_vf(adev)
+	 */
+	if (amdgpu_sriov_vf(adev))
 		return false;
 
 	/* VBIOS is of the format ###-DXXXYY-##. For SKU identification,

base-commit: 2e8e13b0a6794f3ddae0ddcd13eedb64de94f0fd

Signature · 1 line
2.34.0
Reviewed-by on v1 1/1
#1 lore raw

[Public]

Regards,
Guchun

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Luben Tuikov
Sent: Friday, January 21, 2022 7:52 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Tuikov, Luben <[email protected]>; Russell, Kent <[email protected]>; Liu, Shaoyun <[email protected]>
Subject: [PATCH] drm/amdgpu: Fix kernel compilation; style

Problem:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c: In function ‘is_fru_eeprom_supported’:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:47:3: error: expected ‘)’ before ‘return’

   47 |   return false;
      |   ^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:46:5: note: to match this ‘(’
   46 |  if (amdgpu_sriov_vf(adev)
      |     ^

Fix kernel compilation:

	if (amdgpu_sriov_vf(adev)
		return false;

missing closing right parenthesis for the "if".

Fix style:

	/* The i2c access is blocked on VF
	 * TODO: Need other way to get the info
         */

Has white space after the closing */.

Cc Alex Deucher <[email protected]>
Cc shaoyunl <[email protected]>
Cc Kent Russell <[email protected]>
Fixes 824c2051039dfc ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c +2 -2
index 0548e279cc9fc4..60e7e637eaa33d 100644
@@ -42,8 +42,8 @@ static bool is_fru_eeprom_supported(struct amdgpu_device *adev)
 
 	/* The i2c access is blocked on VF
 	 * TODO: Need other way to get the info
-	 */  
-	if (amdgpu_sriov_vf(adev)
+	 */
+	if (amdgpu_sriov_vf(adev))
 		return false;
 
 	/* VBIOS is of the format ###-DXXXYY-##. For SKU identification,

base-commit: 2e8e13b0a6794f3ddae0ddcd13eedb64de94f0fd

Signature · 1 line
2.34.0
#2 lore raw
In reply to Luben Tuikov

[AMD Official Use Only]

Good catch . Thanks .
Reviewed by : shaoyun.liu <shapoyun.liu @amd.com>

-----Original Message-----
From: Tuikov, Luben <[email protected]>
Sent: Thursday, January 20, 2022 6:52 PM
To: [email protected]
Cc: Tuikov, Luben <[email protected]>; Deucher, Alexander <[email protected]>; Liu, Shaoyun <[email protected]>; Russell, Kent <[email protected]>
Subject: [PATCH] drm/amdgpu: Fix kernel compilation; style

Problem:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c: In function ‘is_fru_eeprom_supported’:
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:47:3: error: expected ‘)’ before ‘return’

   47 |   return false;
      |   ^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c:46:5: note: to match this ‘(’
   46 |  if (amdgpu_sriov_vf(adev)
      |     ^

Fix kernel compilation:

	if (amdgpu_sriov_vf(adev)
		return false;

missing closing right parenthesis for the "if".

Fix style:

	/* The i2c access is blocked on VF
	 * TODO: Need other way to get the info
         */

Has white space after the closing */.

Cc Alex Deucher <[email protected]>
Cc shaoyunl <[email protected]>
Cc Kent Russell <[email protected]>
Fixes 824c2051039dfc ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c +2 -2
index 0548e279cc9fc4..60e7e637eaa33d 100644
@@ -42,8 +42,8 @@ static bool is_fru_eeprom_supported(struct amdgpu_device *adev)
 
 	/* The i2c access is blocked on VF
 	 * TODO: Need other way to get the info
-	 */  
-	if (amdgpu_sriov_vf(adev)
+	 */
+	if (amdgpu_sriov_vf(adev))
 		return false;
 
 	/* VBIOS is of the format ###-DXXXYY-##. For SKU identification,

base-commit: 2e8e13b0a6794f3ddae0ddcd13eedb64de94f0fd

Signature · 1 line
2.34.0