perf script: Fix printing 'phys_addr' failure issue
PATCH 1/1 perf script: Fix printing 'phys_addr' failure issue
From: Yao Jin <[email protected]>
Perf script was failed to print the phys_addr for SPE profiling. One 'dummy' event is added by SPE profiling but it doesn't have PHYS_ADDR attribute set, perf script then exits with error.
Now referring to 'addr', use evsel__do_check_stype() to check the type.
Before:
# perf record -e arm_spe_0/branch_filter=0,ts_enable=1,pa_enable=1,load_filter=1,jitter=0,\ store_filter=0,min_latency=0,event_filter=2/ -p 4064384 -- sleep 3 # perf script -F pid,tid,addr,phys_addr Samples for 'dummy:u' event do not have PHYS_ADDR attribute set. Cannot print 'phys_addr' field.
After:
# perf record -e arm_spe_0/branch_filter=0,ts_enable=1,pa_enable=1,load_filter=1,jitter=0,\ store_filter=0,min_latency=0,event_filter=2/ -p 4064384 -- sleep 3 # perf script -F pid,tid,addr,phys_addr 4064384/4064384 ffff802f921be0d0 2f921be0d0 4064384/4064384 ffff802f921be0d0 2f921be0d0
--- tools/perf/builtin-script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-script.c +1 -1
@@ -515,7 +515,7 @@ static int evsel__check_attr(struct evsel *evsel, struct perf_session *session)return -EINVAL ;if (PRINT_FIELD (PHYS_ADDR ) && -evsel__check_stype (evsel,PERF_SAMPLE_PHYS_ADDR ,"PHYS_ADDR" ,PERF_OUTPUT_PHYS_ADDR )) +evsel__do_check_stype (evsel,PERF_SAMPLE_PHYS_ADDR ,"PHYS_ADDR" ,PERF_OUTPUT_PHYS_ADDR , allow_user_set))return -EINVAL ; if (PRINT_FIELD(DATA_PAGE_SIZE) &&
Signature · 1 line
2.25.1
Hi Wei,
This looks good to me. As a followup we could also fix the 'weight' field, which was introduced recently.
Quoted 17 lines · Wei Li
From: Yao Jin <[email protected]>
Perf script was failed to print the
phys_addrfor SPE profiling. One 'dummy' event is added by SPE profiling but it doesn't havePHYS_ADDRattribute set, perf script then exits with error.Now referring to 'addr', use
evsel__do_check_stype()to check the type.Before:
# perf record -e arm_spe_0/branch_filter=0,ts_enable=1,pa_enable=1,load_filter=1,jitter=0,\ store_filter=0,min_latency=0,event_filter=2/ -p 4064384 -- sleep 3 # perf script -F pid,tid,addr,phys_addr Samples for 'dummy:u' event do not have PHYS_ADDR attribute set. Cannot print 'phys_addr' field.After:
Quoted 8 lines
# perf record -e arm_spe_0/branch_filter=0,ts_enable=1,pa_enable=1,load_filter=1,jitter=0,\ store_filter=0,min_latency=0,event_filter=2/ -p 4064384 -- sleep 3 # perf script -F pid,tid,addr,phys_addr 4064384/4064384 ffff802f921be0d0 2f921be0d0 4064384/4064384 ffff802f921be0d0 2f921be0d0Signed-off-by Yao Jin <[email protected]>Signed-off-by Wei Li <[email protected]>
Also it looks like the SPE samples are also missing the PHYS_ADDR flag. I think we'll need to fix the consistency of the flags.
Many thanks,
German
Quoted 17 lines
--- tools/perf/builtin-script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-script.c +1
-1@@ -515,7 +515,7 @@ static int evsel__check_attr(struct evsel *evsel, struct perf_session *session)return -EINVAL ;if (PRINT_FIELD (PHYS_ADDR ) && -evsel__check_stype (evsel,PERF_SAMPLE_PHYS_ADDR ,"PHYS_ADDR" ,PERF_OUTPUT_PHYS_ADDR )) +evsel__do_check_stype (evsel,PERF_SAMPLE_PHYS_ADDR ,"PHYS_ADDR" ,PERF_OUTPUT_PHYS_ADDR , allow_user_set))return -EINVAL ; if (PRINT_FIELD(DATA_PAGE_SIZE) &&
Em Fri, Jan 21, 2022 at 11:24:57AM +0000, German Gomez escreveu:
Quoted 29 lines
Hi Wei,
This looks good to me. As a followup we could also fix the 'weight' field, which was introduced recently.
Quoted 23 lines · Wei Li
From: Yao Jin <[email protected]>
Perf script was failed to print the
phys_addrfor SPE profiling. One 'dummy' event is added by SPE profiling but it doesn't havePHYS_ADDRattribute set, perf script then exits with error.Now referring to 'addr', use
evsel__do_check_stype()to check the type.Before:
# perf record -e arm_spe_0/branch_filter=0,ts_enable=1,pa_enable=1,load_filter=1,jitter=0,\ store_filter=0,min_latency=0,event_filter=2/ -p 4064384 -- sleep 3 # perf script -F pid,tid,addr,phys_addr Samples for 'dummy:u' event do not have PHYS_ADDR attribute set. Cannot print 'phys_addr' field.After:
# perf record -e arm_spe_0/branch_filter=0,ts_enable=1,pa_enable=1,load_filter=1,jitter=0,\ store_filter=0,min_latency=0,event_filter=2/ -p 4064384 -- sleep 3 # perf script -F pid,tid,addr,phys_addr 4064384/4064384 ffff802f921be0d0 2f921be0d0 4064384/4064384 ffff802f921be0d0 2f921be0d0
Quoted 7 lines
Quoted 2 lines
Signed-off-by Yao Jin <[email protected]>Signed-off-by Wei Li <[email protected]>Reviewed-by German Gomez <[email protected]>Also it looks like the SPE samples are also missing the
PHYS_ADDRflag. I think we'll need to fix the consistency of the flags.
Thanks, applied.
- Arnaldo
Quoted 20 lines
Many thanks,
GermanQuoted 17 lines
--- tools/perf/builtin-script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-script.c +1
-1@@ -515,7 +515,7 @@ static int evsel__check_attr(struct evsel *evsel, struct perf_session *session)return -EINVAL ;if (PRINT_FIELD (PHYS_ADDR ) && -evsel__check_stype (evsel,PERF_SAMPLE_PHYS_ADDR ,"PHYS_ADDR" ,PERF_OUTPUT_PHYS_ADDR )) +evsel__do_check_stype (evsel,PERF_SAMPLE_PHYS_ADDR ,"PHYS_ADDR" ,PERF_OUTPUT_PHYS_ADDR , allow_user_set))return -EINVAL ; if (PRINT_FIELD(DATA_PAGE_SIZE) &&
Signature · 1 line
- Arnaldo