aiodio: Set timeout 30 min
PATCH 2/2 aiodio: Set timeout 30 min
Originally only ADSP075 failed (dio_sparse -w 518192k -s 518192k -n 1000) but just in case increase timeout for all newly rewritten tests.
--- testcases/kernel/io/ltp-aiodio/aiodio_append.c | 1 + testcases/kernel/io/ltp-aiodio/dio_append.c | 1 + testcases/kernel/io/ltp-aiodio/dio_read.c | 1 + testcases/kernel/io/ltp-aiodio/dio_sparse.c | 1 + testcases/kernel/io/ltp-aiodio/dio_truncate.c | 1 + 5 files changed, 5 insertions(+)
testcases/kernel/io/ltp-aiodio/aiodio_append.c +1 -0
@@ -183,6 +183,7 @@ static struct tst_test test = {"tmpfs" ,NULL }, + .timeout = 1800, };#else TST_TEST_TCONF ("test requires libaio and its development packages" );
testcases/kernel/io/ltp-aiodio/dio_append.c +1 -0
@@ -97,4 +97,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };
testcases/kernel/io/ltp-aiodio/dio_read.c +1 -0
@@ -181,4 +181,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };
testcases/kernel/io/ltp-aiodio/dio_sparse.c +1 -0
@@ -135,4 +135,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };
testcases/kernel/io/ltp-aiodio/dio_truncate.c +1 -0
@@ -169,4 +169,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };
Signature · 5 lines
2.34.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 2 lines
Originally only ADSP075 failed (
dio_sparse-w 518192k -s 518192k -n 1000) but just in case increase timeout for all newly rewritten tests.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi,
only dio_sparse really needs higher timeout because we use it for a slow stress test in a runfile. dio_read should get a lower default number of child processes instead (8 or 16 to keep the default memory requirements under 512MB).
The other programs finish in less than 30 seconds so if anybody wants to use them for a custom stress test, it's their responsibility to set LTP_TIMEOUT_MUL accordingly.
Quoted 65 lines · Petr Vorel
Originally only ADSP075 failed (
dio_sparse-w 518192k -s 518192k -n 1000) but just in case increase timeout for all newly rewritten tests.Suggested-by Cyril Hrubis <[email protected]>Signed-off-by Petr Vorel <[email protected]>--- testcases/kernel/io/ltp-aiodio/aiodio_append.c | 1 + testcases/kernel/io/ltp-aiodio/dio_append.c | 1 + testcases/kernel/io/ltp-aiodio/dio_read.c | 1 + testcases/kernel/io/ltp-aiodio/dio_sparse.c | 1 + testcases/kernel/io/ltp-aiodio/dio_truncate.c | 1 + 5 files changed, 5 insertions(+)testcases/kernel/io/ltp-aiodio/aiodio_append.c +1
-0@@ -183,6 +183,7 @@ static struct tst_test test = {"tmpfs" ,NULL }, + .timeout = 1800, };#else TST_TEST_TCONF ("test requires libaio and its development packages" );testcases/kernel/io/ltp-aiodio/dio_append.c +1
-0@@ -97,4 +97,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };testcases/kernel/io/ltp-aiodio/dio_read.c +1
-0@@ -181,4 +181,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };testcases/kernel/io/ltp-aiodio/dio_sparse.c +1
-0@@ -135,4 +135,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };testcases/kernel/io/ltp-aiodio/dio_truncate.c +1
-0@@ -169,4 +169,5 @@ static struct tst_test test = { "tmpfs",NULL }, + .timeout = 1800, };
Signature · 10 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 5 lines
Hi,
onlydio_sparsereally needs higher timeout because we use it for a slow stress test in a runfile.dio_readshould get a lower default number of child processes instead (8 or 16 to keep the default memory requirements under 512MB).
Thanks!
I also noticed dio_read, but as you pointed out it's already fixed by f3caabe44c ("Reduce memory footprint of the dio_read test")
Quoted 3 lines
The other programs finish in less than 30 seconds so if anybody wants to use them for a custom stress test, it's their responsibility to set
LTP_TIMEOUT_MULaccordingly.
+1
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 9 lines · Petr Vorel
Quoted 5 lines
Hi,
onlydio_sparsereally needs higher timeout because we use it for a slow stress test in a runfile.dio_readshould get a lower default number of child processes instead (8 or 16 to keep the default memory requirements under 512MB).Thanks!
I also noticed
dio_read, but as you pointed out it's already fixed byf3caabe44c("Reduce memory footprint of thedio_readtest")
Runfile usage is fixed but running the program manually with default setting would still result in extreme memory use. We should make the defaults more sensible as well.
Signature · 10 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
I agree with Martin that some tests in the aiodio testing suite should handle default value a bit better. To reduce the amount of memory/time required by manual execution with default values could be a task for the next future.
Quoted 14 lines · Martin Doucha
Quoted 9 lines · Petr Vorel
Quoted 5 lines
Hi,
onlydio_sparsereally needs higher timeout because we use it for a slow stress test in a runfile.dio_readshould get a lower default number of child processes instead (8 or 16 to keep the default memory requirements under 512MB).Thanks!
I also noticed
dio_read, but as you pointed out it's already fixed byf3caabe44c("Reduce memory footprint of thedio_readtest")Runfile usage is fixed but running the program manually with default setting would still result in extreme memory use. We should make the defaults more sensible as well.
Signature · 2 lines
-- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 6 lines · Petr Vorel
Quoted 5 lines
Quoted 5 lines
Hi,
onlydio_sparsereally needs higher timeout because we use it for a slow stress test in a runfile.dio_readshould get a lower default number of child processes instead (8 or 16 to keep the default memory requirements under 512MB).
Quoted 8 lines
Quoted 4 lines
Thanks!
I also noticed
dio_read, but as you pointed out it's already fixed byf3caabe44c("Reduce memory footprint of thedio_readtest")Runfile usage is fixed but running the program manually with default setting would still result in extreme memory use. We should make the defaults more sensible as well.
+1. So do we want in the end to increase dio_read just for now before release? That'd make sense to me.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp