tests: Refresh lcitool submodule & remove libxml2
Subsystems (3)
v6 cover tests: Refresh lcitool submodule & remove libxml2
This is my last respin on this series which is fully reviewed.
Refresh lcitool to latest and remove libxml2 (mjt).
v6:
- update libvirt-ci submodule to remove lttng-ust from FreeBSD runners
v5:
- update scripts/meson-buildoptions.sh (thuth)
- squash libvirt-ci updates (thuth)
v4:
- Fixed typos and cleaned checkpatch.pl (thuth)
- Corrected libvirt-ci submodule URL
v3:
- fix 'refresh' helper to update cirrus-ci files (danpb)
v2:
- rebased (testing/next)
- include mjt's libxml2 removal patch
Michael Tokarev (1):
drop libxml2 checks since libxml is not actually used (for parallels)
Philippe Mathieu-Daudé (6):
MAINTAINERS: Cover lcitool submodule with build test / automation
gitmodules: Correct libvirt-ci submodule URL tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files tests/lcitool: Refresh submodule and remove libxml2
tests: Manually remove libxml2 on MSYS2 runners tests/lcitool: Install libibumad to cover RDMA on Debian based distros
meson.build | 6 ------ .cirrus.yml | 1 - .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- .gitlab-ci.d/cirrus/macos-11.vars | 2 +- .gitlab-ci.d/windows.yml | 2 -- .gitmodules | 2 +- MAINTAINERS | 1 + block/meson.build | 3 +-- meson_options.txt | 2 -- scripts/checkpatch.pl | 1 - scripts/ci/org.centos/stream/8/x86_64/configure | 1 - scripts/coverity-scan/coverity-scan.docker | 1 - scripts/coverity-scan/run-coverity-scan | 2 +- scripts/meson-buildoptions.sh | 3 --- tests/docker/dockerfiles/alpine.docker | 4 ++-- tests/docker/dockerfiles/centos8.docker | 4 +--- tests/docker/dockerfiles/fedora.docker | 4 +--- tests/docker/dockerfiles/opensuse-leap.docker | 3 +-- tests/docker/dockerfiles/ubuntu1804.docker | 4 ++-- tests/docker/dockerfiles/ubuntu2004.docker | 4 ++-- tests/lcitool/libvirt-ci | 2 +- tests/lcitool/projects/qemu.yml | 2 +- tests/lcitool/refresh | 2 +- 24 files changed, 19 insertions(+), 41 deletions(-)
Signature · 1 line
2.34.1
PATCH v6 1/7 MAINTAINERS: Cover lcitool submodule with build test / automation
lcitool is used by build test / automation, we want maintainers to get notified if the submodule is updated.
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -3579,6 +3579,7 @@ F: .travis.yml F: scripts/ci/ F: tests/docker/ F: tests/vm/ +F: tests/lcitool/ F: scripts/archive-source.sh W: https://gitlab.com/qemu-project/qemu/pipelines W: https://travis-ci.org/qemu/qemu
Signature · 1 line
2.34.1
PATCH v6 2/7 gitmodules: Correct libvirt-ci submodule URL
In reply to Philippe Mathieu-Daudé viaCorrect the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule:
warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/
--- .gitmodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
.gitmodules +1 -1
@@ -66,4 +66,4 @@ url = https://gitlab.com/qemu-project/vbootrom.git [submodule "tests/lcitool/libvirt-ci"] path = tests/lcitool/libvirt-ci - url = http://gitlab.com/libvirt/libvirt-ci + url = https://gitlab.com/libvirt/libvirt-ci.git
Signature · 1 line
2.34.1
PATCH v6 3/7 tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files
In reply to Philippe Mathieu-Daudé viaThe script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus().
--- tests/lcitool/refresh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/lcitool/refresh +1 -1
@@ -62,7 +62,7 @@ def generate_dockerfile(host, target, cross=None, trailer=None): def generate_cirrus(target, trailer=None): filename = Path(src_dir, ".gitlab-ci.d", "cirrus", target + ".vars") - cmd = [lcitool_path, "variables", target, "qemu"] + cmd = lcitool_cmd + ["variables", target, "qemu"] generate(filename, cmd, trailer) ubuntu1804_skipssh = [
Signature · 1 line
2.34.1
PATCH v6 4/7 drop libxml2 checks since libxml is not actually used (for parallels)
In reply to Philippe Mathieu-Daudé viaFrom: Michael Tokarev <[email protected]>
For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies too.
It is even more: --enable-parallels configure option was the only option which was silently ignored when it's (fake) dependency (libxml2) isn't installed.
Drop all mentions of libxml2.
[*] Actually the basis for libxml use were introduced in commit
ed279a06c53 ("configure: add dependency") but the implementation was never merged:
https://lore.kernel.org/qemu-devel/[email protected]/
Message-Id: <[email protected]>
--- meson.build | 6 ------ block/meson.build | 3 +-- meson_options.txt | 2 -- scripts/checkpatch.pl | 1 - scripts/ci/org.centos/stream/8/x86_64/configure | 1 - scripts/coverity-scan/coverity-scan.docker | 1 - scripts/coverity-scan/run-coverity-scan | 2 +- scripts/meson-buildoptions.sh | 3 --- 8 files changed, 2 insertions(+), 17 deletions(-)
meson.build +0 -6
@@ -451,11 +451,6 @@ required: get_option('linux_io_uring'), method: 'pkg-config', kwargs: static_kwargs) endif -libxml2 = not_found -if not get_option('libxml2').auto() or have_block - libxml2 = dependency('libxml-2.0', required: get_option('libxml2'), - method: 'pkg-config', kwargs: static_kwargs) -endif libnfs = not_found if not get_option('libnfs').auto() or have_block libnfs = dependency('libnfs', version: '>=1.9.3',
@@ -3491,7 +3486,6 @@ summary_info += {'lzfse support': liblzfse} summary_info += {'zstd support': zstd} summary_info += {'NUMA host support': config_host.has_key('CONFIG_NUMA')} -summary_info += {'libxml2': libxml2} summary_info += {'capstone': capstone_opt == 'internal' ? capstone_opt : capstone} summary_info += {'libpmem support': libpmem} summary_info += {'libdaxctl support': libdaxctl}
block/meson.build +1 -2
@@ -58,8 +58,7 @@ 'qed-table.c', 'qed.c', )) -block_ss.add(when: [libxml2, 'CONFIG_PARALLELS'], - if_true: files('parallels.c', 'parallels-ext.c')) +block_ss.add(when: 'CONFIG_PARALLELS', if_true: files('parallels.c', 'parallels-ext.c')) block_ss.add(when: 'CONFIG_WIN32', if_true: files('file-win32.c', 'win32-aio.c')) block_ss.add(when: 'CONFIG_POSIX', if_true: [files('file-posix.c'), coref, iokit]) block_ss.add(when: libiscsi, if_true: files('iscsi-opts.c'))
meson_options.txt +0 -2
@@ -113,8 +113,6 @@ option('libudev', type : 'feature', value : 'auto', description: 'Use libudev to enumerate host devices') option('libusb', type : 'feature', value : 'auto', description: 'libusb support for USB passthrough') -option('libxml2', type : 'feature', value : 'auto', - description: 'libxml2 support for Parallels image format') option('linux_aio', type : 'feature', value : 'auto', description: 'Linux AIO support') option('linux_io_uring', type : 'feature', value : 'auto',
scripts/checkpatch.pl +0 -1
@@ -307,7 +307,6 @@ sub help { qr{target_(?:u)?long}, qr{hwaddr}, # external libraries - qr{xml${Ident}}, qr{xen\w+_handle}, # Glib definitions qr{gchar},
scripts/ci/org.centos/stream/8/x86_64/configure +0 -1
@@ -81,7 +81,6 @@ --disable-libssh \ --disable-libudev \ --disable-libusb \ ---disable-libxml2 \ --disable-linux-aio \ --disable-linux-io-uring \ --disable-linux-user \
scripts/coverity-scan/coverity-scan.docker +0 -1
@@ -59,7 +59,6 @@ ENV PACKAGES \ libubsan \ libudev-devel \ libusbx-devel \ - libxml2-devel \ libzstd-devel \ llvm \ lzo-devel \
scripts/coverity-scan/run-coverity-scan +1 -1
@@ -402,7 +402,7 @@ echo "Configuring..." --enable-libiscsi --enable-libnfs --enable-seccomp \ --enable-tpm --enable-libssh --enable-lzo --enable-snappy --enable-bzip2 \ --enable-numa --enable-rdma --enable-smartcard --enable-virglrenderer \ - --enable-mpath --enable-libxml2 --enable-glusterfs \ + --enable-mpath --enable-glusterfs \ --enable-virtfs --enable-zstd echo "Running cov-build..."
scripts/meson-buildoptions.sh +0 -3
@@ -58,7 +58,6 @@ meson_options_help() { printf "%s\n" ' libssh ssh block device support' printf "%s\n" ' libudev Use libudev to enumerate host devices' printf "%s\n" ' libusb libusb support for USB passthrough' - printf "%s\n" ' libxml2 libxml2 support for Parallels image format' printf "%s\n" ' linux-aio Linux AIO support' printf "%s\n" ' linux-io-uring Linux io_uring support' printf "%s\n" ' lzfse lzfse support for DMG images'
@@ -188,8 +187,6 @@ _meson_option_parse() { --disable-libudev) printf "%s" -Dlibudev=disabled ;; --enable-libusb) printf "%s" -Dlibusb=enabled ;; --disable-libusb) printf "%s" -Dlibusb=disabled ;; - --enable-libxml2) printf "%s" -Dlibxml2=enabled ;; - --disable-libxml2) printf "%s" -Dlibxml2=disabled ;; --enable-linux-aio) printf "%s" -Dlinux_aio=enabled ;; --disable-linux-aio) printf "%s" -Dlinux_aio=disabled ;; --enable-linux-io-uring) printf "%s" -Dlinux_io_uring=enabled ;;
Signature · 1 line
2.34.1
PATCH v6 5/7 tests/lcitool: Refresh submodule and remove libxml2
In reply to Philippe Mathieu-Daudé viaThe previous commit removed all uses of libxml2.
Refresh lcitool submodule, update qemu.yml and refresh the generated files by running:
$ make lcitool-refresh
Note: This refreshment also removes libudev dependency on Fedora and CentOS due to libvirt-ci commit 18bfaee ("mappings: Improve mapping for libudev"), since "The udev project has been absorbed by the systemd project", and lttng-ust on FreeBSD runners due to libvirt-ci commit 6dd9b6f ("guests: drop lttng-ust from FreeBSD platform").
--- .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- .gitlab-ci.d/cirrus/macos-11.vars | 2 +- tests/docker/dockerfiles/alpine.docker | 4 ++-- tests/docker/dockerfiles/centos8.docker | 4 +--- tests/docker/dockerfiles/fedora.docker | 4 +--- tests/docker/dockerfiles/opensuse-leap.docker | 3 +-- tests/docker/dockerfiles/ubuntu1804.docker | 3 +-- tests/docker/dockerfiles/ubuntu2004.docker | 3 +-- tests/lcitool/libvirt-ci | 2 +- tests/lcitool/projects/qemu.yml | 1 - 11 files changed, 11 insertions(+), 19 deletions(-)
.gitlab-ci.d/cirrus/freebsd-12.vars +1 -1
@@ -11,6 +11,6 @@ MAKE='/usr/local/bin/gmake' NINJA='/usr/local/bin/ninja' PACKAGING_COMMAND='pkg' PIP3='/usr/local/bin/pip-3.8' -PKGS='alsa-lib bash bzip2 ca_root_nss capstone4 ccache cdrkit-genisoimage ctags curl cyrus-sasl dbus diffutils dtc gettext git glib gmake gnutls gsed gtk3 libepoxy libffi libgcrypt libjpeg-turbo libnfs libspice-server libssh libtasn1 libxml2 llvm lttng-ust lzo2 meson ncurses nettle ninja opencv p5-Test-Harness perl5 pixman pkgconf png py38-numpy py38-pillow py38-pip py38-sphinx py38-sphinx_rtd_theme py38-virtualenv py38-yaml python3 rpm2cpio sdl2 sdl2_image snappy spice-protocol tesseract texinfo usbredir virglrenderer vte3 zstd' +PKGS='alsa-lib bash bzip2 ca_root_nss capstone4 ccache cdrkit-genisoimage ctags curl cyrus-sasl dbus diffutils dtc fusefs-libs3 gettext git glib gmake gnutls gsed gtk3 libepoxy libffi libgcrypt libjpeg-turbo libnfs libspice-server libssh libtasn1 llvm lzo2 meson ncurses nettle ninja opencv p5-Test-Harness perl5 pixman pkgconf png py38-numpy py38-pillow py38-pip py38-sphinx py38-sphinx_rtd_theme py38-virtualenv py38-yaml python3 rpm2cpio sdl2 sdl2_image snappy spice-protocol tesseract texinfo usbredir virglrenderer vte3 zstd' PYPI_PKGS='' PYTHON='/usr/local/bin/python3'
.gitlab-ci.d/cirrus/freebsd-13.vars +1 -1
@@ -11,6 +11,6 @@ MAKE='/usr/local/bin/gmake' NINJA='/usr/local/bin/ninja' PACKAGING_COMMAND='pkg' PIP3='/usr/local/bin/pip-3.8' -PKGS='alsa-lib bash bzip2 ca_root_nss capstone4 ccache cdrkit-genisoimage ctags curl cyrus-sasl dbus diffutils dtc gettext git glib gmake gnutls gsed gtk3 libepoxy libffi libgcrypt libjpeg-turbo libnfs libspice-server libssh libtasn1 libxml2 llvm lttng-ust lzo2 meson ncurses nettle ninja opencv p5-Test-Harness perl5 pixman pkgconf png py38-numpy py38-pillow py38-pip py38-sphinx py38-sphinx_rtd_theme py38-virtualenv py38-yaml python3 rpm2cpio sdl2 sdl2_image snappy spice-protocol tesseract texinfo usbredir virglrenderer vte3 zstd' +PKGS='alsa-lib bash bzip2 ca_root_nss capstone4 ccache cdrkit-genisoimage ctags curl cyrus-sasl dbus diffutils dtc fusefs-libs3 gettext git glib gmake gnutls gsed gtk3 libepoxy libffi libgcrypt libjpeg-turbo libnfs libspice-server libssh libtasn1 llvm lzo2 meson ncurses nettle ninja opencv p5-Test-Harness perl5 pixman pkgconf png py38-numpy py38-pillow py38-pip py38-sphinx py38-sphinx_rtd_theme py38-virtualenv py38-yaml python3 rpm2cpio sdl2 sdl2_image snappy spice-protocol tesseract texinfo usbredir virglrenderer vte3 zstd' PYPI_PKGS='' PYTHON='/usr/local/bin/python3'
.gitlab-ci.d/cirrus/macos-11.vars +1 -1
@@ -11,6 +11,6 @@ MAKE='/usr/local/bin/gmake' NINJA='/usr/local/bin/ninja' PACKAGING_COMMAND='brew' PIP3='/usr/local/bin/pip3' -PKGS='bash bc bzip2 capstone ccache cpanminus ctags curl dbus diffutils dtc gcovr gettext git glib gnu-sed gnutls gtk+3 jemalloc jpeg-turbo libepoxy libffi libgcrypt libiscsi libnfs libpng libslirp libssh libtasn1 libusb libxml2 llvm lzo make meson ncurses nettle ninja perl pixman pkg-config python3 rpm2cpio sdl2 sdl2_image snappy sparse spice-protocol tesseract texinfo usbredir vde vte3 zlib zstd' +PKGS='bash bc bzip2 capstone ccache cpanminus ctags curl dbus diffutils dtc gcovr gettext git glib gnu-sed gnutls gtk+3 jemalloc jpeg-turbo libepoxy libffi libgcrypt libiscsi libnfs libpng libslirp libssh libtasn1 libusb llvm lzo make meson ncurses nettle ninja perl pixman pkg-config python3 rpm2cpio sdl2 sdl2_image snappy sparse spice-protocol tesseract texinfo usbredir vde vte3 zlib zstd' PYPI_PKGS='PyYAML numpy pillow sphinx sphinx-rtd-theme virtualenv' PYTHON='/usr/local/bin/python3'
tests/docker/dockerfiles/alpine.docker +2 -2
@@ -1,6 +1,6 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool dockerfile alpine-edge qemu +# $ lcitool dockerfile --layers all alpine-edge qemu # # https://gitlab.com/libvirt/libvirt-ci
@@ -56,7 +56,6 @@ RUN apk update && \ libtasn1-dev \ liburing-dev \ libusb-dev \ - libxml2-dev \ linux-pam-dev \ llvm11 \ lttng-ust-dev \
@@ -109,6 +108,7 @@ RUN apk update && \ zlib-dev \ zlib-static \ zstd-dev && \ + apk list | sort > /packages.txt && \ mkdir -p /usr/libexec/ccache-wrappers && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/c++ && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/cc && \
tests/docker/dockerfiles/centos8.docker +1 -3
@@ -1,6 +1,6 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool dockerfile centos-8 qemu +# $ lcitool dockerfile --layers all centos-8 qemu # # https://gitlab.com/libvirt/libvirt-ci
@@ -69,10 +69,8 @@ RUN dnf update -y && \ libssh-devel \ libtasn1-devel \ libubsan \ - libudev-devel \ liburing-devel \ libusbx-devel \ - libxml2-devel \ libzstd-devel \ llvm \ lttng-ust-devel \
tests/docker/dockerfiles/fedora.docker +1 -3
@@ -1,6 +1,6 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool dockerfile fedora-35 qemu +# $ lcitool dockerfile --layers all fedora-35 qemu # # https://gitlab.com/libvirt/libvirt-ci
@@ -77,10 +77,8 @@ exec "$@"' > /usr/bin/nosync && \ libssh-devel \ libtasn1-devel \ libubsan \ - libudev-devel \ liburing-devel \ libusbx-devel \ - libxml2-devel \ libzstd-devel \ llvm \ lttng-ust-devel \
tests/docker/dockerfiles/opensuse-leap.docker +1 -2
@@ -1,6 +1,6 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool dockerfile opensuse-leap-152 qemu +# $ lcitool dockerfile --layers all opensuse-leap-152 qemu # # https://gitlab.com/libvirt/libvirt-ci
@@ -71,7 +71,6 @@ RUN zypper update -y && \ libudev-devel \ liburing-devel \ libusb-1_0-devel \ - libxml2-devel \ libzstd-devel \ llvm \ lttng-ust-devel \
tests/docker/dockerfiles/ubuntu1804.docker +1 -2
@@ -1,6 +1,6 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool dockerfile ubuntu-1804 qemu +# $ lcitool dockerfile --layers all ubuntu-1804 qemu # # https://gitlab.com/libvirt/libvirt-ci
@@ -89,7 +89,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ libvirglrenderer-dev \ libvte-2.91-dev \ libxen-dev \ - libxml2-dev \ libzstd-dev \ llvm \ locales \
tests/docker/dockerfiles/ubuntu2004.docker +1 -2
@@ -1,6 +1,6 @@ # THIS FILE WAS AUTO-GENERATED # -# $ lcitool dockerfile ubuntu-2004 qemu +# $ lcitool dockerfile --layers all ubuntu-2004 qemu # # https://gitlab.com/libvirt/libvirt-ci
@@ -91,7 +91,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ libvirglrenderer-dev \ libvte-2.91-dev \ libxen-dev \ - libxml2-dev \ libzstd-dev \ llvm \ locales \
tests/lcitool/libvirt-ci +1 -1
@@ -1 +1 @@ -Subproject commit 29cec2153b9a4dbb2e66f1cbc9866a4eff519cfd +Subproject commit 6dd9b6fab1fe081b16bc975485d7a02c81ba5fbe
tests/lcitool/projects/qemu.yml +0 -1
@@ -63,7 +63,6 @@ packages: - liburing - libusbx - libvdeplug - - libxml2 - libzstd - llvm - lttng-ust
Signature · 1 line
2.34.1
PATCH v6 6/7 tests: Manually remove libxml2 on MSYS2 runners
In reply to Philippe Mathieu-Daudé vialcitool doesn't support MSYS2 targets, so manually remove this now unnecessary library.
--- .cirrus.yml | 1 - .gitlab-ci.d/windows.yml | 2 -- 2 files changed, 3 deletions(-)
.cirrus.yml +0 -1
@@ -32,7 +32,6 @@ windows_msys2_task: mingw-w64-x86_64-libgcrypt mingw-w64-x86_64-libpng mingw-w64-x86_64-libssh - mingw-w64-x86_64-libxml2 mingw-w64-x86_64-snappy mingw-w64-x86_64-libusb mingw-w64-x86_64-usbredir
.gitlab-ci.d/windows.yml +0 -2
@@ -44,7 +44,6 @@ msys2-64bit: mingw-w64-x86_64-libssh mingw-w64-x86_64-libtasn1 mingw-w64-x86_64-libusb - mingw-w64-x86_64-libxml2 mingw-w64-x86_64-nettle mingw-w64-x86_64-ninja mingw-w64-x86_64-pixman
@@ -80,7 +79,6 @@ msys2-32bit: mingw-w64-i686-libssh mingw-w64-i686-libtasn1 mingw-w64-i686-libusb - mingw-w64-i686-libxml2 mingw-w64-i686-lzo2 mingw-w64-i686-ninja mingw-w64-i686-pixman
Signature · 1 line
2.34.1
PATCH v6 7/7 tests/lcitool: Install libibumad to cover RDMA on Debian based distros
In reply to Philippe Mathieu-Daudé viaOn Debian we also need libibumad to enable RDMA:
$ ../configure --enable-rdma
ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present.
Your options:
(1) Fast: Install infiniband packages (devel) from your distro.
(2) Cleanest: Install libraries from www.openfabrics.org
(3) Also: Install softiwarp if you don't have RDMA hardware
Add the dependency to lcitool's qemu.yml (where librdmacm and libibverbs are already listed) and refresh the generated files by running:
$ make lcitool-refresh
--- tests/docker/dockerfiles/ubuntu1804.docker | 1 + tests/docker/dockerfiles/ubuntu2004.docker | 1 + tests/lcitool/projects/qemu.yml | 1 + 3 files changed, 3 insertions(+)
tests/docker/dockerfiles/ubuntu1804.docker +1 -0
@@ -52,6 +52,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ libglib2.0-dev \ libgnutls28-dev \ libgtk-3-dev \ + libibumad-dev \ libibverbs-dev \ libiscsi-dev \ libjemalloc-dev \
tests/docker/dockerfiles/ubuntu2004.docker +1 -0
@@ -53,6 +53,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ libglusterfs-dev \ libgnutls28-dev \ libgtk-3-dev \ + libibumad-dev \ libibverbs-dev \ libiscsi-dev \ libjemalloc-dev \
tests/lcitool/projects/qemu.yml +1 -0
@@ -43,6 +43,7 @@ packages: - libfdt - libffi - libgcrypt + - libibumad - libibverbs - libiscsi - libjemalloc
Signature · 1 line
2.34.1
Quoted 3 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
Refresh lcitool to latest and remove libxml2 (mjt).
Queued to testing/next, thanks.
Signature · 1 line
Alex Bennée
Quoted 2 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
<snip>
Just to note the "b4" application of this broke the From addresses. If you see the lore copy:
https://lore.kernel.org/qemu-devel/[email protected]/
all your From's are via qemu-devel. Have you changed anything about your submission process?
Signature · 1 line
Alex Bennée
Quoted 7 lines · Alex Bennée
Quoted 2 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
<snip>
Quoted 7 lines
Just to note the "b4" application of this broke the From addresses. If you see the lore copy:
https://lore.kernel.org/qemu-devel/[email protected]/
all your From's are via qemu-devel. Have you changed anything about your submission process?
No. Maybe the list changed something again? Similar problem occurred 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org
If it helps you can get them on my branch macos12:
https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745
Quoted 11 lines · Philippe Mathieu-Daudé
Quoted 10 lines · Alex Bennée
Quoted 2 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
<snip>
Just to note the "b4" application of this broke the From addresses. If you see the lore copy:
Quoted 8 lines
Quoted 4 lines
https://lore.kernel.org/qemu-devel/[email protected]/
all your From's are via qemu-devel. Have you changed anything about your submission process?
No. Maybe the list changed something again? Similar problem occurred 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org
I thought so but others in the archives are fine. I take it you can't ask the owners of amsat.org to expand the SPF setting or use the MX server indicated to send emails?
Otherwise it might be worth either getting your own gmail or domain for posting.
Quoted 3 lines
If it helps you can get them on my branch macos12:
https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745
I nabbed it with my old-school patch handling which still works but doesn't auto collect tags for me ;-)
Signature · 1 line
Alex Bennée
Quoted 23 lines · Alex Bennée
Quoted 11 lines · Philippe Mathieu-Daudé
Quoted 10 lines · Alex Bennée
Quoted 2 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
<snip>
Just to note the "b4" application of this broke the From addresses. If you see the lore copy:
Quoted 8 lines
Quoted 4 lines
https://lore.kernel.org/qemu-devel/[email protected]/
all your From's are via qemu-devel. Have you changed anything about your submission process?
No. Maybe the list changed something again? Similar problem occurred 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org
Quoted 6 lines
I thought so but others in the archives are fine. I take it you can't ask the owners of amsat.org to expand the SPF setting or use the MX server indicated to send emails?
Otherwise it might be worth either getting your own gmail or domain for posting.
=)
I'm seeing the same with Mark's email: Mark Cave-Ayland via <[email protected]> maybe Google is running a global SMTP purge?
Similar SPF/DKIM errors:
https://toolbox.googleapps.com/apps/checkmx/check?domain=ilande.co.uk
Quoted 8 lines
Quoted 4 lines
If it helps you can get them on my branch macos12:
https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745I nabbed it with my old-school patch handling which still works but doesn't auto collect tags for me ;-)
Quoted 31 lines · Philippe Mathieu-Daudé
Quoted 23 lines · Alex Bennée
Quoted 11 lines · Philippe Mathieu-Daudé
Quoted 10 lines · Alex Bennée
Quoted 2 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
<snip>
Just to note the "b4" application of this broke the From addresses. If you see the lore copy:
Quoted 8 lines
Quoted 4 lines
https://lore.kernel.org/qemu-devel/[email protected]/
all your From's are via qemu-devel. Have you changed anything about your submission process?
No. Maybe the list changed something again? Similar problem occurred 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.orgQuoted 6 lines
I thought so but others in the archives are fine. I take it you can't ask the owners of amsat.org to expand the SPF setting or use the MX server indicated to send emails?
Otherwise it might be worth either getting your own gmail or domain for posting.
Quoted 15 lines
=)
I'm seeing the same with Mark's email: Mark Cave-Ayland via <[email protected]> maybe Google is running a global SMTP purge?
Similar SPF/DKIM errors:
https://toolbox.googleapps.com/apps/checkmx/check?domain=ilande.co.ukQuoted 7 lines
Quoted 4 lines
If it helps you can get them on my branch macos12:
https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745I nabbed it with my old-school patch handling which still works but doesn't auto collect tags for me ;-)
I'm seeing the same issue with these domains since mid december:
- amd.com
- huawei.com
- hisilicon.com
- ilande.co.uk
- amsat.org
- rev.ng
https://lore.kernel.org/qemu-devel/[email protected]/
https://lore.kernel.org/qemu-devel/[email protected]/
https://lore.kernel.org/qemu-devel/[email protected]/
https://lore.kernel.org/qemu-devel/20220105185720.0d4fc159@orange/
https://lore.kernel.org/qemu-devel/[email protected]/
Quoted 8 lines · On Tue, 25 Jan 2022 11:59:38 +0100 Philippe Mathieu-Daudé via…
I'm seeing the same issue with these domains since mid december:
...
- rev.ng...
https://lore.kernel.org/qemu-devel/20220105185720.0d4fc159@orange/
...
I've tried to look into this and it looks like our set up should be OK. We enabled SPF (i.e., a rule stating that only our mailserver can send e-mail with our domain in "From:") and DKIM (i.e., our mailserver signs certain portions of the e-mail). We also enabled DMARC which coordinates the two.
Now, as far as I understand, mailing lists can either rewrite the "From" header (as qemu-devel does) or leave it as it is. In the latter situation, SPF will fail but DMARC should instruct MTAs to check DKIM, and that should pass.
https://begriffs.com/posts/2018-09-18-dmarc-mailing-list.html https://dmarc.org/wiki/FAQ#I_operate_a_mailing_list_and_I_want_to_interoperate_with_DMARC.2C_what_should_I_do.3F
DKIM signature can be corrupted in case the mailing list tampers with the subject or the body of the e-mail, but this doesn't seem to be the
case: I've tried to manually verify the DKIM signature of the same e-mail that I got both from the mailing list and directly from the sender (I was in Cc), and they both verify correctly.
tl;dr I *think* rewriting the From header should not be necessary for our domain.
If you guys think this is not the case and there's something we can do to improve the situation (other than adding gmail.com to our SPF record), let me know.
Signature · 2 lines
Alessandro Di Federico rev.ng Labs
Quoted 31 lines · Philippe Mathieu-Daudé via
Quoted 23 lines · Alex Bennée
Quoted 11 lines · Philippe Mathieu-Daudé
Quoted 10 lines · Alex Bennée
Quoted 2 lines · Philippe Mathieu-Daudé
This is my last respin on this series which is fully reviewed.
<snip>
Just to note the "b4" application of this broke the From addresses. If you see the lore copy:
Quoted 8 lines
Quoted 4 lines
https://lore.kernel.org/qemu-devel/[email protected]/all your From's are via qemu-devel. Have you changed anything about your submission process?
No. Maybe the list changed something again? Similar problem occurred 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.orgQuoted 6 lines
I thought so but others in the archives are fine. I take it you can't ask the owners of amsat.org to expand the SPF setting or use the MX server indicated to send emails?
Otherwise it might be worth either getting your own gmail or domain for posting.
Quoted 7 lines
=)
I'm seeing the same with Mark's email: Mark Cave-Ayland via <[email protected]> maybe Google is running a global SMTP purge?
Similar SPF/DKIM errors:
https://toolbox.googleapps.com/apps/checkmx/check?domain=ilande.co.uk
Is there something that needs to be changed in my email setup? My email isn't managed by GMail so I'm lacking a bit of context here.
ATB,
Mark.