Skip to contentSkip to conversation

tests/kms_scaling_modes: New IGT to validate scaling modes

PATCH Superseded Swati Sharma 4 participants 6 messages Jan 21, 2022 – Jan 24, 2022 Arm/Amlogic Meson SoC support

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/kms_scaling_modes: New IGT to validate scaling modes

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are 4 types of scaling modes defined:
None:
No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
Full:
The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
Center:
No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
Full aspect:
The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

v2: -removed test flags/test_cycle_flags() (JP)
-removed redundant igt_display_commit_atomic() (JP) -corrected indentation (JP)

---
 tests/kms_scaling_modes.c | 144 ++++++++++++++++++++++++++++++++++++++
 tests/meson.build         |   1 +
 2 files changed, 145 insertions(+)
 create mode 100644 tests/kms_scaling_modes.c
tests/kms_scaling_modes.c new file +144 -0
new file mode 100644
index 00000000..28b5801a
@@ -0,0 +1,144 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Author:
+ *     Swati Sharma <[email protected]>
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Common test data */
+typedef struct data {
+	igt_display_t display;
+	int drm_fd;
+} data_t;
+
+static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe pipe,
+					igt_output_t *output, uint32_t flags)
+{
+	igt_plane_t *primary, *sprite;
+	drmModeModeInfo mode;
+	struct igt_fb red, blue;
+	int ret;
+
+	igt_output_set_pipe(output, pipe);
+	mode = *igt_output_get_mode(output);
+
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    0.f, 0.f, 1.f, &blue);
+
+	igt_create_color_fb(display->drm_fd, 640, 480,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    1.f, 0.f, 0.f, &red);
+
+	igt_plane_set_fb(primary, &blue);
+	igt_plane_set_fb(sprite, &red);
+
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	mode.hdisplay = 640;
+	mode.vdisplay = 480;
+	igt_output_override_mode(output, &mode);
+
+	igt_plane_set_fb(sprite, NULL);
+	igt_plane_set_fb(primary, &red);
+
+	igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, flags);
+
+	/* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+	ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+	if (ret == -EINVAL)
+		igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n");
+
+	igt_remove_fb(display->drm_fd, &red);
+	igt_remove_fb(display->drm_fd, &blue);
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+	return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+	       igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+	int valid_tests = 0;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {
+		if (!has_scaling_mode(output))
+			continue;
+
+		igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe));
+		igt_display_reset(display);
+		test_scaling_mode_on_output(display, pipe, output, flags);
+		valid_tests++;
+	}
+
+	igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+		igt_require(data.drm_fd >= 0);
+
+		kmstest_set_vt_graphics_mode();
+
+		igt_display_require(&data.display, data.drm_fd);
+		igt_require(data.display.is_atomic);
+
+		igt_display_require_output(&data.display);
+	}
+
+	igt_describe("Tests full display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full")
+		test_scaling_mode(&data, DRM_MODE_SCALE_FULLSCREEN);
+	igt_describe("Tests center display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-center")
+		test_scaling_mode(&data, DRM_MODE_SCALE_CENTER);
+	igt_describe("Tests full aspect display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full-aspect")
+		test_scaling_mode(&data, DRM_MODE_SCALE_ASPECT);
+	igt_describe("Tests none display scaling mode (no scaling)");
+	igt_subtest_with_dynamic("scaling-mode-none")
+		test_scaling_mode(&data, DRM_MODE_SCALE_NONE);
+
+	igt_fixture
+		igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
 	'kms_properties',
 	'kms_rmfb',
 	'kms_rotation_crc',
+	'kms_scaling_modes',
 	'kms_selftest',
 	'kms_sequence',
 	'kms_setmode',
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_scaling_modes: New IGT to validate scaling modes (rev3)

== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes (rev3)
URL : https://patchwork.freedesktop.org/series/98463/
State : success

== Summary ==

CI Bug Log - changes from IGT_6330 -> IGTPW_6568
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/index.html

Participating hosts (45 -> 42)
------------------------------

Additional (3): fi-kbl-soraka fi-skl-6600u fi-pnv-d510
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-bdw-samus

Known issues
------------

Here are the changes found in IGTPW_6568 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
- fi-skl-6600u: NOTRUN -> [SKIP][2] ([fdo#109271]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-skl-6600u/igt@gem_exec_fence@[email protected]

* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: NOTRUN -> [INCOMPLETE][3] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-skl-6600u/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [PASS][6] -> [INCOMPLETE][7] ([i915#4418])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/bat-dg1-5/igt@i915_selftest@live@gt_engines.html

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#2291])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-kbl-soraka/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#533])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-kbl-soraka/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][11] ([fdo#109271]) +57 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-pnv-d510/igt@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][12] ([i915#2722] / [i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/fi-skl-6600u/igt@[email protected]
- bat-dg1-5: NOTRUN -> [FAIL][13] ([i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/bat-dg1-5/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][14] ([i915#4494]) -> [DMESG-FAIL][15] ([i915#4494] / [i915#4957])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/bat-dg1-6/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/bat-dg1-6/igt@i915_selftest@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6330 -> IGTPW_6568

CI-20190529: 20190529
CI_DRM_11118: a8ae2fba8948946087ddc13ec6f4c44b6bcf3c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6568: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/index.html
IGT_6330: f73008bac9a8db0779264b170f630483e9165764 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

+igt@kms_scaling_modes@scaling-mode-center
+igt@kms_scaling_modes@scaling-mode-full
+igt@kms_scaling_modes@scaling-mode-full-aspect
+igt@kms_scaling_modes@scaling-mode-none

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/index.html

#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_scaling_modes: New IGT to validate scaling modes (rev3)

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes (rev3)
URL : https://patchwork.freedesktop.org/series/98463/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6330_full -> IGTPW_6568_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6568_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6568_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/index.html

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6568_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@flip-vs-fences-interruptible@b-vga1:
- shard-snb: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-snb4/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-snb5/igt@kms_flip@[email protected]

New tests
---------

New tests have been introduced between IGT_6330_full and IGTPW_6568_full:

### New IGT tests (17) ###

* igt@kms_scaling_modes@scaling-mode-center:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-b:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-c:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect:
- Statuses : 3 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-b:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-c:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-b:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-c:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-none:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in IGTPW_6568_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@display-4x:
- shard-tglb: NOTRUN -> [SKIP][3] ([i915#1839])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][4] ([i915#1839])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@[email protected]

* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#280])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2846])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl4/igt@[email protected]
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2846])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk8/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][12] ([i915#2846])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl2/igt@[email protected]

* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk5/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2842]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl7/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-apl7/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb5/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-apl8/igt@gem_exec_suspend@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl6/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][23] -> [SKIP][24] ([i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-tglb2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb7/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4613]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#4613]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb3/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb3/igt@[email protected]

* igt@gem_pxp@fail-invalid-protected-context:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#4270])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#4270])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#3297])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3297])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb3/igt@[email protected]

* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271]) +92 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl2/igt@[email protected]

* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#2527] / [i915#2856])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#2856])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][37] -> [FAIL][38] ([i915#454])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb3/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109293] / [fdo#109506])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#109506] / [i915#2411])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3777])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl6/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-glk: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3777]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk2/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111615])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb8/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3777]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl3/igt@[email protected]

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl8/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk3/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3689] / [i915#3886]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb8/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl4/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278] / [i915#3886]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#3689]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_ccs.html

* igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111615] / [i915#3689]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb5/igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs.html

* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +8 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl6/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-snb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@[email protected]

* igt@kms_chamelium@vga-frame-dump:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk5/igt@[email protected]

* igt@kms_color@pipe-d-ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278] / [i915#1149])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb4/igt@[email protected]

* igt@kms_color@pipe-d-invalid-ctm-matrix-sizes:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271]) +35 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109278]) +9 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-limited-range:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [fdo#111827]) +4 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3319]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109279] / [i915#3359])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-32x10-sliding:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271]) +61 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-snb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#3359]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109274] / [fdo#111825]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109274] / [fdo#109278])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb8/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [PASS][67] -> [FAIL][68] ([i915#2346])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#426])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#426])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-glk: [PASS][71] -> [FAIL][72] ([i915#1888])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk9/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][73] -> [INCOMPLETE][74] ([i915#180])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-apl7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl1/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#79])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk9/igt@kms_flip@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk5/igt@kms_flip@[email protected]

* igt@kms_flip@2x-flip-vs-panning:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109274])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb4/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][78] -> [DMESG-WARN][79] ([i915#180]) +5 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl6/igt@kms_flip@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-kbl: [PASS][80] -> [INCOMPLETE][81] ([i915#636])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl3/igt@kms_flip@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][82] ([fdo#109280] / [fdo#111825]) +10 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109280]) +7 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html

* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#1187])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb5/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#533])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl6/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl4/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#2920])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb1/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl7/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl7/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][92] -> [SKIP][93] ([fdo#109441])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][94] ([i915#132] / [i915#3467]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb8/igt@kms_psr@psr2_cursor_plane_onoff.html
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109441]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html

* {igt@kms_scaling_modes@scaling-mode-full-aspect} (NEW):
- shard-kbl: NOTRUN -> [SKIP][96] ([fdo#109271]) +106 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl7/igt@[email protected]

* igt@kms_setmode@basic:
- shard-apl: [PASS][97] -> [FAIL][98] ([i915#31])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-apl6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl2/igt@[email protected]

* igt@nouveau_crc@pipe-b-source-rg:
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#2530]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb5/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-glk: [PASS][101] -> [FAIL][102] ([i915#1542])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk7/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk2/igt@[email protected]

* igt@prime_nv_api@i915_nv_import_twice:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109291])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb3/igt@prime_nv_api@i915_nv_import_twice.html
- shard-tglb: NOTRUN -> [SKIP][104] ([fdo#109291])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb3/igt@prime_nv_api@i915_nv_import_twice.html

* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2994]) +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][106] ([i915#2994])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][107] ([i915#2994])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2994])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk5/igt@[email protected]

* igt@sysfs_clients@split-50:
- shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2994]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl2/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-kbl: [INCOMPLETE][110] ([i915#794]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl4/igt@gem_ctx_isolation@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl7/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][112] ([i915#2410]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-tglb8/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb5/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [TIMEOUT][114] ([i915#3070]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb2/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb6/igt@[email protected]

* igt@gem_eio@in-flight-immediate:
- shard-tglb: [TIMEOUT][116] ([i915#3063]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-tglb2/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb1/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][118] ([i915#4525]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-iclb6/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][120] ([i915#2842]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-tglb8/igt@gem_exec_fair@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-tglb6/igt@gem_exec_fair@[email protected]
- shard-glk: [FAIL][122] ([i915#2842]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk4/igt@gem_exec_fair@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][124] ([i915#2842]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-apl7/igt@gem_exec_fair@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][126] ([i915#2842]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl3/igt@gem_exec_fair@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [FAIL][128] ([i915#4171]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-glk6/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][130] ([fdo#109271]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-apl3/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-apl8/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][132] ([i915#180]) -> [PASS][133] +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-kbl4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/shard-kbl6/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [DMESG-WARN][134] ([i915#118]) -> [PASS][135] +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6330/shard-glk2/igt@kms_big_fb@x-tiled-32bpp

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6568/index.html

#3 lore raw
In reply to Swati Sharma
Quoted 140 lines · Swati Sharma

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are 4 types of scaling modes defined:
None:
No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
Full:
The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
Center:
No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
Full aspect:
The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

v2: -removed test flags/test_cycle_flags() (JP)
-removed redundant igt_display_commit_atomic() (JP) -corrected indentation (JP)

---
  tests/kms_scaling_modes.c | 144 ++++++++++++++++++++++++++++++++++++++
  tests/meson.build         |   1 +
  2 files changed, 145 insertions(+)

create mode 100644 tests/kms_scaling_modes.c

tests/kms_scaling_modes.c new file +100 -0
new file mode 100644
index 00000000..28b5801a
@@ -0,0 +1,144 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Author:
+ *     Swati Sharma <[email protected]>
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Common test data */
+typedef struct data {
+	igt_display_t display;
+	int drm_fd;
+} data_t;
+
+static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe pipe,
+					igt_output_t *output, uint32_t flags)
+{
+	igt_plane_t *primary, *sprite;
+	drmModeModeInfo mode;
+	struct igt_fb red, blue;
+	int ret;
+
+	igt_output_set_pipe(output, pipe);
+	mode = *igt_output_get_mode(output);
+
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    0.f, 0.f, 1.f, &blue);
+
+	igt_create_color_fb(display->drm_fd, 640, 480,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    1.f, 0.f, 0.f, &red);
+
+	igt_plane_set_fb(primary, &blue);
+	igt_plane_set_fb(sprite, &red);
+
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	mode.hdisplay = 640;
+	mode.vdisplay = 480;
+	igt_output_override_mode(output, &mode);
+
+	igt_plane_set_fb(sprite, NULL);
+	igt_plane_set_fb(primary, &red);
+
+	igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, flags);
+
+	/* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+	ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+	if (ret == -EINVAL)
+		igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n");
+
+	igt_remove_fb(display->drm_fd, &red);
+	igt_remove_fb(display->drm_fd, &blue);
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+	return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+	       igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+	int valid_tests = 0;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {

tests/kms_scaling_modes.c line 110

Quoted 10 lines
tests/kms_scaling_modes.c new file +10 -0
+		if (!has_scaling_mode(output))
+			continue;
+
+		igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe));
+		igt_display_reset(display);
+		test_scaling_mode_on_output(display, pipe, output, flags);
+		valid_tests++;
+	}
+
+	igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");

This check is not required. igt_subtest_with_dynamic() will throw a SKIP automatically if no igt_dynamic() is executed.

- Bhanu

Quoted 46 lines
tests/kms_scaling_modes.c new file +34 -0
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+		igt_require(data.drm_fd >= 0);
+
+		kmstest_set_vt_graphics_mode();
+
+		igt_display_require(&data.display, data.drm_fd);
+		igt_require(data.display.is_atomic);
+
+		igt_display_require_output(&data.display);
+	}
+
+	igt_describe("Tests full display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full")
+		test_scaling_mode(&data, DRM_MODE_SCALE_FULLSCREEN);
+	igt_describe("Tests center display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-center")
+		test_scaling_mode(&data, DRM_MODE_SCALE_CENTER);
+	igt_describe("Tests full aspect display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full-aspect")
+		test_scaling_mode(&data, DRM_MODE_SCALE_ASPECT);
+	igt_describe("Tests none display scaling mode (no scaling)");
+	igt_subtest_with_dynamic("scaling-mode-none")
+		test_scaling_mode(&data, DRM_MODE_SCALE_NONE);
+
+	igt_fixture
+		igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
  	'kms_properties',
  	'kms_rmfb',
  	'kms_rotation_crc',
+	'kms_scaling_modes',
  	'kms_selftest',
  	'kms_sequence',
  	'kms_setmode',
#4 lore raw
In reply to Swati Sharma
Quoted 113 lines · Swati Sharma

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are 4 types of scaling modes defined:
None:
No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
Full:
The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
Center:
No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
Full aspect:
The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

v2: -removed test flags/test_cycle_flags() (JP)
-removed redundant igt_display_commit_atomic() (JP) -corrected indentation (JP)

---
  tests/kms_scaling_modes.c | 144 ++++++++++++++++++++++++++++++++++++++
  tests/meson.build         |   1 +
  2 files changed, 145 insertions(+)

create mode 100644 tests/kms_scaling_modes.c

tests/kms_scaling_modes.c new file +73 -0
new file mode 100644
index 00000000..28b5801a
@@ -0,0 +1,144 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Author:
+ *     Swati Sharma <[email protected]>
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Common test data */
+typedef struct data {
+	igt_display_t display;
+	int drm_fd;
+} data_t;
+
+static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe pipe,
+					igt_output_t *output, uint32_t flags)
+{
+	igt_plane_t *primary, *sprite;
+	drmModeModeInfo mode;
+	struct igt_fb red, blue;
+	int ret;
+
+	igt_output_set_pipe(output, pipe);
+	mode = *igt_output_get_mode(output);
+
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    0.f, 0.f, 1.f, &blue);
+
+	igt_create_color_fb(display->drm_fd, 640, 480,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    1.f, 0.f, 0.f, &red);
+
+	igt_plane_set_fb(primary, &blue);
+	igt_plane_set_fb(sprite, &red);
+
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	mode.hdisplay = 640;
+	mode.vdisplay = 480;
+	igt_output_override_mode(output, &mode);
+
+	igt_plane_set_fb(sprite, NULL);
+	igt_plane_set_fb(primary, &red);
+

tests/kms_scaling_modes.c line 83

Quoted 10 lines
tests/kms_scaling_modes.c new file +10 -0
+	igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, flags);
+
+	/* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+	ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+	if (ret == -EINVAL)
+		igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n");
+
+	igt_remove_fb(display->drm_fd, &red);
+	igt_remove_fb(display->drm_fd, &blue);

Above "if" statement is now redundant. Also you could remove these framebuffers before deciding if skip or no.

Quoted 73 lines
tests/kms_scaling_modes.c new file +61 -0
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+	return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+	       igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+	int valid_tests = 0;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {
+		if (!has_scaling_mode(output))
+			continue;
+
+		igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe));
+		igt_display_reset(display);
+		test_scaling_mode_on_output(display, pipe, output, flags);
+		valid_tests++;
+	}
+
+	igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+		igt_require(data.drm_fd >= 0);
+
+		kmstest_set_vt_graphics_mode();
+
+		igt_display_require(&data.display, data.drm_fd);
+		igt_require(data.display.is_atomic);
+
+		igt_display_require_output(&data.display);
+	}
+
+	igt_describe("Tests full display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full")
+		test_scaling_mode(&data, DRM_MODE_SCALE_FULLSCREEN);
+	igt_describe("Tests center display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-center")
+		test_scaling_mode(&data, DRM_MODE_SCALE_CENTER);
+	igt_describe("Tests full aspect display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full-aspect")
+		test_scaling_mode(&data, DRM_MODE_SCALE_ASPECT);
+	igt_describe("Tests none display scaling mode (no scaling)");
+	igt_subtest_with_dynamic("scaling-mode-none")
+		test_scaling_mode(&data, DRM_MODE_SCALE_NONE);
+
+	igt_fixture
+		igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
  	'kms_properties',
  	'kms_rmfb',
  	'kms_rotation_crc',
+	'kms_scaling_modes',
  	'kms_selftest',
  	'kms_sequence',
  	'kms_setmode',
#5 lore raw

Addressed review comments.
Floated v3 https://patchwork.freedesktop.org/series/98463/#rev4

Quoted 215 lines · Juha-Pekka Heikkila
Quoted 126 lines · Swati Sharma

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are 4 types of scaling modes defined:
    None:
        No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
    Full:
        The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
    Center:
        No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
    Full aspect:
        The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

v2: -removed test flags/test_cycle_flags() (JP) -removed redundant igt_display_commit_atomic() (JP) -corrected indentation (JP)

---
  tests/kms_scaling_modes.c | 144 ++++++++++++++++++++++++++++++++++++++ tests/meson.build         |   1 +

  2 files changed, 145 insertions(+)

  create mode 100644 tests/kms_scaling_modes.c

tests/kms_scaling_modes.c new file +4 -0
new file mode 100644
index 00000000..28b5801a
@@ -0,0 +1,144 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person 

obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Author:
+ *     Swati Sharma <[email protected]>
+ */

tests/kms_scaling_modes.c new file +15 -0
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Common test data */
+typedef struct data {
+    igt_display_t display;
+    int drm_fd;
+} data_t;
+
+static void test_scaling_mode_on_output(igt_display_t *display, const 

enum pipe pipe,
+                    igt_output_t *output, uint32_t flags)

tests/kms_scaling_modes.c new file +33 -0
+{
+    igt_plane_t *primary, *sprite;
+    drmModeModeInfo mode;
+    struct igt_fb red, blue;
+    int ret;
+
+    igt_output_set_pipe(output, pipe);
+    mode = *igt_output_get_mode(output);
+
+    primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+    sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+    igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+                DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+                0.f, 0.f, 1.f, &blue);
+
+    igt_create_color_fb(display->drm_fd, 640, 480,
+                DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+                1.f, 0.f, 0.f, &red);
+
+    igt_plane_set_fb(primary, &blue);
+    igt_plane_set_fb(sprite, &red);
+
+    igt_display_commit2(display, COMMIT_ATOMIC);
+
+    mode.hdisplay = 640;
+    mode.vdisplay = 480;
+    igt_output_override_mode(output, &mode);
+
+    igt_plane_set_fb(sprite, NULL);
+    igt_plane_set_fb(primary, &red);
+
+    igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, 

flags);

tests/kms_scaling_modes.c line 83

Quoted 9 lines
tests/kms_scaling_modes.c new file +9 -0
+
+    /* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+    ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+    if (ret == -EINVAL)
+        igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n");
+
+    igt_remove_fb(display->drm_fd, &red);
+    igt_remove_fb(display->drm_fd, &blue);

Above "if" statement is now redundant. Also you could remove these framebuffers before deciding if skip or no.

Quoted 75 lines
tests/kms_scaling_modes.c new file +21 -0
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+    return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+           igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+    igt_display_t *display = &data->display;
+    igt_output_t *output;
+    enum pipe pipe;
+    int valid_tests = 0;
+
+    for_each_pipe_with_valid_output(display, pipe, output) {
+        if (!has_scaling_mode(output))
+            continue;
+
+        igt_dynamic_f("%s-pipe-%s", output->name, 

kmstest_pipe_name(pipe));
+        igt_display_reset(display);
+        test_scaling_mode_on_output(display, pipe, output, flags); +        valid_tests++;
+    }
+
+    igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");

tests/kms_scaling_modes.c new file +34 -0
+}
+
+igt_main
+{
+    data_t data = {};
+
+    igt_fixture {
+        data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+        igt_require(data.drm_fd >= 0);
+
+        kmstest_set_vt_graphics_mode();
+
+        igt_display_require(&data.display, data.drm_fd);
+        igt_require(data.display.is_atomic);
+
+        igt_display_require_output(&data.display);
+    }
+
+    igt_describe("Tests full display scaling mode");
+    igt_subtest_with_dynamic("scaling-mode-full")
+        test_scaling_mode(&data, DRM_MODE_SCALE_FULLSCREEN);
+    igt_describe("Tests center display scaling mode");
+    igt_subtest_with_dynamic("scaling-mode-center")
+        test_scaling_mode(&data, DRM_MODE_SCALE_CENTER);
+    igt_describe("Tests full aspect display scaling mode");
+    igt_subtest_with_dynamic("scaling-mode-full-aspect")
+        test_scaling_mode(&data, DRM_MODE_SCALE_ASPECT);
+    igt_describe("Tests none display scaling mode (no scaling)");
+    igt_subtest_with_dynamic("scaling-mode-none")
+        test_scaling_mode(&data, DRM_MODE_SCALE_NONE);
+
+    igt_fixture
+        igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
       'kms_properties',
       'kms_rmfb',
       'kms_rotation_crc',
+    'kms_scaling_modes',
       'kms_selftest',
       'kms_sequence',
       'kms_setmode',
Signature · 1 line
~Swati Sharma