Skip to contentSkip to conversation

Add QCOM TCSR driver

PATCH In review Ansuel Smith 3 participants 7 messages Jan 22, 2022 – Feb 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Add QCOM TCSR driver

This is another try of the long gone TCSR driver needed for ipq8064 and now also ipq4019. The first (and unique) proposal for this is back in the 2015. After that only part of this got merged, to be specific a variant of this got merged to support gsbi driver on ipq8064.

All the "configuration" part was never merged and without this ipq8064 SoC and ipq4019 SoC require custom patches to be configured correctly.

The driver itself is really simple. A syscon driver that configure the system based on the passed bindings. All this stuff can't be moved and handled by another driver (for example dwc3) as it's global and has to be set only one (we have 2 dwc3 port for example)

This is necessary for some devices (especially ipq4019 based) that require some special configuration for the internal WiFi chip memory configuration.
Ansuel Smith (2):
dt-bindings: soc: qcom: add qcom,tcsr bindings
drivers: soc: qcom: add TCSR driver

 .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml  |  93 ++++++++
 .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml  |  47 +++++
 drivers/soc/qcom/Kconfig                      |   8 +
 drivers/soc/qcom/Makefile                     |   1 +
 drivers/soc/qcom/qcom_tcsr.c                  | 198 ++++++++++++++++++
 5 files changed, 347 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml
 create mode 100644 drivers/soc/qcom/qcom_tcsr.c
Signature · 1 line
2.33.1
#1 lore raw

PATCH 1/2 dt-bindings: soc: qcom: add qcom,tcsr bindings

Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the tcsr present in ipq8064 and ipa4019 required to configure and set various peripherals present in the SoC.

---
 .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml  | 93 +++++++++++++++++++
 .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml  | 47 ++++++++++
 2 files changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +93 -0
new file mode 100644
index 000000000000..3a82ccbb6588
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ4019
+
+maintainers:
+  - Ansuel Smith <[email protected]>
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq4019.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq4019
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  qcom,usb-hsphy-mode-select:
+    description: Select usb hsphy mode for ipq4019
+    enum:
+      - 'host'
+      - 'device'
+
+  qcom,ess-interface-select:
+    description: Select ess interface mode for ipq4019
+    enum:
+      - 'psgmii'
+      - 'rgmii5'
+      - 'rmii0'
+      - 'rmii1'
+      - 'rmii0_rmii1'
+      - 'rgmii4'
+
+  qcom,wifi-glb-cfg-enable-axid:
+    description: Enable AXI master bus Axid translating
+                  to confirm all txn submitted by order for ipq4019
+    type: boolean
+
+  qcom,wifi-glb-cfg-socslv-mode:
+    description: Select wifi socslv mode for ipq4019
+                  snoc use SNOC socslv_wxi_bvalid.
+                  local use locally generate socslv_wxi_bvalid for performance.
+    enum:
+      - 'snoc'
+      - 'local'
+
+  qcom,wifi_noc_memtype_m0_m2:
+    description: Configure special wifi memory type needed for
+                  some IPQ40xx devicesfor ipq4019
+    type: boolean
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcsr@194b000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x194b000 0x100>;
+      qcom,usb-hsphy-mode-select = "host";
+    };
+
+    tcsr@1949000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1949000 0x100>;
+      qcom,wifi-glb-cfg-enable-axid;
+      qcom,wifi-glb-cfg-socslv-mode = "local";
+    };
+
+    ess_tcsr@1953000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1953000 0x1000>;
+      qcom,ess-interface-select = "psgmii";
+    };
+
+    tcsr@1957000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1957000 0x100>;
+      qcom,wifi_noc_memtype_m0_m2;
+    };
+
+...
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +47 -0

47 lines not on this page · raw message

Signature · 1 line
2.33.1
#2 lore raw

Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings

Quoted 35 lines · Ansuel Smith

Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the tcsr present in ipq8064 and ipa4019 required to configure and set various peripherals present in the SoC.

---
 .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml  | 93 +++++++++++++++++++
 .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml  | 47 ++++++++++
 2 files changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +17 -0
new file mode 100644
index 000000000000..3a82ccbb6588
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ4019
+
+maintainers:
+  - Ansuel Smith <[email protected]>
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq4019.
+
+properties:

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 27

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +10 -0
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq4019
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  qcom,usb-hsphy-mode-select:
+    description: Select usb hsphy mode for ipq4019

Why isn't this driven by the USB node, where I presume you otherwise need to duplicate this decision?

Is this platform not capable of OTG?

Quoted 32 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +32 -0
+    enum:
+      - 'host'
+      - 'device'
+
+  qcom,ess-interface-select:
+    description: Select ess interface mode for ipq4019
+    enum:
+      - 'psgmii'
+      - 'rgmii5'
+      - 'rmii0'
+      - 'rmii1'
+      - 'rmii0_rmii1'
+      - 'rgmii4'
+
+  qcom,wifi-glb-cfg-enable-axid:
+    description: Enable AXI master bus Axid translating
+                  to confirm all txn submitted by order for ipq4019
+    type: boolean
+
+  qcom,wifi-glb-cfg-socslv-mode:
+    description: Select wifi socslv mode for ipq4019
+                  snoc use SNOC socslv_wxi_bvalid.
+                  local use locally generate socslv_wxi_bvalid for performance.
+    enum:
+      - 'snoc'
+      - 'local'
+
+  qcom,wifi_noc_memtype_m0_m2:
+    description: Configure special wifi memory type needed for
+                  some IPQ40xx devicesfor ipq4019
+    type: boolean
+

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 69

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcsr@194b000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";

There's a single "tcsr" register block at 0x1937000 of size 0x21000. The binding should describe that entire block, not convenient pieces of it.

Quoted 51 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +24 -0
+      reg = <0x194b000 0x100>;
+      qcom,usb-hsphy-mode-select = "host";
+    };
+
+    tcsr@1949000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1949000 0x100>;
+      qcom,wifi-glb-cfg-enable-axid;
+      qcom,wifi-glb-cfg-socslv-mode = "local";
+    };
+
+    ess_tcsr@1953000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1953000 0x1000>;
+      qcom,ess-interface-select = "psgmii";
+    };
+
+    tcsr@1957000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1957000 0x100>;
+      qcom,wifi_noc_memtype_m0_m2;
+    };
+
+...
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +21 -0
new file mode 100644
index 000000000000..4ccc0bfccec5
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ8064
+
+maintainers:
+  - Ansuel Smith <[email protected]>
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq8064.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq8064
+      - const: syscon

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml line 31

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +10 -0
+
+  reg:
+    maxItems: 1
+
+  qcom,usb-ctrl-select:
+    description: Select usb3 ctrl type for ipq8064
+    enum:
+      - 'p0'
+      - 'p1'
+      - 'dual'

Again, it seems reasonable to get this form the dwc3 node, rather than duplicating the configuration.

Regards,
Bjorn

Quoted 19 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +16 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcsr: syscon@1a400000 {
+      compatible = "qcom,tcsr-ipq8064", "syscon";
+      reg = <0x1a400000 0x100>;
+      qcom,usb-ctrl-select = "dual";
+    };
+
+...
Signature · 1 line
2.33.1
#3 lore raw

Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings

Quoted 42 lines · Bjorn Andersson
Quoted 40 lines · Ansuel Smith

Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the tcsr present in ipq8064 and ipa4019 required to configure and set various peripherals present in the SoC.

---
 .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml  | 93 +++++++++++++++++++
 .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml  | 47 ++++++++++
 2 files changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +22 -0
new file mode 100644
index 000000000000..3a82ccbb6588
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ4019
+
+maintainers:
+  - Ansuel Smith <[email protected]>
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq4019.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq4019
+      - const: syscon
+
Quoted 9 lines

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 27

Quoted 5 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +5 -0
+  reg:
+    maxItems: 1
+
+  qcom,usb-hsphy-mode-select:
+    description: Select usb hsphy mode for ipq4019

Why isn't this driven by the USB node, where I presume you otherwise need to duplicate this decision?

From what I understand this is global, setting this will apply on any usb present.

Quoted 2 lines

Is this platform not capable of OTG?

I assume it's capable by selecting the correct mode using tcsr.

Quoted 38 lines
Quoted 38 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +38 -0
+    enum:
+      - 'host'
+      - 'device'
+
+  qcom,ess-interface-select:
+    description: Select ess interface mode for ipq4019
+    enum:
+      - 'psgmii'
+      - 'rgmii5'
+      - 'rmii0'
+      - 'rmii1'
+      - 'rmii0_rmii1'
+      - 'rgmii4'
+
+  qcom,wifi-glb-cfg-enable-axid:
+    description: Enable AXI master bus Axid translating
+                  to confirm all txn submitted by order for ipq4019
+    type: boolean
+
+  qcom,wifi-glb-cfg-socslv-mode:
+    description: Select wifi socslv mode for ipq4019
+                  snoc use SNOC socslv_wxi_bvalid.
+                  local use locally generate socslv_wxi_bvalid for performance.
+    enum:
+      - 'snoc'
+      - 'local'
+
+  qcom,wifi_noc_memtype_m0_m2:
+    description: Configure special wifi memory type needed for
+                  some IPQ40xx devicesfor ipq4019
+    type: boolean
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
Quoted 9 lines

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 69

Quoted 4 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +4 -0
+examples:
+  - |
+    tcsr@194b000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";

There's a single "tcsr" register block at 0x1937000 of size 0x21000. The binding should describe that entire block, not convenient pieces of it.

The current driver implementation works with the offset provided by the reg. I assume I can just hardcode the offset in the driver and declare a single tcsr node. Will do this change.

Quoted 56 lines
Quoted 56 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +24 -0
+      reg = <0x194b000 0x100>;
+      qcom,usb-hsphy-mode-select = "host";
+    };
+
+    tcsr@1949000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1949000 0x100>;
+      qcom,wifi-glb-cfg-enable-axid;
+      qcom,wifi-glb-cfg-socslv-mode = "local";
+    };
+
+    ess_tcsr@1953000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1953000 0x1000>;
+      qcom,ess-interface-select = "psgmii";
+    };
+
+    tcsr@1957000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1957000 0x100>;
+      qcom,wifi_noc_memtype_m0_m2;
+    };
+
+...
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +26 -0
new file mode 100644
index 000000000000..4ccc0bfccec5
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ8064
+
+maintainers:
+  - Ansuel Smith <[email protected]>
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq8064.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq8064
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  qcom,usb-ctrl-select:
Quoted 9 lines

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml line 31

Quoted 5 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +5 -0
+    description: Select usb3 ctrl type for ipq8064
+    enum:
+      - 'p0'
+      - 'p1'
+      - 'dual'

Again, it seems reasonable to get this form the dwc3 node, rather than duplicating the configuration.

As I said up, it seems to be global, that's the reason I didn't put this handling in the dwc-qcom driver. (I mean it seems wrong that dwc3 would set the same value twice). If this is necessary I will add support for this in dwc-qcom.

Quoted 22 lines

Regards,
Bjorn

Quoted 19 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +16 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcsr: syscon@1a400000 {
+      compatible = "qcom,tcsr-ipq8064", "syscon";
+      reg = <0x1a400000 0x100>;
+      qcom,usb-ctrl-select = "dual";
+    };
+
+...
Signature · 1 line
2.33.1
Signature · 1 line
	Ansuel
#4 lore raw

Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings

Quoted 53 lines · Ansuel Smith
Quoted 42 lines · Bjorn Andersson
Quoted 40 lines · Ansuel Smith

Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the tcsr present in ipq8064 and ipa4019 required to configure and set various peripherals present in the SoC.

---
 .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml  | 93 +++++++++++++++++++
 .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml  | 47 ++++++++++
 2 files changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +22 -0
new file mode 100644
index 000000000000..3a82ccbb6588
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ4019
+
+maintainers:
+  - Ansuel Smith <[email protected]>
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq4019.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq4019
+      - const: syscon
+
Quoted 9 lines

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 27

Quoted 5 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +5 -0
+  reg:
+    maxItems: 1
+
+  qcom,usb-hsphy-mode-select:
+    description: Select usb hsphy mode for ipq4019

Why isn't this driven by the USB node, where I presume you otherwise need to duplicate this decision?

Quoted 8 lines

From what I understand this is global, setting this will apply on any usb present.

Quoted 2 lines

Is this platform not capable of OTG?

I assume it's capable by selecting the correct mode using tcsr.

I expect that the USB controller will receive extcon (or usb_role_switch) requests to flip between the modes based on something.

When this happens it sounds like the USB controller would have to propagate that change to the TCSR bits as well, and if the USB controller driver is able to flip the bits then this shouldn't be needed here?

Regards,
Bjorn

maintainer
#5 lore raw

Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings

In reply to Ansuel Smith
Quoted 28 lines · Ansuel Smith

Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the tcsr present in ipq8064 and ipa4019 required to configure and set various peripherals present in the SoC.

---
 .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml  | 93 +++++++++++++++++++
 .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml  | 47 ++++++++++
 2 files changed, 140 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +10 -0
new file mode 100644
index 000000000000..3a82ccbb6588
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ4019
+
+maintainers:
+  - Ansuel Smith <[email protected]>

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 20

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +10 -0
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq4019.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq4019

Normal order is qcom,ipq4019-tcsr

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 30

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +10 -0
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  qcom,usb-hsphy-mode-select:
+    description: Select usb hsphy mode for ipq4019
+    enum:
+      - 'host'
+      - 'device'

Don't need quotes.

Quoted 4 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +4 -0
+
+  qcom,ess-interface-select:
+    description: Select ess interface mode for ipq4019
+    enum:

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 44

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +10 -0
+      - 'psgmii'
+      - 'rgmii5'
+      - 'rmii0'
+      - 'rmii1'
+      - 'rmii0_rmii1'
+      - 'rgmii4'
+
+  qcom,wifi-glb-cfg-enable-axid:
+    description: Enable AXI master bus Axid translating
+                  to confirm all txn submitted by order for ipq4019

Wrap at ~80 and indent 2 more spaces (than 'description').

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml line 55

Quoted 11 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +11 -0
+    type: boolean
+
+  qcom,wifi-glb-cfg-socslv-mode:
+    description: Select wifi socslv mode for ipq4019
+                  snoc use SNOC socslv_wxi_bvalid.
+                  local use locally generate socslv_wxi_bvalid for performance.
+    enum:
+      - 'snoc'
+      - 'local'
+
+  qcom,wifi_noc_memtype_m0_m2:

s/_/-/

Quoted 54 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file +38 -0
+    description: Configure special wifi memory type needed for
+                  some IPQ40xx devicesfor ipq4019
+    type: boolean
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcsr@194b000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x194b000 0x100>;
+      qcom,usb-hsphy-mode-select = "host";
+    };
+
+    tcsr@1949000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1949000 0x100>;
+      qcom,wifi-glb-cfg-enable-axid;
+      qcom,wifi-glb-cfg-socslv-mode = "local";
+    };
+
+    ess_tcsr@1953000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1953000 0x1000>;
+      qcom,ess-interface-select = "psgmii";
+    };
+
+    tcsr@1957000 {
+      compatible = "qcom,tcsr-ipq4019", "syscon";
+      reg = <0x1957000 0x100>;
+      qcom,wifi_noc_memtype_m0_m2;
+    };
+
+...
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +10 -0
new file mode 100644
index 000000000000..4ccc0bfccec5
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Top Control and Status Registers binding for IPQ8064
+
+maintainers:
+  - Ansuel Smith <[email protected]>

Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml line 20

Quoted 10 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +10 -0
+
+description: |
+  This binding describes the Qualcomm Top Control and Status Registers, used
+  for accessing configuration and mux settings for a variety of peripherals
+  for ipq8064.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,tcsr-ipq8064

qcom,ipq8064-tcsr

Quoted 31 lines
Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file +27 -0
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  qcom,usb-ctrl-select:
+    description: Select usb3 ctrl type for ipq8064
+    enum:
+      - 'p0'
+      - 'p1'
+      - 'dual'
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcsr: syscon@1a400000 {
+      compatible = "qcom,tcsr-ipq8064", "syscon";
+      reg = <0x1a400000 0x100>;
+      qcom,usb-ctrl-select = "dual";
+    };
+
+...
Signature · 1 line
2.33.1
#6 lore raw

PATCH 2/2 drivers: soc: qcom: add TCSR driver

In reply to Ansuel Smith

Add QCOM Top Control and Status Registers driver required to control and configure various peripherals for ipq8064 and ipq4019. This is required to configure usb3 mode, gsbi configuration for ipq8064 and various devices (WiFi, USB mode, WiFi memtype, ESS interface mode) for ipq4019.

---
 drivers/soc/qcom/Kconfig     |   8 ++
 drivers/soc/qcom/Makefile    |   1 +
 drivers/soc/qcom/qcom_tcsr.c | 198 +++++++++++++++++++++++++++++++++++
 3 files changed, 207 insertions(+)
 create mode 100644 drivers/soc/qcom/qcom_tcsr.c
drivers/soc/qcom/Kconfig +8 -0
index e718b8735444..20dd341ae369 100644
@@ -209,6 +209,14 @@ config QCOM_STATS
 	  various SoC level low power modes statistics and export to debugfs
 	  interface.
 
+config QCOM_TCSR
+	tristate "QCOM Top Control and Status Registers"
+	depends on ARCH_QCOM || COMPILE_TEST
+	select MFD_SYSCON
+	help
+	  Say y here to enable TCSR support. The TCSR provides control
+	  functions for various peripherals (USB, WiFi, ESS).
+
 config QCOM_WCNSS_CTRL
 	tristate "Qualcomm WCNSS control driver"
 	depends on ARCH_QCOM || COMPILE_TEST
drivers/soc/qcom/Makefile +1 -0
index 70d5de69fd7b..b17dd46ed1fa 100644
@@ -28,3 +28,4 @@ obj-$(CONFIG_QCOM_LLCC) += llcc-qcom.o
 obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o
 obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o
 obj-$(CONFIG_QCOM_KRYO_L2_ACCESSORS) +=	kryo-l2-accessors.o
+obj-$(CONFIG_QCOM_TCSR)	 += qcom_tcsr.o
drivers/soc/qcom/qcom_tcsr.c new file +198 -0

198 lines not on this page · raw message

Signature · 1 line
2.33.1