Skip to contentSkip to conversation

hw/ppc/vof: Add missing includes

PATCH In review Philippe Mathieu-Daudé via 2 participants 4 messages Jan 22, 2022 – Jan 31, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/ppc/vof: Add missing includes

vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), "exec/memory.h" for address_space_read/write(), "exec/address-spaces.h" for address_space_memory and more importantly "cpu.h" for target_ulong.

vof.c doesn't need "exec/ram_addr.h".

---
 hw/ppc/vof.c         | 1 -
 include/hw/ppc/vof.h | 5 +++++
 2 files changed, 5 insertions(+), 1 deletion(-)
hw/ppc/vof.c +0 -1
index 73adc44ec2..2b63a62875 100644
@@ -16,7 +16,6 @@
 #include "qemu/units.h"
 #include "qemu/log.h"
 #include "qapi/error.h"
-#include "exec/ram_addr.h"
 #include "exec/address-spaces.h"
 #include "hw/ppc/vof.h"
 #include "hw/ppc/fdt.h"
include/hw/ppc/vof.h +5 -0
index 97fdef758b..f8c0effcaf 100644
@@ -6,6 +6,11 @@
 #ifndef HW_VOF_H
 #define HW_VOF_H
 
+#include "qom/object.h"
+#include "exec/address-spaces.h"
+#include "exec/memory.h"
+#include "cpu.h"
+
 typedef struct Vof {
     uint64_t top_addr; /* copied from rma_size */
     GArray *claimed; /* array of SpaprOfClaimed */
Signature · 1 line
2.34.1
#1 lore raw

Cc'ing qemu-trivial@

Quoted 41 lines · Philippe Mathieu-Daudé

vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), "exec/memory.h" for address_space_read/write(), "exec/address-spaces.h" for address_space_memory and more importantly "cpu.h" for target_ulong.

vof.c doesn't need "exec/ram_addr.h".

---
  hw/ppc/vof.c         | 1 -
  include/hw/ppc/vof.h | 5 +++++
  2 files changed, 5 insertions(+), 1 deletion(-)
hw/ppc/vof.c +0 -1
index 73adc44ec2..2b63a62875 100644
@@ -16,7 +16,6 @@
  #include "qemu/units.h"
  #include "qemu/log.h"
  #include "qapi/error.h"
-#include "exec/ram_addr.h"
  #include "exec/address-spaces.h"
  #include "hw/ppc/vof.h"
  #include "hw/ppc/fdt.h"
include/hw/ppc/vof.h +5 -0
index 97fdef758b..f8c0effcaf 100644
@@ -6,6 +6,11 @@
  #ifndef HW_VOF_H
  #define HW_VOF_H
 
+#include "qom/object.h"
+#include "exec/address-spaces.h"
+#include "exec/memory.h"
+#include "cpu.h"
+
  typedef struct Vof {
      uint64_t top_addr; /* copied from rma_size */
      GArray *claimed; /* array of SpaprOfClaimed */
#2 lore raw
Quoted 2 lines · Philippe Mathieu-Daudé

Cc'ing qemu-trivial@

It is queued in ppc-7.0. I should send a PR today or tomorrow.

Thanks,

C.

Quoted 42 lines · Philippe Mathieu-Daudé
Quoted 40 lines

vof.h requires "qom/object.h" for DECLARE_CLASS_CHECKERS(), "exec/memory.h" for address_space_read/write(), "exec/address-spaces.h" for address_space_memory and more importantly "cpu.h" for target_ulong.

vof.c doesn't need "exec/ram_addr.h".

---
  hw/ppc/vof.c         | 1 -
  include/hw/ppc/vof.h | 5 +++++

  2 files changed, 5 insertions(+), 1 deletion(-)
hw/ppc/vof.c +0 -1
index 73adc44ec2..2b63a62875 100644
@@ -16,7 +16,6 @@
   #include "qemu/units.h"
   #include "qemu/log.h"
   #include "qapi/error.h"
-#include "exec/ram_addr.h"
   #include "exec/address-spaces.h"
   #include "hw/ppc/vof.h"
   #include "hw/ppc/fdt.h"
include/hw/ppc/vof.h +5 -0
index 97fdef758b..f8c0effcaf 100644
@@ -6,6 +6,11 @@
   #ifndef HW_VOF_H
   #define HW_VOF_H
+#include "qom/object.h"
+#include "exec/address-spaces.h"
+#include "exec/memory.h"
+#include "cpu.h"
+
   typedef struct Vof {

      uint64_t top_addr; /* copied from rma_size */ GArray *claimed; /* array of SpaprOfClaimed */

#3 lore raw
Quoted 5 lines · Cédric Le Goater
Quoted 2 lines · Philippe Mathieu-Daudé

Cc'ing qemu-trivial@

It is queued in ppc-7.0. I should send a PR today or tomorrow.

Thanks!