Skip to contentSkip to conversation

hw/remote: Add missing include

PATCH In review Philippe Mathieu-Daudé via 2 participants 2 messages Jan 22, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/remote: Add missing include

Currently "qemu/error-report.h" is implicitly included, however if headers in include/ get refactored, we get:

hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’:
hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of function ‘error_report’; did you mean ‘error_report_err’? [-Werror=implicit-function-declaration]

    183 |         error_report("Number of fds is more than %d", REMOTE_MAX_FDS);
        |         ^~~~~~~~~~~~
        |         error_report_err

Add the missing "qemu/error-report.h" header to avoid that.

---
 hw/remote/proxy-memory-listener.c | 1 +
 1 file changed, 1 insertion(+)
hw/remote/proxy-memory-listener.c +1 -0
index 882c9b4854..0e893f3189 100644
@@ -16,6 +16,7 @@
 #include "exec/cpu-common.h"
 #include "exec/ram_addr.h"
 #include "qapi/error.h"
+#include "qemu/error-report.h"
 #include "hw/remote/mpqemu-link.h"
 #include "hw/remote/proxy-memory-listener.h"
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Philippe Mathieu-Daudé

Currently "qemu/error-report.h" is implicitly included, however if headers in include/ get refactored, we get:

hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’:
hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of function ‘error_report’; did you mean ‘error_report_err’? [-Werror=implicit-function-declaration]

Quoted 7 lines
   183 |         error_report("Number of fds is more than %d", REMOTE_MAX_FDS);
       |         ^~~~~~~~~~~~
       |         error_report_err

Add the missing "qemu/error-report.h" header to avoid that.

Quoted 19 lines

---
hw/remote/proxy-memory-listener.c | 1 +

1 file changed, 1 insertion(+)
hw/remote/proxy-memory-listener.c +1 -0
index 882c9b4854..0e893f3189 100644
@@ -16,6 +16,7 @@
 #include "exec/cpu-common.h"
 #include "exec/ram_addr.h"
 #include "qapi/error.h"
+#include "qemu/error-report.h"
 #include "hw/remote/mpqemu-link.h"
 #include "hw/remote/proxy-memory-listener.h"
 
Signature · 1 line
2.34.1