Skip to contentSkip to conversation

package/efl: fix build failure with eeze disabled

PATCH In review Giulio Benetti 3 participants 4 messages Jan 24, 2022 – Feb 1, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/efl: fix build failure with eeze disabled

Elput depends on eeze, so if we disable eeze we also need to disable elput by setting the option "input" to false.

Fixes:
https://bugs.busybox.net/show_bug.cgi?id=14531

---
 package/efl/efl.mk | 2 ++
 1 file changed, 2 insertions(+)
package/efl/efl.mk +2 -0
index ed0a8acc1d..c93961475d 100644
@@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev
 EFL_CONF_OPTS += -Deeze=true
 else
 EFL_CONF_OPTS += -Deeze=false
+# input(elput) requires eeze, so disable it accordingly
+EFL_CONF_OPTS += -Dinput=false
 endif
 
 ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 5 lines · Giulio Benetti

Elput depends on eeze, so if we disable eeze we also need to disable elput by setting the option "input" to false.

Fixes:
https://bugs.busybox.net/show_bug.cgi?id=14531

There are two other patches that somehow deal with this issue [1][2] in
addition to this one [3].

Could someone choose between the and mark the rest as Superseded in patchwork?

Regards,
Arnout

[1] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
[2] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
[3] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 11 lines
---
  package/efl/efl.mk | 2 ++
  1 file changed, 2 insertions(+)
package/efl/efl.mk +0 -0
index ed0a8acc1d..c93961475d 100644

package/efl/efl.mk EFL_DEPENDENCIES += udev · line 72

Quoted 8 lines
package/efl/efl.mk +2 -0
@@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev
  EFL_CONF_OPTS += -Deeze=true
  else
  EFL_CONF_OPTS += -Deeze=false
+# input(elput) requires eeze, so disable it accordingly
+EFL_CONF_OPTS += -Dinput=false
  endif
 
  ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

Hi Arnout,

Quoted 10 lines

Il giorno 1 feb 2022, alle ore 22:53, Arnout Vandecappelle <[email protected]> ha scritto:



Quoted 5 lines · Giulio Benetti

Elput depends on eeze, so if we disable eeze we also need to disable elput by setting the option "input" to false.
Fixes:
https://bugs.busybox.net/show_bug.cgi?id=14531

Quoted 3 lines

There are two other patches that somehow deal with this issue [1][2] in addition to this one [3].

Could someone choose between the and mark the rest as Superseded in patchwork?

Fabrice commented on mine that mine was better.
Then the Romain one came out few days ago and I can tell his one is better.

So I would go for the Romain patch.

I set mine as superseded and Fabrice can do the before.

Best regards
Giulio

Quoted 22 lines

Regards,
Arnout

[1] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
[2] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
[3] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 12 lines
---
 package/efl/efl.mk | 2 ++
 1 file changed, 2 insertions(+)
package/efl/efl.mk +0 -0
index ed0a8acc1d..c93961475d 100644
@@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev
 EFL_CONF_OPTS += -Deeze=true
 else
 EFL_CONF_OPTS += -Deeze=false
Quoted 8 lines

package/efl/efl.mk EFL_DEPENDENCIES += udev · line 72

Quoted 4 lines
package/efl/efl.mk +2 -0
+# input(elput) requires eeze, so disable it accordingly
+EFL_CONF_OPTS += -Dinput=false
 endif
   ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Hi,

Quoted 15 lines · Giulio Benetti

Hi Arnout,

Quoted 12 lines

Il giorno 1 feb 2022, alle ore 22:53, Arnout Vandecappelle <[email protected]> ha scritto:



Quoted 5 lines · Giulio Benetti

Elput depends on eeze, so if we disable eeze we also need to disable elput by setting the option "input" to false.
Fixes:
https://bugs.busybox.net/show_bug.cgi?id=14531

There are two other patches that somehow deal with this issue [1][2] in addition to this one [3].

Quoted 8 lines
Quoted 1 line

Could someone choose between the and mark the rest as Superseded in patchwork?

Fabrice commented on mine that mine was better.
Then the Romain one came out few days ago and I can tell his one is better.

So I would go for the Romain patch.

I set mine as superseded and Fabrice can do the before.

I also set mine as superseded.

Quoted 35 lines

Best regards
Giulio

Quoted 30 lines

Regards,
Arnout

[1] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
[2] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
[3] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 9 lines
---
 package/efl/efl.mk | 2 ++
 1 file changed, 2 insertions(+)
package/efl/efl.mk +0 -0
index ed0a8acc1d..c93961475d 100644

package/efl/efl.mk EFL_DEPENDENCIES += udev · line 71

Quoted 7 lines
package/efl/efl.mk +2 -0
@@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev
 EFL_CONF_OPTS += -Deeze=true
 else
 EFL_CONF_OPTS += -Deeze=false
+# input(elput) requires eeze, so disable it accordingly
+EFL_CONF_OPTS += -Dinput=false
 endif
   ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot