Skip to contentSkip to conversation

raw/ifpga/base: fix port feature ID

PATCH Applied Wei Huang 4 participants 4 messages Jan 25, 2022 – Jan 26, 2022

lore
Share & tools
lore

Wei Huang

author
#0 lore raw

PATCH 1/1 raw/ifpga/base: fix port feature ID

Fix ID value of port features to match the definition from hardware.

Fixes 473c88f9 ("drivers/raw: remove rawdev from directory names")
---
 drivers/raw/ifpga/base/ifpga_defines.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/raw/ifpga/base/ifpga_defines.h +3 -3
index dca1518..8f62033 100644
@@ -93,9 +93,9 @@ enum fpga_id_type {
 
 #define PORT_FEATURE_ID_HEADER FEATURE_ID_FIU_HEADER
 #define PORT_FEATURE_ID_ERROR 0x10
-#define PORT_FEATURE_ID_UMSG 0x12
-#define PORT_FEATURE_ID_UINT 0x13
-#define PORT_FEATURE_ID_STP 0x14
+#define PORT_FEATURE_ID_UMSG 0x11
+#define PORT_FEATURE_ID_UINT 0x12
+#define PORT_FEATURE_ID_STP 0x13
 #define PORT_FEATURE_ID_UAFU FEATURE_ID_AFU
 
 /*
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Tuesday, January 25, 2022 10:31 AM
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v1] raw/ifpga/base: fix port feature ID

Fix ID value of port features to match the definition from hardware.

Fixes 473c88f9 ("drivers/raw: remove rawdev from directory names")
---
 drivers/raw/ifpga/base/ifpga_defines.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/raw/ifpga/base/ifpga_defines.h +0 -0
index dca1518..8f62033 100644
@@ -93,9 +93,9 @@ enum fpga_id_type {
 
 #define PORT_FEATURE_ID_HEADER FEATURE_ID_FIU_HEADER  #define

PORT_FEATURE_ID_ERROR 0x10 -#define PORT_FEATURE_ID_UMSG 0x12 - #define PORT_FEATURE_ID_UINT 0x13 -#define PORT_FEATURE_ID_STP 0x14

drivers/raw/ifpga/base/ifpga_defines.h enum fpga_id_type { · line 99

Quoted 4 lines
drivers/raw/ifpga/base/ifpga_defines.h +3 -0
+#define PORT_FEATURE_ID_UMSG 0x11
+#define PORT_FEATURE_ID_UINT 0x12
+#define PORT_FEATURE_ID_STP 0x13
 #define PORT_FEATURE_ID_UAFU FEATURE_ID_AFU
Acked-by on v1 1/1
#2 lore raw
In reply to Wei Huang

Hi,

Quoted 36 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Tuesday, January 25, 2022 10:31
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v1] raw/ifpga/base: fix port feature ID

Fix ID value of port features to match the definition from hardware.

Fixes 473c88f9 ("drivers/raw: remove rawdev from directory names")
---
 drivers/raw/ifpga/base/ifpga_defines.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/raw/ifpga/base/ifpga_defines.h +0 -0
index dca1518..8f62033 100644
@@ -93,9 +93,9 @@ enum fpga_id_type {
 
 #define PORT_FEATURE_ID_HEADER FEATURE_ID_FIU_HEADER  #define

PORT_FEATURE_ID_ERROR 0x10 -#define PORT_FEATURE_ID_UMSG 0x12 - #define PORT_FEATURE_ID_UINT 0x13 -#define PORT_FEATURE_ID_STP 0x14

drivers/raw/ifpga/base/ifpga_defines.h +3 -1
+#define PORT_FEATURE_ID_UMSG 0x11
+#define PORT_FEATURE_ID_UINT 0x12
+#define PORT_FEATURE_ID_STP 0x13
 #define PORT_FEATURE_ID_UAFU FEATURE_ID_AFU
 
 /*
--
Quoted 1 line

1.8.3.1

Acked-by Applied
#3 lore raw
Quoted 48 lines

-----Original Message-----
From: Xu, Rosen <[email protected]>
Sent: Wednesday, January 26, 2022 9:18 AM
To: Huang, Wei <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>
Subject: RE: [PATCH v1] raw/ifpga/base: fix port feature ID

Hi,

Quoted 26 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Tuesday, January 25, 2022 10:31
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v1] raw/ifpga/base: fix port feature ID

Fix ID value of port features to match the definition from hardware.

Fixes 473c88f9 ("drivers/raw: remove rawdev from directory names")
---
 drivers/raw/ifpga/base/ifpga_defines.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/raw/ifpga/base/ifpga_defines.h +0 -0
index dca1518..8f62033 100644
@@ -93,9 +93,9 @@ enum fpga_id_type {
 
 #define PORT_FEATURE_ID_HEADER FEATURE_ID_FIU_HEADER  #define
Quoted 1 line

PORT_FEATURE_ID_ERROR 0x10 -#define PORT_FEATURE_ID_UMSG 0x12

-

Quoted 7 lines

#define PORT_FEATURE_ID_UINT 0x13 -#define PORT_FEATURE_ID_STP 0x14

drivers/raw/ifpga/base/ifpga_defines.h +3 -0
+#define PORT_FEATURE_ID_UMSG 0x11
+#define PORT_FEATURE_ID_UINT 0x12
+#define PORT_FEATURE_ID_STP 0x13
 #define PORT_FEATURE_ID_UAFU FEATURE_ID_AFU
Quoted 5 lines
Quoted 3 lines

/*
--
1.8.3.1

Applied to dpdk-next-net-intel.

Thanks
Qi