Skip to contentSkip to conversation

riscv: mm: init: mark satp_mode __ro_after_init

PATCH In review Jisheng Zhang 2 participants 2 messages Jan 25, 2022 – Feb 14, 2022 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: mm: init: mark satp_mode __ro_after_init

satp_mode is never modified after init, so it can be marked as __ro_after_init.

---
 arch/riscv/mm/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/riscv/mm/init.c +2 -2
index 8347d0fda8cd..35586688a1b6 100644
@@ -38,9 +38,9 @@ EXPORT_SYMBOL(kernel_map);
 #endif
 
 #ifdef CONFIG_64BIT
-u64 satp_mode = !IS_ENABLED(CONFIG_XIP_KERNEL) ? SATP_MODE_48 : SATP_MODE_39;
+u64 satp_mode __ro_after_init = !IS_ENABLED(CONFIG_XIP_KERNEL) ? SATP_MODE_48 : SATP_MODE_39;
 #else
-u64 satp_mode = SATP_MODE_32;
+u64 satp_mode __ro_after_init = SATP_MODE_32;
 #endif
 EXPORT_SYMBOL(satp_mode);
 
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 13 lines · On Tue, 25 Jan 2022 08:00:12 PST (-0800), [email protected] wrote:

satp_mode is never modified after init, so it can be marked as __ro_after_init.

---
 arch/riscv/mm/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/riscv/mm/init.c +0 -0
index 8347d0fda8cd..35586688a1b6 100644

arch/riscv/mm/init.c EXPORT_SYMBOL(kernel_map); · line 45

Quoted 10 lines
arch/riscv/mm/init.c +2 -2
@@ -38,9 +38,9 @@ EXPORT_SYMBOL(kernel_map);
 #endif
 
 #ifdef CONFIG_64BIT
-u64 satp_mode = !IS_ENABLED(CONFIG_XIP_KERNEL) ? SATP_MODE_48 : SATP_MODE_39;
+u64 satp_mode __ro_after_init = !IS_ENABLED(CONFIG_XIP_KERNEL) ? SATP_MODE_48 : SATP_MODE_39;
 #else
-u64 satp_mode = SATP_MODE_32;
+u64 satp_mode __ro_after_init = SATP_MODE_32;
 #endif
 EXPORT_SYMBOL(satp_mode);

Thanks, this is on for-next.