Skip to contentSkip to conversation

vmap(): don't allow invalid pages

PATCH Superseded Yury Norov 2 participants 3 messages Jan 19, 2022 – Jan 26, 2022

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Yury Norov

author
#0 lore raw

PATCH v2 1/1 vmap(): don't allow invalid pages

vmap() takes struct page *pages as one of arguments, and user may provide an invalid pointer which would lead to data abort at address translation later.

Currently, kernel checks the pages against NULL. In my case, however, the address was not NULL, and was big enough so that the hardware generated Address Size Abort on arm64.

Interestingly, this abort happens even if copy_from_kernel_nofault() is used, which is quite inconvenient for debugging purposes.

This patch adds a pfn_valid() check into vmap() path, so that invalid mapping will not be created.

RFC: https://lkml.org/lkml/2022/1/18/815
v1:  https://lkml.org/lkml/2022/1/18/1026
v2:  Patch description changed.
---
 mm/vmalloc.c | 2 ++
 1 file changed, 2 insertions(+)
mm/vmalloc.c +2 -0
index d2a00ad4e1dd..a4134ee56b10 100644
@@ -477,6 +477,8 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr,
 			return -EBUSY;
 		if (WARN_ON(!page))
 			return -ENOMEM;
+		if (WARN_ON(!pfn_valid(page_to_pfn(page))))
+			return -EINVAL;
 		set_pte_at(&init_mm, addr, pte, mk_pte(page, prot));
 		(*nr)++;
 	} while (pte++, addr += PAGE_SIZE, addr != end);
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 3 lines · On Tue, 18 Jan 2022 17:21:09 -0800 Yury Norov <[email protected]> wrote:

vmap() takes struct page *pages as one of arguments, and user may provide an invalid pointer which would lead to data abort at address translation later.

Does "user" mean userspace code?

If so, please tell us much more about the means by which userspace can trigger this problem.

author
#2 lore raw
Quoted 11 lines · Andrew Morton
Quoted 3 lines · On Tue, 18 Jan 2022 17:21:09 -0800 Yury Norov <[email protected]> wrote:

vmap() takes struct page *pages as one of arguments, and user may provide an invalid pointer which would lead to data abort at address translation later.

Does "user" mean userspace code?

If so, please tell us much more about the means by which userspace can trigger this problem.

User means user of vmap() API. The discussion is here:

https://lore.kernel.org/linux-mm/[email protected]/

I'll send v3 soon with more details in the patch description.