Skip to contentSkip to conversation

package/xvisor: drop arm support

PATCH In review Fabrice Fontaine 3 participants 5 messages Jan 25, 2022 – Jan 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/xvisor: drop arm support

Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without virtualization has been dropped since
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
resulting in the following build failure since bump to version 0.3.1 in commit c4f8b8968770ecbf6444a5921c6472f126717626:

*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!

*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!

Fixes:
- http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
- http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2

---
 package/xvisor/Config.in | 6 +-----
 package/xvisor/xvisor.mk | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)
package/xvisor/Config.in +1 -5
index eb7475b86d..55c43e6959 100644
@@ -2,8 +2,7 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
 	bool
 	default y
 	depends on BR2_USE_MMU
-	depends on BR2_arm || BR2_aarch64 || BR2_x86_64
-	depends on !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV7M
+	depends on BR2_aarch64 || BR2_x86_64
 
 menuconfig BR2_PACKAGE_XVISOR
 	bool "xvisor"
@@ -32,9 +31,6 @@ endchoice
 
 config BR2_PACKAGE_XVISOR_DEFCONFIG
 	string "Defconfig name"
-	default "generic-v5" if BR2_ARM_CPU_ARMV5
-	default "generic-v6" if BR2_ARM_CPU_ARMV6
-	default "generic-v7" if BR2_ARM_CPU_ARMV7A
 	default "generic-v8" if BR2_aarch64
 	default "x86_64_generic" if BR2_x86_64
 	depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
package/xvisor/xvisor.mk +1 -1
index dc49258400..4ceb5ed7cb 100644
@@ -30,7 +30,7 @@ XVISOR_KCONFIG_EDITORS = menuconfig
 
 ifeq ($(BR2_x86_64),y)
 XVISOR_ARCH = x86
-else ifeq ($(BR2_arm)$(BR2_aarch64),y)
+else ifeq ($(BR2_aarch64),y)
 XVISOR_ARCH = arm
 endif
 
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/xvisor: add riscv support

riscv is supported since version 0.3.0 and
https://github.com/xvisor/xvisor/commit/d6feda4e80eefd372294b081111ce709d08ee4c0

---
 package/xvisor/Config.in | 4 +++-
 package/xvisor/xvisor.mk | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
package/xvisor/Config.in +3 -1
index 55c43e6959..4e7a3e1b53 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
 	bool
 	default y
 	depends on BR2_USE_MMU
-	depends on BR2_aarch64 || BR2_x86_64
+	depends on BR2_aarch64 || BR2_riscv || BR2_x86_64
 
 menuconfig BR2_PACKAGE_XVISOR
 	bool "xvisor"
@@ -32,6 +32,8 @@ endchoice
 config BR2_PACKAGE_XVISOR_DEFCONFIG
 	string "Defconfig name"
 	default "generic-v8" if BR2_aarch64
+	default "generic-32b" if BR2_RISCV_32
+	default "generic-64b" if BR2_RISCV_64
 	default "x86_64_generic" if BR2_x86_64
 	depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
 	help
package/xvisor/xvisor.mk +2 -0
index 4ceb5ed7cb..1a7b49e689 100644
@@ -32,6 +32,8 @@ ifeq ($(BR2_x86_64),y)
 XVISOR_ARCH = x86
 else ifeq ($(BR2_aarch64),y)
 XVISOR_ARCH = arm
+else ifeq ($(BR2_riscv),y)
+XVISOR_ARCH = riscv
 endif
 
 ifeq ($(BR2_PACKAGE_XVISOR)$(BR_BUILDING),yy)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 2/2
#2 lore raw

Re: [Buildroot] [PATCH 2/2] package/xvisor: add riscv support

Quoted 5 lines · Fabrice Fontaine

riscv is supported since version 0.3.0 and
https://github.com/xvisor/xvisor/commit/d6feda4e80eefd372294b081111ce709d08ee4c0

Alistair

Quoted 43 lines
---
 package/xvisor/Config.in | 4 +++-
 package/xvisor/xvisor.mk | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
package/xvisor/Config.in +3 -1
index 55c43e6959..4e7a3e1b53 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
        bool
        default y
        depends on BR2_USE_MMU
-       depends on BR2_aarch64 || BR2_x86_64
+       depends on BR2_aarch64 || BR2_riscv || BR2_x86_64
 
 menuconfig BR2_PACKAGE_XVISOR
        bool "xvisor"
@@ -32,6 +32,8 @@ endchoice
 config BR2_PACKAGE_XVISOR_DEFCONFIG
        string "Defconfig name"
        default "generic-v8" if BR2_aarch64
+       default "generic-32b" if BR2_RISCV_32
+       default "generic-64b" if BR2_RISCV_64
        default "x86_64_generic" if BR2_x86_64
        depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
        help
package/xvisor/xvisor.mk +2 -1
index 4ceb5ed7cb..1a7b49e689 100644
@@ -32,6 +32,8 @@ ifeq ($(BR2_x86_64),y)
 XVISOR_ARCH = x86
 else ifeq ($(BR2_aarch64),y)
 XVISOR_ARCH = arm
+else ifeq ($(BR2_riscv),y)
+XVISOR_ARCH = riscv
 endif
 
 ifeq ($(BR2_PACKAGE_XVISOR)$(BR_BUILDING),yy)
--

2.34.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Fabrice Fontaine
Quoted 14 lines · On Tue, 25 Jan 2022 20:06:49 +0100 Fabrice Fontaine…

Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without virtualization has been dropped since
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
resulting in the following build failure since bump to version 0.3.1 in commit c4f8b8968770ecbf6444a5921c6472f126717626:

*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!

*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!

Fixes:
- http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
- http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2

Quoted 5 lines
---
 package/xvisor/Config.in | 6 +-----
 package/xvisor/xvisor.mk | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

I think this is based on a misunderstanding of the
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
commit. This commit says that they remove support for "ARM32 without virtualization support", but there are ARM32 cores with virtualization support! As explained in the commit log, the ARM32 cores that support the ARMv7ve instruction set are still supported by Xvisor.

This means that Cortex-A7, Cortex-A12, Cortex-A15 and Cortex-A17, which are all ARM32 cores, are still supported by Xvisor. So this patch entirely dropping ARM32 from Xvisor isn't entirely correct.

So, the change should be more like this:

config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS

	bool
	depends on BR2_USE_MMU
	default y if BR2_aarch64
	default y if BR2_x86_64
	default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17

config BR2_PACKAGE_XVISOR_DEFCONFIG
string "Defconfig name"
- default "generic-v5" if BR2_ARM_CPU_ARMV5
- default "generic-v6" if BR2_ARM_CPU_ARMV6
- default "generic-v7" if BR2_ARM_CPU_ARMV7A
+ default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A
default "generic-v8" if BR2_aarch64
default "x86_64_generic" if BR2_x86_64

What do you think ?

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw
Quoted 53 lines · Thomas Petazzoni
Quoted 14 lines · On Tue, 25 Jan 2022 20:06:49 +0100 Fabrice Fontaine…

Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without virtualization has been dropped since
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
resulting in the following build failure since bump to version 0.3.1 in commit c4f8b8968770ecbf6444a5921c6472f126717626:

*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"!

*** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"!

Fixes:
- http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b
- http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2

Quoted 5 lines
---
 package/xvisor/Config.in | 6 +-----
 package/xvisor/xvisor.mk | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

I think this is based on a misunderstanding of the
https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5
commit. This commit says that they remove support for "ARM32 without virtualization support", but there are ARM32 cores with virtualization support! As explained in the commit log, the ARM32 cores that support the ARMv7ve instruction set are still supported by Xvisor.

This means that Cortex-A7, Cortex-A12, Cortex-A15 and Cortex-A17, which are all ARM32 cores, are still supported by Xvisor. So this patch entirely dropping ARM32 from Xvisor isn't entirely correct.

So, the change should be more like this:

config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS
bool
depends on BR2_USE_MMU
default y if BR2_aarch64
default y if BR2_x86_64
default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17

config BR2_PACKAGE_XVISOR_DEFCONFIG
string "Defconfig name"

package/xvisor/Config.in +1 -3
-       default "generic-v5" if BR2_ARM_CPU_ARMV5
-       default "generic-v6" if BR2_ARM_CPU_ARMV6
-       default "generic-v7" if BR2_ARM_CPU_ARMV7A
+       default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A
        default "generic-v8" if BR2_aarch64
        default "x86_64_generic" if BR2_x86_64
Quoted 1 line

What do you think ?

You have more knowledge than me on ARM32. I'll send a v2 of the serie.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot