nfp: flower: Use struct_size() helper in kmalloc()
Subsystems (3)
PATCH 1/1 nfp: flower: Use struct_size() helper in kmalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:359:25: warning: using sizeof on a flexible structure
--- drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c +1 -1
@@ -356,7 +356,7 @@ __nfp_tun_add_route_to_cache(struct list_head *route_list,return 0 ; } - entry =kmalloc (sizeof (*entry) + add_len,GFP_ATOMIC ); + entry =kmalloc (struct_size (entry, ip_add, add_len),GFP_ATOMIC );if (!entry) {spin_unlock_bh (list_lock);return -ENOMEM ;
Signature · 1 line
2.27.0
Quoted 9 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.Also, address the following sparse warnings:
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:359:25: warning: using sizeof on a flexible structure
Quoted 20 lines
--- drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c +1
-1@@ -356,7 +356,7 @@ __nfp_tun_add_route_to_cache(struct list_head *route_list,return 0 ; } - entry =kmalloc (sizeof (*entry) + add_len,GFP_ATOMIC ); + entry =kmalloc (struct_size (entry, ip_add, add_len),GFP_ATOMIC );if (!entry) {spin_unlock_bh (list_lock);return -ENOMEM ;Signature · 1 line
2.27.0