arch/x86/mm/mem_encrypt.c:69:13: warning: no previous prototype for function 'mem_encrypt_init'
kernel test robot
build bottree: https://github.com/intel/tdx.git guest-upstream head: 5891b2d3ab5941ec7f5fefaa09fdd84a46ec82f5 commit: 0484e85cb3942b81e2b07162a363bda055c762a0 [24/33] x86/mm/cpa: Add support for TDX shared memory config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20220126/202201261113.3P3URW2n-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 997e128e2a78f5a5434fc75997441ae1ee76f8a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel/tdx/commit/0484e85cb3942b81e2b07162a363bda055c762a0
git remote add intel-tdx https://github.com/intel/tdx.git
git fetch --no-tags intel-tdx guest-upstream
git checkout 0484e85cb3942b81e2b07162a363bda055c762a0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/mm/
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> arch/x86/mm/mem_encrypt.c:69:13: warning: no previous prototype for function 'mem_encrypt_init' [-Wmissing-prototypes]
void __init mem_encrypt_init(void)
^ arch/x86/mm/mem_encrypt.c:69:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __init mem_encrypt_init(void)
^
static
1 warning generated.
vim +/mem_encrypt_init +69 arch/x86/mm/mem_encrypt.c
20f07a044a76ae Kirill A. Shutemov 2021-12-06 67
20f07a044a76ae Kirill A. Shutemov 2021-12-06 68 /* Architecture __weak replacement functions */
20f07a044a76ae Kirill A. Shutemov 2021-12-06 @69 void __init mem_encrypt_init(void)
20f07a044a76ae Kirill A. Shutemov 2021-12-06 70 {
20f07a044a76ae Kirill A. Shutemov 2021-12-06 71 if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
20f07a044a76ae Kirill A. Shutemov 2021-12-06 72 return;
20f07a044a76ae Kirill A. Shutemov 2021-12-06 73
20f07a044a76ae Kirill A. Shutemov 2021-12-06 74 /* Call into SWIOTLB to update the SWIOTLB DMA buffers */
20f07a044a76ae Kirill A. Shutemov 2021-12-06 75 swiotlb_update_mem_attributes();
20f07a044a76ae Kirill A. Shutemov 2021-12-06 76
20f07a044a76ae Kirill A. Shutemov 2021-12-06 77 print_mem_encrypt_feature_info();
20f07a044a76ae Kirill A. Shutemov 2021-12-06 78 }
20f07a044a76ae Kirill A. Shutemov 2021-12-06 79 :::::: The code at line 69 was first introduced by commit
:::::: 20f07a044a76aebaaa0603038857229b5c460d69 x86/sev: Move common memory encryption code to mem_encrypt.c
:::::: TO: Kirill A. Shutemov <[email protected]> :::::: CC: Borislav Petkov <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH 1/1 x86/mm: Fix warning on build with X86_MEM_ENCRYPT=y
So far, AMD_MEM_ENCRYPT is the only user of X86_MEM_ENCRYPT. TDX will be the second. It will make mem_encrypt.c build without AMD_MEM_ENCRYPT, which triggers a warning:
arch/x86/mm/mem_encrypt.c:69:13: warning: no previous prototype for
function 'mem_encrypt_init' [-Wmissing-prototypes]
Fix it by moving mem_encrypt_init() declaration outside of #ifdef CONFIG_AMD_MEM_ENCRYPT.
--- arch/x86/include/asm/mem_encrypt.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/include/asm/mem_encrypt.h +3 -3
@@ -49,9 +49,6 @@ void __init early_set_mem_enc_dec_hypercall(unsigned long vaddr, int npages,void __init mem_encrypt_free_decrypted_mem (void ); -/* Architecture __weak replacement functions */ -void __init mem_encrypt_init (void ); -void __init sev_es_init_vc_handling (void );#define __bss_decrypted __section(".bss..decrypted")
@@ -89,6 +86,9 @@ static inline void mem_encrypt_free_decrypted_mem(void) { }#endif /* CONFIG_AMD_MEM_ENCRYPT */ +/* Architecture __weak replacement functions */ +void __init mem_encrypt_init (void ); +/* * The __sme_pa() and __sme_pa_nodebug() macros are meant for use when * writing to or comparing values from the cr3 register. Having the
Signature · 1 line
2.34.1
Re: [PATCH] x86/mm: Fix warning on build with X86_MEM_ENCRYPT=y
Quoted 4 lines · Kirill A. Shutemov
So far,
AMD_MEM_ENCRYPTis the only user ofX86_MEM_ENCRYPT. TDX will be the second. It will makemem_encrypt.cbuild withoutAMD_MEM_ENCRYPT, which triggers a warning:
Quoted 8 lines
arch/x86/mm/mem_encrypt.c:69:13: warning: no previous prototype for
function 'mem_encrypt_init' [-Wmissing-prototypes]Fix it by moving
mem_encrypt_init()declaration outside of #ifdefCONFIG_AMD_MEM_ENCRYPT.Signed-off-by Kirill A. Shutemov <[email protected]>Fixes 20f07a044a76 ("x86/sev: Move common memory encryption code to mem_encrypt.c")