HID: logitech-dj: add new lightspeed receiver id
Subsystems (2)
PATCH 1/1 HID: logitech-dj: add new lightspeed receiver id
As of logitech lightspeed receiver fw version 04.02.B0009, HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
With patch "HID: logitech-dj: add support for the new lightspeed receiver iteration", the mouse starts to error out with:
logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on slot 1
and becomes unusable.
This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
--- drivers/hid/hid-logitech-dj.c | 1 + 1 file changed, 1 insertion(+)
drivers/hid/hid-logitech-dj.c +1 -0
@@ -1068,6 +1068,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev, workitem.reports_supported |=STD_KEYBOARD ;break ;case 0x0f : +case 0x11 : device_type ="eQUAD Lightspeed 1.2" ;logi_hidpp_dev_conn_notif_equad (hdev, hidpp_report, &workitem); workitem.reports_supported |=STD_KEYBOARD ;
Signature · 1 line
2.34.1
Quoted 11 lines · Lucas Zampieri
As of logitech lightspeed receiver fw version 04.02.B0009,
HIDPP_PARAM_DEVICE_INFOis being reported as0x11.With patch "HID: logitech-dj: add support for the new lightspeed receiver iteration", the mouse starts to error out with:
logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on slot 1
and becomes unusable.This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
The patch looks good to me.
Ideally, Nestor, can you confirm this is expected and that we won't have any bad surprises there?
I think we probably want this to be Cc-ed to stable once it gets merged (we can add the tag as we merge it).
Cheers,
Benjamin
Quoted 21 lines
Signed-off-by Lucas Zampieri <[email protected]>--- drivers/hid/hid-logitech-dj.c | 1 + 1 file changed, 1 insertion(+)drivers/hid/hid-logitech-dj.c +1
-1@@ -1068,6 +1068,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev, workitem.reports_supported |=STD_KEYBOARD ;break ;case 0x0f : +case 0x11 : device_type ="eQUAD Lightspeed 1.2" ;logi_hidpp_dev_conn_notif_equad (hdev, hidpp_report, &workitem); workitem.reports_supported |=STD_KEYBOARD ; --2.34.1
Filipe Laíns
reviewerQuoted 17 lines · Benjamin Tissoires
Quoted 11 lines · Lucas Zampieri
As of logitech lightspeed receiver fw version 04.02.B0009,
HIDPP_PARAM_DEVICE_INFOis being reported as0x11.With patch "HID: logitech-dj: add support for the new lightspeed receiver iteration", the mouse starts to error out with:
logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on slot 1
and becomes unusable.This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
The patch looks good to me.
Reviewed-by Benjamin Tissoires <[email protected]>
Quoted 8 lines
Ideally, Nestor, can you confirm this is expected and that we won't have any bad surprises there?
I think we probably want this to be Cc-ed to stable once it gets merged (we can add the tag as we merge it).
Cheers,
Benjamin
This is likely a different connection type, so it should probably get its own case statement, but let's let Nestor confirm :)
Cheers,
Filipe Laíns
Quoted 13 lines · Filipe Laíns
Quoted 11 lines · Benjamin Tissoires
Quoted 10 lines · Lucas Zampieri
As of logitech lightspeed receiver fw version 04.02.B0009,
HIDPP_PARAM_DEVICE_INFOis being reported as0x11.With patch "HID: logitech-dj: add support for the new lightspeed receiver iteration", the mouse starts to error out with:
logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on slot 1
and becomes unusable.
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
The patch looks good to me.
Reviewed-by Benjamin Tissoires <[email protected]>Ideally, Nestor, can you confirm this is expected and that we won't have any bad surprises there?
Yes, I confirm this matches our specifications, this is an iteration of Lightspeed 1.2
No objections on my side.
Quoted 4 lines
Quoted 4 lines
I think we probably want this to be Cc-ed to stable once it gets merged (we can add the tag as we merge it).
Quoted 8 lines
Quoted 2 lines
Cheers,
BenjaminThis is likely a different connection type, so it should probably get its own case statement, but let's let Nestor confirm :)
Cheers,
Filipe Laíns
best,
-nestor
Quoted 13 lines · Nestor Lopez Casado
Quoted 13 lines
Quoted 13 lines
Quoted 10 lines
As of logitech lightspeed receiver fw version 04.02.B0009,
HIDPP_PARAM_DEVICE_INFOis being reported as0x11.With patch "HID: logitech-dj: add support for the new lightspeed receiver iteration", the mouse starts to error out with:
logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on slot 1
and becomes unusable.This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
The patch looks good to me.
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Reviewed-by Benjamin Tissoires <[email protected]>Ideally, Nestor, can you confirm this is expected and that we won't have any bad surprises there?
Yes, I confirm this matches our specifications, this is an iteration of Lightspeed 1.2
No objections on my side.
Thanks. Based on this, I've applied this with
then. Please shout out loudly if you're not ok with that :)
Signature · 2 lines
Jiri Kosina SUSE Labs