Skip to contentSkip to conversation

lpfc: Remove redundant 'flush_workqueue()' calls

PATCH Applied [email protected] 2 participants 2 messages Jan 27, 2022 – Feb 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lpfc: Remove redundant 'flush_workqueue()' calls

From: "Minghao Chi (CGEL ZTE)" <[email protected]>

'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

---
 drivers/scsi/lpfc/lpfc_init.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +0 -1
index a56f01f659f8..f49ff18cb252 100644
@@ -8546,7 +8546,6 @@ static void
 lpfc_unset_driver_resource_phase2(struct lpfc_hba *phba)
 {
 	if (phba->wq) {
-		flush_workqueue(phba->wq);
 		destroy_workqueue(phba->wq);
 		phba->wq = NULL;
 	}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · On Thu, 27 Jan 2022 01:43:30 +0000, [email protected] wrote:

From: "Minghao Chi (CGEL ZTE)" <[email protected]>

'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

[...]

Applied to 5.18/scsi-queue, thanks!

[1/1] lpfc: Remove redundant 'flush_workqueue()' calls

      https://git.kernel.org/mkp/scsi/c/d1d87c33f47d
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering