Skip to contentSkip to conversation

include: configs: move USB first in the boot order for rk3399

PATCH In review Dan Johansen 2 participants 3 messages Jan 27, 2022 – Mar 14, 2022 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include: configs: move USB first in the boot order for rk3399

In Manjaro ARM we have used this patch for years now and it was requested that we upstream it.

This will make all rk3399 based boards try USB boot before SD or eMMC. Can be quite handy on some devices, where the other devices are not easy to get to.

---
 include/configs/rockchip-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/rockchip-common.h +1 -1
index ba7061a287..5dc92373b2 100644
@@ -55,9 +55,9 @@
 
 #ifdef CONFIG_ROCKCHIP_RK3399
 #define BOOT_TARGET_DEVICES(func) \
+	BOOT_TARGET_USB(func) \
 	BOOT_TARGET_MMC(func) \
 	BOOT_TARGET_NVME(func) \
-	BOOT_TARGET_USB(func) \
 	BOOT_TARGET_PXE(func) \
 	BOOT_TARGET_DHCP(func) \
 	BOOT_TARGET_SF(func)
Signature · 1 line
2.34.1
#1 lore raw

Hi Dan,
Thanks for your patch.
Most of the board would like to boot from SD->MMC->NVME, only if
there no firmware found in the onboard storage, them the U-Boot try with USB or network.
So I'm afraid this patch can not be applied.

Thanks,
- Kever

Quoted 31 lines · Dan Johansen <[email protected]> 于2022年1月28日周五 05:56写道:

In Manjaro ARM we have used this patch for years now and it was requested that we upstream it.

This will make all rk3399 based boards try USB boot before SD or eMMC. Can be quite handy on some devices, where the other devices are not easy to get to.

---
 include/configs/rockchip-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/rockchip-common.h +1 -2
index ba7061a287..5dc92373b2 100644
@@ -55,9 +55,9 @@
 
 #ifdef CONFIG_ROCKCHIP_RK3399
 #define BOOT_TARGET_DEVICES(func) \
+       BOOT_TARGET_USB(func) \
        BOOT_TARGET_MMC(func) \
        BOOT_TARGET_NVME(func) \
-       BOOT_TARGET_USB(func) \
        BOOT_TARGET_PXE(func) \
        BOOT_TARGET_DHCP(func) \
        BOOT_TARGET_SF(func)
--

2.34.1

#2 lore raw

Okay, no problem.

I was just asked to upstream it, so that was my attempt.

Have a good day.

Den 14.03.2022 kl. 08.57 skrev Kever Yang:

Quoted 41 lines

Hi Dan,
Thanks for your patch.
Most of the board would like to boot from SD->MMC->NVME, only if
there no firmware found in the onboard storage, them the U-Boot try with USB or network.
So I'm afraid this patch can not be applied.

Thanks,
- Kever

Quoted 30 lines · Dan Johansen<[email protected]> 于2022年1月28日周五 05:56写道:

In Manjaro ARM we have used this patch for years now and it was requested that we upstream it.

This will make all rk3399 based boards try USB boot before SD or eMMC. Can be quite handy on some devices, where the other devices are not easy to get to.

---
  include/configs/rockchip-common.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/rockchip-common.h +1 -2
index ba7061a287..5dc92373b2 100644
@@ -55,9 +55,9 @@
 
  #ifdef CONFIG_ROCKCHIP_RK3399
  #define BOOT_TARGET_DEVICES(func) \
+       BOOT_TARGET_USB(func) \
         BOOT_TARGET_MMC(func) \
         BOOT_TARGET_NVME(func) \
-       BOOT_TARGET_USB(func) \
         BOOT_TARGET_PXE(func) \
         BOOT_TARGET_DHCP(func) \
         BOOT_TARGET_SF(func)
--

2.34.1

Signature · 4 lines
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>