Skip to contentSkip to conversation

ARM: dts: aspeed: remove unhandled fttmr010,pwm-outputs

PATCH In review Corentin Labbe 2 participants 2 messages Jan 27, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: remove unhandled fttmr010,pwm-outputs

fttmr010,pwm-outputs is not handled by its timer driver, so this property is useless.

Fixes 67ac01d03862 ("ARM: dts: aspeed: add device tree for YADRO VEGMAN BMC")
---
 arch/arm/boot/dts/aspeed-bmc-vegman.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-vegman.dtsi +0 -1
index 1a5b25b2ea29..43af63910571 100644
@@ -166,7 +166,6 @@ &sdhci1 {
 };
 
 &timer {
-	fttmr010,pwm-outputs = <5>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_timer5_default>;
 	#pwm-cells = <3>;
Signature · 1 line
2.34.1
#1 lore raw

Hello,

Good catch! I miss this on porting DTS from local tree, based on Intel's one. Since there is no such driver in upstream kernel
(https://github.com/Intel-BMC/linux/blob/dev-5.15-intel/drivers/pwm/pwm-fttmr010.c
), both this and beeper sections could be completely removed.

I will send another patch with cleanup.

Thank you.

Quoted 23 lines · Corentin Labbe

fttmr010,pwm-outputs is not handled by its timer driver, so this property is useless.

Fixes 67ac01d03862 ("ARM: dts: aspeed: add device tree for YADRO

VEGMAN BMC")

---
?arch/arm/boot/dts/aspeed-bmc-vegman.dtsi | 1 -
?1 file changed, 1 deletion(-)

arch/arm/boot/dts/aspeed-bmc-vegman.dtsi +0 -0
index 1a5b25b2ea29..43af63910571 100644
@@ -166,7 +166,6 @@ &sdhci1 {
 ?};

?
?&timer {
-???????fttmr010,pwm-outputs = <5>;
????????pinctrl-names = "default";
????????pinctrl-0 = <&pinctrl_timer5_default>;
????????#pwm-cells = <3>;

Signature · 2 lines
Best regards,
Andrei Kartashev