drm/vc4: hdmi: Allow DBLCLK modes even if horz timing is odd.
Subsystems (3)
PATCH 1/1 drm/vc4: hdmi: Allow DBLCLK modes even if horz timing is odd.
From: Dave Stevenson <[email protected]>
The 2711 pixel valve can't produce odd horizontal timings, and checks were added to vc4_hdmi_encoder_atomic_check and vc4_hdmi_encoder_mode_valid to filter out/block selection of such modes.
Modes with DRM_MODE_FLAG_DBLCLK double all the horizontal timing values before programming them into the PV. The PV values, therefore, can not be odd, and so the modes can be supported.
Amend the filtering appropriately.
--- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/vc4/vc4_hdmi.c +2 -0
@@ -1269,6 +1269,7 @@ static int vc4_hdmi_encoder_atomic_check(struct drm_encoder *encoder,unsigned long long tmds_rate;if (vc4_hdmi->variant->unsupported_odd_h_timings && + !(mode->flags &DRM_MODE_FLAG_DBLCLK ) && ((mode->hdisplay %2 ) || (mode->hsync_start %2 ) || (mode->hsync_end %2 ) || (mode->htotal %2 )))return -EINVAL ;
@@ -1316,6 +1317,7 @@ vc4_hdmi_encoder_mode_valid(struct drm_encoder *encoder,struct vc4_hdmi *vc4_hdmi =encoder_to_vc4_hdmi (encoder);if (vc4_hdmi->variant->unsupported_odd_h_timings && + !(mode->flags &DRM_MODE_FLAG_DBLCLK ) && ((mode->hdisplay %2 ) || (mode->hsync_start %2 ) || (mode->hsync_end %2 ) || (mode->htotal %2 )))return MODE_H_ILLEGAL ;
Signature · 1 line
2.34.1
Maxime Ripard
AppliedRe: (subset) [PATCH] drm/vc4: hdmi: Allow DBLCLK modes even if horz timing is odd.
Quoted 8 lines · Maxime Ripard
From: Dave Stevenson <[email protected]>
The 2711 pixel valve can't produce odd horizontal timings, and checks were added to
vc4_hdmi_encoder_atomic_checkandvc4_hdmi_encoder_mode_validto filter out/block selection of such modes.[...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime