imx: imx8mm_beacon: Remove redundant code
PATCH 1/2 imx: imx8mm_beacon: Remove redundant code
The function to return the default MMC device for the environment already has a __weak instance doing exactly the same thing. Remove the superfluous one.
board/beacon/imx8mm/imx8mm_beacon.c +0 -5
@@ -50,8 +50,3 @@ int board_init(void)return 0 ; } - -int board_mmc_get_env_dev (int devno) -{ -return devno; -}
Signature · 1 line
2.32.0
PATCH 2/2 imx: imx8mn_beacon: Remove redundant code
The function to return the default MMC device for the environment already has a __weak instance doing exactly the same thing. Remove the superfluous one.
board/beacon/imx8mn/imx8mn_beacon.c +0 -5
@@ -50,8 +50,3 @@ int board_init(void)return 0 ; } - -int board_mmc_get_env_dev (int devno) -{ -return CONFIG_SYS_MMC_ENV_DEV ; -}
Signature · 1 line
2.32.0
PATCH 2/2 imx: imx8mn_beacon: Remove redundant code
Quoted 9 lines
The function to return the default MMC device for the environment already has a
__weakinstance doing exactly the same thing. Remove the superfluous one.Signed-off-by Adam Ford <[email protected]>board/beacon/imx8mn/imx8mn_beacon.c +0
-0
board/beacon/imx8mn/imx8mn_beacon.c int board_init(void) · line 57
Quoted 8 lines
board/beacon/imx8mn/imx8mn_beacon.c +0
-5@@ -50,8 +50,3 @@ int board_init(void)return 0 ; } - -int board_mmc_get_env_dev (int devno) -{ -return CONFIG_SYS_MMC_ENV_DEV ; -}
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
PATCH 1/2 imx: imx8mm_beacon: Remove redundant code
In reply to Adam FordQuoted 9 lines
The function to return the default MMC device for the environment already has a
__weakinstance doing exactly the same thing. Remove the superfluous one.Signed-off-by Adam Ford <[email protected]>board/beacon/imx8mm/imx8mm_beacon.c +0
-0
board/beacon/imx8mm/imx8mm_beacon.c int board_init(void) · line 57
Quoted 8 lines
board/beacon/imx8mm/imx8mm_beacon.c +0
-5@@ -50,8 +50,3 @@ int board_init(void)return 0 ; } - -int board_mmc_get_env_dev (int devno) -{ -return devno; -}
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================