kunit: fix missing f in f-string in run_checks.py
PATCH 1/1 kunit: fix missing f in f-string in run_checks.py
We're missing the f prefix to have python do string interpolation, so we'd never end up printing what the actual "unexpected" error is.
Fixes ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes")
Signed-off-by Daniel Latypov <[email protected]>
--- tools/testing/kunit/run_checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/kunit/run_checks.py +1 -1
@@ -61,7 +61,7 @@ def main(argv: Sequence[str]) -> None: elif isinstance(ex, subprocess.CalledProcessError): print(f'{name}: FAILED') else: - print('{name}: unexpected exception: {ex}') + print(f'{name}: unexpected exception: {ex}') continue output = ex.output
base-commit: 6125a5c70acddd9fc1fb7329047a254c74d0173c
Signature · 1 line
2.35.0.rc2.247.g8bbb082509-goog
Quoted 7 lines · Daniel Latypov
We're missing the
fprefix to have python do string interpolation, so we'd never end up printing what the actual "unexpected" error is.Fixes ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes")Signed-off-by Daniel Latypov <[email protected]>---
Looks good!
Reviewed-by David Gow <[email protected]>
Cheers,
-- David
Quoted 21 lines
tools/testing/kunit/run_checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/kunit/run_checks.py +1
-1@@ -61,7 +61,7 @@ def main(argv: Sequence[str]) -> None: elif isinstance(ex, subprocess.CalledProcessError): print(f'{name}: FAILED') else: - print('{name}: unexpected exception: {ex}') + print(f'{name}: unexpected exception: {ex}') continue output = ex.outputbase-commit:
6125a5c70acddd9fc1fb7329047a254c74d0173c--
2.35.0.rc2.247.g8bbb082509-goog
Quoted 6 lines · Daniel Latypov
We're missing the
fprefix to have python do string interpolation, so we'd never end up printing what the actual "unexpected" error is.Fixes ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes")Signed-off-by Daniel Latypov <[email protected]>
Reviewed-by Brendan Higgins <[email protected]>