Skip to contentSkip to conversation

newlib: Upgrade 4.1.0 -> 4.2.0

PATCH In review Alejandro Enedino Hernandez Samaniego 3 participants 5 messages Jan 28, 2022 – Feb 8, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 newlib: Upgrade 4.1.0 -> 4.2.0

---
 .../newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb}  |  0
 meta/recipes-core/newlib/newlib.inc                  | 12 +++++++++---
 .../newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb}      |  0
 3 files changed, 9 insertions(+), 3 deletions(-)
 rename meta/recipes-core/newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb} (100%)
 rename meta/recipes-core/newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb} (100%)
meta/recipes-core/newlib/libgloss_4.2.0.bb renamed from meta/recipes-core/newlib/libgloss_4.1.0.bb +0 -0
similarity index 100%
rename from meta/recipes-core/newlib/libgloss_4.1.0.bb
rename to meta/recipes-core/newlib/libgloss_4.2.0.bb
meta/recipes-core/newlib/newlib.inc +9 -3
index 23cd172008..5e488d0848 100644
@@ -15,13 +15,19 @@ LIC_FILES_CHKSUM = " \
 		file://newlib/libc/sys/linux/linuxthreads/LICENSE;md5=73640207fbc79b198c7ffd4ad4d97aa0 \
 		"
 
-SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}.tar.gz"
-SRC_URI[sha256sum] = "f296e372f51324224d387cc116dc37a6bd397198756746f93a2b02e9a5d40154"
+# Newlib maintainers sometimes publish the source
+# from a specific snapshot, after an upgrade we can
+# delete the following line and keep the empty default
+NEWLIB_SNAPSHOT = ".20211231"
+NEWLIB_SNAPSHOT ?= ""
+SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}${NEWLIB_SNAPSHOT}.tar.gz"
+SRC_URI[sha256sum] = "c3a0e8b63bc3bef1aeee4ca3906b53b3b86c8d139867607369cb2915ffc54435"
+
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS = "virtual/${TARGET_PREFIX}gcc"
 
-S = "${WORKDIR}/newlib-${PV}"
+S = "${WORKDIR}/newlib-${PV}${NEWLIB_SNAPSHOT}"
 B = "${WORKDIR}/build"
 
 ## disable stdlib
meta/recipes-core/newlib/newlib_4.2.0.bb renamed from meta/recipes-core/newlib/newlib_4.1.0.bb +0 -0
similarity index 100%
rename from meta/recipes-core/newlib/newlib_4.1.0.bb
rename to meta/recipes-core/newlib/newlib_4.2.0.bb
Signature · 1 line
2.25.1
#1 lore raw
Quoted 19 lines · Alejandro Hernandez Samaniego
---
 .../newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb}  |  0
 meta/recipes-core/newlib/newlib.inc                  | 12 +++++++++---
 .../newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb}      |  0
 3 files changed, 9 insertions(+), 3 deletions(-)
 rename meta/recipes-core/newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb} (100%)
 rename meta/recipes-core/newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb} (100%)
meta/recipes-core/newlib/libgloss_4.2.0.bb renamed from meta/recipes-core/newlib/libgloss_4.1.0.bb +0 -0
similarity index 100%
rename from meta/recipes-core/newlib/libgloss_4.1.0.bb
rename to meta/recipes-core/newlib/libgloss_4.2.0.bb
meta/recipes-core/newlib/newlib.inc +0 -0
index 23cd172008..5e488d0848 100644

meta/recipes-core/newlib/newlib.inc LIC_FILES_CHKSUM = " \ · line 21

Quoted 9 lines
meta/recipes-core/newlib/newlib.inc +4 -2
@@ -15,13 +15,19 @@ LIC_FILES_CHKSUM = " \
                file://newlib/libc/sys/linux/linuxthreads/LICENSE;md5=73640207fbc79b198c7ffd4ad4d97aa0 \
                "
 
-SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}.tar.gz"
-SRC_URI[sha256sum] = "f296e372f51324224d387cc116dc37a6bd397198756746f93a2b02e9a5d40154"
+# Newlib maintainers sometimes publish the source
+# from a specific snapshot, after an upgrade we can
+# delete the following line and keep the empty default
+NEWLIB_SNAPSHOT = ".20211231"

hmmm so its not 4.2.0 release yet ?
maybe just rename the recipe accordingly ?

Quoted 29 lines
meta/recipes-core/newlib/newlib.inc +5 -1
+NEWLIB_SNAPSHOT ?= ""
+SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}${NEWLIB_SNAPSHOT}.tar.gz"
+SRC_URI[sha256sum] = "c3a0e8b63bc3bef1aeee4ca3906b53b3b86c8d139867607369cb2915ffc54435"
+
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS = "virtual/${TARGET_PREFIX}gcc"
 
-S = "${WORKDIR}/newlib-${PV}"
+S = "${WORKDIR}/newlib-${PV}${NEWLIB_SNAPSHOT}"
 B = "${WORKDIR}/build"
 
 ## disable stdlib
meta/recipes-core/newlib/newlib_4.2.0.bb renamed from meta/recipes-core/newlib/newlib_4.1.0.bb +0 -1
similarity index 100%
rename from meta/recipes-core/newlib/newlib_4.1.0.bb
rename to meta/recipes-core/newlib/newlib_4.2.0.bb
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161064): https://lists.openembedded.org/g/openembedded-core/message/161064
Mute This Topic: https://lists.openembedded.org/mt/88736577/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 34 lines · Khem Raj
Quoted 2 lines · Alejandro Hernandez Samaniego
Signed-off-by Alejandro Enedino Hernandez Samaniego <

[email protected]>

Quoted 6 lines
---
 .../newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb}  |  0
 meta/recipes-core/newlib/newlib.inc                  | 12 +++++++++---
 .../newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb}      |  0
 3 files changed, 9 insertions(+), 3 deletions(-)
 rename meta/recipes-core/newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb}

(100%)

Quoted 1 line
 rename meta/recipes-core/newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb}

(100%)

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta/recipes-core/newlib/libgloss_4.2.0.bb

Review

Quoted 4 lines

similarity index 100%
rename from meta/recipes-core/newlib/libgloss_4.1.0.bb rename to meta/recipes-core/newlib/libgloss_4.2.0.bb

(quoted diff) +0 -0

b/meta/recipes-core/newlib/newlib.inc

meta/recipes-core/newlib/newlib.inc LIC_FILES_CHKSUM = " \ · line 15

Quoted 5 lines

index 23cd172008..5e488d0848 100644

meta/recipes-core/newlib/newlib.inc +0 -0
@@ -15,13 +15,19 @@ LIC_FILES_CHKSUM = " \
 

file://newlib/libc/sys/linux/linuxthreads/LICENSE;md5=73640207fbc79b198c7ffd4ad4d97aa0
\

meta/recipes-core/newlib/newlib.inc LIC_FILES_CHKSUM = " \

Quoted 4 lines
meta/recipes-core/newlib/newlib.inc +0 -2
                "
 
-SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}.tar.gz"
-SRC_URI[sha256sum] =

"f296e372f51324224d387cc116dc37a6bd397198756746f93a2b02e9a5d40154"

Quoted 8 lines

meta/recipes-core/newlib/newlib.inc LIC_FILES_CHKSUM = " \ · line 21

Quoted 4 lines
meta/recipes-core/newlib/newlib.inc +4 -0
+# Newlib maintainers sometimes publish the source
+# from a specific snapshot, after an upgrade we can
+# delete the following line and keep the empty default
+NEWLIB_SNAPSHOT = ".20211231"

hmmm so its not 4.2.0 release yet ?
maybe just rename the recipe accordingly ?

Its a little confusing, the source was uploaded with the snapshot suffix, but the snapshot tag in the git log points to:
Update newlib to 4.2.0
https://sourceware.org/git/?p=newlib-cygwin.git;a=commit;h=484d2ebf8d825b28af47b8ee88cd845f1d2c7c6e
So it seems it is the release, they just didn't upload it that way, I've waited a few weeks in case they did but no change.
Hence why I decided to keep the recipe name as 4.2.0

Alejandro

Quoted 36 lines

meta/recipes-core/newlib/newlib.inc LIC_FILES_CHKSUM = " \ · line 23

Quoted 3 lines
meta/recipes-core/newlib/newlib.inc +2 -0
+NEWLIB_SNAPSHOT ?= ""
+SRC_URI = "

https://sourceware.org/pub/newlib/newlib-${PV}${NEWLIB_SNAPSHOT}.tar.gz"

meta/recipes-core/newlib/newlib.inc LIC_FILES_CHKSUM = " \ · line 24

Quoted 1 line
meta/recipes-core/newlib/newlib.inc +1 -0
+SRC_URI[sha256sum] =

"c3a0e8b63bc3bef1aeee4ca3906b53b3b86c8d139867607369cb2915ffc54435"

Review

Quoted 11 lines
meta/recipes-core/newlib/newlib.inc +2 -1
+
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS = "virtual/${TARGET_PREFIX}gcc"
 
-S = "${WORKDIR}/newlib-${PV}"
+S = "${WORKDIR}/newlib-${PV}${NEWLIB_SNAPSHOT}"
 B = "${WORKDIR}/build"
 
 ## disable stdlib
(quoted diff) +0 -0

b/meta/recipes-core/newlib/newlib_4.2.0.bb

Quoted 10 lines

similarity index 100%
rename from meta/recipes-core/newlib/newlib_4.1.0.bb rename to meta/recipes-core/newlib/newlib_4.2.0.bb --
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#161064):

https://lists.openembedded.org/g/openembedded-core/message/161064

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/88736577/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
In reply to Alejandro Enedino Hernandez Samaniego

This is causing license errors for me:

ERROR: newlib-4.2.0-r0 do_populate_lic: QA Issue: newlib: The
LIC_FILES_CHKSUM does not match for
file://COPYING.NEWLIB;md5=b8dda70da54e0efb49b1074f349d7749
newlib: The new md5 checksum is 8bb75595dbcc7d45e5c0d116d7bdf6ce
newlib: Here is the selected license text:
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
The newlib subdirectory is a collection of software from several sources.
Each file may have its own copyright/license that is embedded in the source
file. Unless otherwise noted in the body of the source file(s), the
following copyright
notices will apply to the contents of the newlib subdirectory:
(1) Red Hat Incorporated
Copyright (c) 1994-2009 Red Hat, Inc. All rights reserved.
...
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
newlib: Check if the license information has changed in /builds/engineering/yocto/meta-arm/work/build/tmp/work/cortexm33e-fpv5-spd16-poky-eabi/newlib/4.2.0-r0/newlib-4.2.0.20211231/COPYING.NEWLIB to verify that the LICENSE value "GPLv2 & LGPLv3 & GPLv3 & LGPLv2 &
BSD-2-Clause & tcl" remains valid [license-checksum]

Ross

Quoted 57 lines · Alejandro Hernandez Samaniego
---
 .../newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb}  |  0
 meta/recipes-core/newlib/newlib.inc                  | 12 +++++++++---
 .../newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb}      |  0
 3 files changed, 9 insertions(+), 3 deletions(-)
 rename meta/recipes-core/newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb} (100%)
 rename meta/recipes-core/newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb} (100%)
meta/recipes-core/newlib/libgloss_4.2.0.bb renamed from meta/recipes-core/newlib/libgloss_4.1.0.bb +0 -0
similarity index 100%
rename from meta/recipes-core/newlib/libgloss_4.1.0.bb
rename to meta/recipes-core/newlib/libgloss_4.2.0.bb
meta/recipes-core/newlib/newlib.inc +9 -3
index 23cd172008..5e488d0848 100644
@@ -15,13 +15,19 @@ LIC_FILES_CHKSUM = " \
                file://newlib/libc/sys/linux/linuxthreads/LICENSE;md5=73640207fbc79b198c7ffd4ad4d97aa0 \
                "
 
-SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}.tar.gz"
-SRC_URI[sha256sum] = "f296e372f51324224d387cc116dc37a6bd397198756746f93a2b02e9a5d40154"
+# Newlib maintainers sometimes publish the source
+# from a specific snapshot, after an upgrade we can
+# delete the following line and keep the empty default
+NEWLIB_SNAPSHOT = ".20211231"
+NEWLIB_SNAPSHOT ?= ""
+SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}${NEWLIB_SNAPSHOT}.tar.gz"
+SRC_URI[sha256sum] = "c3a0e8b63bc3bef1aeee4ca3906b53b3b86c8d139867607369cb2915ffc54435"
+
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS = "virtual/${TARGET_PREFIX}gcc"
 
-S = "${WORKDIR}/newlib-${PV}"
+S = "${WORKDIR}/newlib-${PV}${NEWLIB_SNAPSHOT}"
 B = "${WORKDIR}/build"
 
 ## disable stdlib
meta/recipes-core/newlib/newlib_4.2.0.bb renamed from meta/recipes-core/newlib/newlib_4.1.0.bb +0 -1
similarity index 100%
rename from meta/recipes-core/newlib/newlib_4.1.0.bb
rename to meta/recipes-core/newlib/newlib_4.2.0.bb
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161064): https://lists.openembedded.org/g/openembedded-core/message/161064
Mute This Topic: https://lists.openembedded.org/mt/88736577/1676615
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw

Patch on the list.

It would be good to get newlib exercised in the AB somewhere...

Ross

Quoted 94 lines · Ross Burton

This is causing license errors for me:

ERROR: newlib-4.2.0-r0 do_populate_lic: QA Issue: newlib: The
LIC_FILES_CHKSUM does not match for
file://COPYING.NEWLIB;md5=b8dda70da54e0efb49b1074f349d7749
newlib: The new md5 checksum is 8bb75595dbcc7d45e5c0d116d7bdf6ce
newlib: Here is the selected license text:
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
The newlib subdirectory is a collection of software from several sources.
Each file may have its own copyright/license that is embedded in the source
file. Unless otherwise noted in the body of the source file(s), the
following copyright
notices will apply to the contents of the newlib subdirectory:
(1) Red Hat Incorporated
Copyright (c) 1994-2009 Red Hat, Inc. All rights reserved.
...
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
newlib: Check if the license information has changed in /builds/engineering/yocto/meta-arm/work/build/tmp/work/cortexm33e-fpv5-spd16-poky-eabi/newlib/4.2.0-r0/newlib-4.2.0.20211231/COPYING.NEWLIB to verify that the LICENSE value "GPLv2 & LGPLv3 & GPLv3 & LGPLv2 &
BSD-2-Clause & tcl" remains valid [license-checksum]

Ross

Quoted 57 lines · Alejandro Hernandez Samaniego
---
 .../newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb}  |  0
 meta/recipes-core/newlib/newlib.inc                  | 12 +++++++++---
 .../newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb}      |  0
 3 files changed, 9 insertions(+), 3 deletions(-)
 rename meta/recipes-core/newlib/{libgloss_4.1.0.bb => libgloss_4.2.0.bb} (100%)
 rename meta/recipes-core/newlib/{newlib_4.1.0.bb => newlib_4.2.0.bb} (100%)
meta/recipes-core/newlib/libgloss_4.2.0.bb renamed from meta/recipes-core/newlib/libgloss_4.1.0.bb +0 -0
similarity index 100%
rename from meta/recipes-core/newlib/libgloss_4.1.0.bb
rename to meta/recipes-core/newlib/libgloss_4.2.0.bb
meta/recipes-core/newlib/newlib.inc +9 -3
index 23cd172008..5e488d0848 100644
@@ -15,13 +15,19 @@ LIC_FILES_CHKSUM = " \
                file://newlib/libc/sys/linux/linuxthreads/LICENSE;md5=73640207fbc79b198c7ffd4ad4d97aa0 \
                "
 
-SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}.tar.gz"
-SRC_URI[sha256sum] = "f296e372f51324224d387cc116dc37a6bd397198756746f93a2b02e9a5d40154"
+# Newlib maintainers sometimes publish the source
+# from a specific snapshot, after an upgrade we can
+# delete the following line and keep the empty default
+NEWLIB_SNAPSHOT = ".20211231"
+NEWLIB_SNAPSHOT ?= ""
+SRC_URI = "https://sourceware.org/pub/newlib/newlib-${PV}${NEWLIB_SNAPSHOT}.tar.gz"
+SRC_URI[sha256sum] = "c3a0e8b63bc3bef1aeee4ca3906b53b3b86c8d139867607369cb2915ffc54435"
+
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS = "virtual/${TARGET_PREFIX}gcc"
 
-S = "${WORKDIR}/newlib-${PV}"
+S = "${WORKDIR}/newlib-${PV}${NEWLIB_SNAPSHOT}"
 B = "${WORKDIR}/build"
 
 ## disable stdlib
meta/recipes-core/newlib/newlib_4.2.0.bb renamed from meta/recipes-core/newlib/newlib_4.1.0.bb +0 -1
similarity index 100%
rename from meta/recipes-core/newlib/newlib_4.1.0.bb
rename to meta/recipes-core/newlib/newlib_4.2.0.bb
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161064): https://lists.openembedded.org/g/openembedded-core/message/161064
Mute This Topic: https://lists.openembedded.org/mt/88736577/1676615
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-