Skip to contentSkip to conversation

package/kf5/kf5-kcoreaddons: add missing comment dependency for binutils-bug-27597

PATCH New Giulio Benetti 3 participants 6 messages Jan 28, 2022 – Feb 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kf5/kf5-kcoreaddons: add missing comment dependency for binutils-bug-27597

---
 package/kf5/kf5-kcoreaddons/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/kf5/kf5-kcoreaddons/Config.in +3 -0
index 02bd38e395..eef43101a2 100644
@@ -13,3 +13,6 @@ config BR2_PACKAGE_KF5_KCOREADDONS
 	  on top of QtCore to perform various tasks.
 
 	  https://api.kde.org/frameworks/kcoreaddons/html/index.html
+
+comment "kf5-kcoreaddons needs a toolchain w/o bug 27597"
+	depends on BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/1 package/libcamera: fix missing comment for binutils-bug-27597

---
 package/libcamera/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcamera/Config.in +1 -1
index 23a0040abf..88db054975 100644
@@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads
 
 endif # BR2_PACKAGE_LIBCAMERA
 
-comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"
+comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597"
 	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH] package/libcamera: fix missing comment for binutils-bug-27597

Giulio, All,

On 2022-01-28 12:05 +0100, Giulio Benetti spake thusly:

Quoted 10 lines
---
 package/libcamera/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcamera/Config.in +0 -0
index 23a0040abf..88db054975 100644

package/libcamera/Config.in comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads · line 95

Quoted 5 lines
package/libcamera/Config.in +1 -1
@@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads
 
 endif # BR2_PACKAGE_LIBCAMERA
 
-comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"
+comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597"

Bug 27597 is inherently an architecture-speific bug, which is always set for NIOS2, so there is nothing the user can do about it except switch to another architecture...

The comments are meant for when the user has an alternative option, like chossing a different version of a component.

In this case, there is nothing the user can do, so we don't add it to the comment.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/libcamera/Config.in +0 -0
 	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH] package/libcamera: fix missing comment for binutils-bug-27597

Quoted 23 lines · Yann E. MORIN

Giulio, All,

On 2022-01-28 12:05 +0100, Giulio Benetti spake thusly:

Quoted 10 lines
---
  package/libcamera/Config.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/libcamera/Config.in +0 -0
index 23a0040abf..88db054975 100644

package/libcamera/Config.in comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads · line 95

Quoted 5 lines
package/libcamera/Config.in +1 -1
@@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads
 
  endif # BR2_PACKAGE_LIBCAMERA
 
-comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"
+comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597"

Bug 27597 is inherently an architecture-speific bug, which is always set for NIOS2, so there is nothing the user can do about it except switch to another architecture...

Quoted 5 lines

The comments are meant for when the user has an alternative option, like chossing a different version of a component.

In this case, there is nothing the user can do, so we don't add it to the comment.

Aaah, right, like hidden options. Ok, so let's drop this patch.

Thank you!
Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 14 lines

Regards,
Yann E. MORIN.

Quoted 10 lines
package/libcamera/Config.in +0 -0
  	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
  		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

PATCH 1/1 package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597

In reply to Giulio Benetti

Package pistache is affected by binutils bug 27597(Nios II), so let's disable it when BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y. Let'a also indent the comment dependencies.

Fixes:
http://autobuild.buildroot.net/results/0e7b74c5a07ced2bbae1a0a8c7d7ba26dfa04031/

---
 package/pistache/Config.in | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
package/pistache/Config.in +7 -5
index 64d6340827..96aed5210a 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_PISTACHE
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	help
 	  Pistache is a modern and elegant HTTP and REST framework
 	  for C++. It is entirely written in pure C++14 and provides
@@ -12,9 +13,10 @@ config BR2_PACKAGE_PISTACHE
 
 	  https://github.com/oktal/pistache
 
-comment "pistache needs a glibc toolchain w/ C++, gcc >= 4.9, threads, wchar"
+comment "pistache needs a glibc toolchain w/ C++, gcc >= 4.9, threads, wchar, not binutils bug 27597"
 	depends on !BR2_INSTALL_LIBSTDCPP || \
-	BR2_TOOLCHAIN_USES_UCLIBC || \
-	!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
-	!BR2_TOOLCHAIN_HAS_THREADS || \
-	!BR2_USE_WCHAR
+		   BR2_TOOLCHAIN_USES_UCLIBC || \
+		   !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+		   !BR2_TOOLCHAIN_HAS_THREADS || \
+		   !BR2_USE_WCHAR || \
+		   BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw

Re: [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597

Quoted 11 lines · On Fri, 28 Jan 2022 12:05:42 +0100 Giulio Benetti…

Package pistache is affected by binutils bug 27597(Nios II), so let's disable it when BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y. Let'a also indent the comment dependencies.

Fixes:
http://autobuild.buildroot.net/results/0e7b74c5a07ced2bbae1a0a8c7d7ba26dfa04031/

---
 package/pistache/Config.in | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot