Skip to contentSkip to conversation

ARM: dts: at91: sama7g5ek: disable slew rate for GMACs non MDIO pins

PATCH In review Codrin Ciubotariu 3 participants 4 messages Jan 28, 2022 – Feb 7, 2022 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: at91: sama7g5ek: disable slew rate for GMACs non MDIO pins

Non GMAC's MDIO pins should have slew rate disabled for R(G)MII modes. Set them accordingly in DT.

---
 arch/arm/dts/sama7g5ek.dts | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
arch/arm/dts/sama7g5ek.dts +19 -6
index 6adb044258..ac6f23f64e 100644
@@ -125,7 +125,9 @@
 	#address-cells = <1>;
 	#size-cells = <0>;
 	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_gmac0_default &pinctrl_gmac0_txc_default>;
+	pinctrl-0 = <&pinctrl_gmac0_default
+		     &pinctrl_gmac0_mdio_default
+		     &pinctrl_gmac0_txc_default>;
 	phy-mode = "rgmii-id";
 	status = "okay";
 
@@ -138,7 +140,7 @@
 	#address-cells = <1>;
 	#size-cells = <0>;
 	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_gmac1_default>;
+	pinctrl-0 = <&pinctrl_gmac1_default &pinctrl_gmac1_mdio_default>;
 	phy-mode = "rmii";
 	status = "okay";
 
@@ -235,14 +237,20 @@
 			 <PIN_PA15__G0_TXEN>,
 			 <PIN_PA30__G0_RXCK>,
 			 <PIN_PA18__G0_RXDV>,
-			 <PIN_PA22__G0_MDC>,
-			 <PIN_PA23__G0_MDIO>,
 			 <PIN_PA25__G0_125CK>;
+		slew-rate = <0>;
+		bias-disable;
+	};
+
+	pinctrl_gmac0_mdio_default: gmac0_mdio_default {
+		pinmux = <PIN_PA22__G0_MDC>,
+			 <PIN_PA23__G0_MDIO>;
 		bias-disable;
 	};
 
 	pinctrl_gmac0_txc_default: gmac0_txc_default {
 		pinmux = <PIN_PA24__G0_TXCK>;
+		slew-rate = <0>;
 		bias-pull-up;
 	};
 
@@ -254,8 +262,13 @@
 			 <PIN_PD25__G1_RX0>,
 			 <PIN_PD26__G1_RX1>,
 			 <PIN_PD27__G1_RXER>,
-			 <PIN_PD24__G1_RXDV>,
-			 <PIN_PD28__G1_MDC>,
+			 <PIN_PD24__G1_RXDV>;
+		slew-rate = <0>;
+		bias-disable;
+	};
+
+	pinctrl_gmac1_mdio_default: gmac1_mdio_default {
+		pinmux = <PIN_PD28__G1_MDC>,
 			 <PIN_PD29__G1_MDIO>;
 		bias-disable;
 	};
Signature · 1 line
2.32.0
Tested-by on v1 1/1
#1 lore raw
Quoted 5 lines · Codrin Ciubotariu

Non GMAC's MDIO pins should have slew rate disabled for R(G)MII modes. Set them accordingly in DT.

---

Quoted 67 lines
  arch/arm/dts/sama7g5ek.dts | 25 +++++++++++++++++++------
  1 file changed, 19 insertions(+), 6 deletions(-)
arch/arm/dts/sama7g5ek.dts +19 -6
index 6adb044258..ac6f23f64e 100644
@@ -125,7 +125,9 @@
  	#address-cells = <1>;
  	#size-cells = <0>;
  	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_gmac0_default &pinctrl_gmac0_txc_default>;
+	pinctrl-0 = <&pinctrl_gmac0_default
+		     &pinctrl_gmac0_mdio_default
+		     &pinctrl_gmac0_txc_default>;
  	phy-mode = "rgmii-id";
  	status = "okay";
 
@@ -138,7 +140,7 @@
  	#address-cells = <1>;
  	#size-cells = <0>;
  	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_gmac1_default>;
+	pinctrl-0 = <&pinctrl_gmac1_default &pinctrl_gmac1_mdio_default>;
  	phy-mode = "rmii";
  	status = "okay";
 
@@ -235,14 +237,20 @@
  			 <PIN_PA15__G0_TXEN>,
  			 <PIN_PA30__G0_RXCK>,
  			 <PIN_PA18__G0_RXDV>,
-			 <PIN_PA22__G0_MDC>,
-			 <PIN_PA23__G0_MDIO>,
  			 <PIN_PA25__G0_125CK>;
+		slew-rate = <0>;
+		bias-disable;
+	};
+
+	pinctrl_gmac0_mdio_default: gmac0_mdio_default {
+		pinmux = <PIN_PA22__G0_MDC>,
+			 <PIN_PA23__G0_MDIO>;
  		bias-disable;
  	};
 
  	pinctrl_gmac0_txc_default: gmac0_txc_default {
  		pinmux = <PIN_PA24__G0_TXCK>;
+		slew-rate = <0>;
  		bias-pull-up;
  	};
 
@@ -254,8 +262,13 @@
  			 <PIN_PD25__G1_RX0>,
  			 <PIN_PD26__G1_RX1>,
  			 <PIN_PD27__G1_RXER>,
-			 <PIN_PD24__G1_RXDV>,
-			 <PIN_PD28__G1_MDC>,
+			 <PIN_PD24__G1_RXDV>;
+		slew-rate = <0>;
+		bias-disable;
+	};
+
+	pinctrl_gmac1_mdio_default: gmac1_mdio_default {
+		pinmux = <PIN_PD28__G1_MDC>,
  			 <PIN_PD29__G1_MDIO>;
  		bias-disable;
  	};
Reviewed-by
#2 lore raw
Quoted 8 lines · On 28.01.2022 18:31, Eugen Hristev - M18282 wrote:
Quoted 5 lines · Codrin Ciubotariu

Non GMAC's MDIO pins should have slew rate disabled for R(G)MII modes. Set them accordingly in DT.

---

Quoted 69 lines
Quoted 68 lines
  arch/arm/dts/sama7g5ek.dts | 25 +++++++++++++++++++------
  1 file changed, 19 insertions(+), 6 deletions(-)
arch/arm/dts/sama7g5ek.dts +19 -6
index 6adb044258..ac6f23f64e 100644
@@ -125,7 +125,9 @@
  	#address-cells = <1>;
  	#size-cells = <0>;
  	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_gmac0_default &pinctrl_gmac0_txc_default>;
+	pinctrl-0 = <&pinctrl_gmac0_default
+		     &pinctrl_gmac0_mdio_default
+		     &pinctrl_gmac0_txc_default>;
  	phy-mode = "rgmii-id";
  	status = "okay";
 
@@ -138,7 +140,7 @@
  	#address-cells = <1>;
  	#size-cells = <0>;
  	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_gmac1_default>;
+	pinctrl-0 = <&pinctrl_gmac1_default &pinctrl_gmac1_mdio_default>;
  	phy-mode = "rmii";
  	status = "okay";
 
@@ -235,14 +237,20 @@
  			 <PIN_PA15__G0_TXEN>,
  			 <PIN_PA30__G0_RXCK>,
  			 <PIN_PA18__G0_RXDV>,
-			 <PIN_PA22__G0_MDC>,
-			 <PIN_PA23__G0_MDIO>,
  			 <PIN_PA25__G0_125CK>;
+		slew-rate = <0>;
+		bias-disable;
+	};
+
+	pinctrl_gmac0_mdio_default: gmac0_mdio_default {
+		pinmux = <PIN_PA22__G0_MDC>,
+			 <PIN_PA23__G0_MDIO>;
  		bias-disable;
  	};
 
  	pinctrl_gmac0_txc_default: gmac0_txc_default {
  		pinmux = <PIN_PA24__G0_TXCK>;
+		slew-rate = <0>;
  		bias-pull-up;
  	};
 
@@ -254,8 +262,13 @@
  			 <PIN_PD25__G1_RX0>,
  			 <PIN_PD26__G1_RX1>,
  			 <PIN_PD27__G1_RXER>,
-			 <PIN_PD24__G1_RXDV>,
-			 <PIN_PD28__G1_MDC>,
+			 <PIN_PD24__G1_RXDV>;
+		slew-rate = <0>;
+		bias-disable;
+	};
+
+	pinctrl_gmac1_mdio_default: gmac1_mdio_default {
+		pinmux = <PIN_PD28__G1_MDC>,
  			 <PIN_PD29__G1_MDIO>;
  		bias-disable;
  	};
#3 lore raw
Quoted 5 lines · On 1/28/22 6:56 PM, Claudiu Beznea - M18063 wrote:
Quoted 4 lines · On 28.01.2022 18:31, Eugen Hristev - M18282 wrote:
Quoted 3 lines · Codrin Ciubotariu

Non GMAC's MDIO pins should have slew rate disabled for R(G)MII modes. Set them accordingly in DT.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

---

Applied to u-boot-at91/master , thanks !