Skip to contentSkip to conversation

drm/amdkfd: Fix variable set but not used warning

PATCH In review Philip Yang 2 participants 2 messages Jan 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Fix variable set but not used warning

All warnings (new ones prefixed by >>):

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c: In function
'svm_range_deferred_list_work':

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2067:22: warning:

variable 'p' set but not used [-Wunused-but-set-variable]

    2067 |  struct kfd_process *p;
         |
Fixes 8b633bdc86671("drm/amdkfd: Ensure mm remain valid in svm

deferred_list work")

---
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_svm.c +0 -3
index 649c1d2b9607..9a509ec8c327 100644
@@ -2079,13 +2079,10 @@ static void svm_range_deferred_list_work(struct work_struct *work)
 	struct svm_range_list *svms;
 	struct svm_range *prange;
 	struct mm_struct *mm;
-	struct kfd_process *p;
 
 	svms = container_of(work, struct svm_range_list, deferred_list_work);
 	pr_debug("enter svms 0x%p\n", svms);
 
-	p = container_of(svms, struct kfd_process, svms);
-
 	spin_lock(&svms->deferred_list_lock);
 	while (!list_empty(&svms->deferred_range_list)) {
 		prange = list_first_entry(&svms->deferred_range_list,
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only]

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Philip Yang
Sent: Friday, January 28, 2022 9:39 AM
To: [email protected]
Cc: Yang, Philip <[email protected]>
Subject: [PATCH 1/1] drm/amdkfd: Fix variable set but not used warning

All warnings (new ones prefixed by >>):

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c: In function
'svm_range_deferred_list_work':

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2067:22: warning:

variable 'p' set but not used [-Wunused-but-set-variable]

    2067 |  struct kfd_process *p;
         |
Fixes 8b633bdc86671("drm/amdkfd: Ensure mm remain valid in svm deferred_list work")
---
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_svm.c +0 -3
index 649c1d2b9607..9a509ec8c327 100644
@@ -2079,13 +2079,10 @@ static void svm_range_deferred_list_work(struct work_struct *work)
 	struct svm_range_list *svms;
 	struct svm_range *prange;
 	struct mm_struct *mm;
-	struct kfd_process *p;
 
 	svms = container_of(work, struct svm_range_list, deferred_list_work);
 	pr_debug("enter svms 0x%p\n", svms);
 
-	p = container_of(svms, struct kfd_process, svms);
-
 	spin_lock(&svms->deferred_list_lock);
 	while (!list_empty(&svms->deferred_range_list)) {
 		prange = list_first_entry(&svms->deferred_range_list,

--
2.17.1