Skip to contentSkip to conversation

drm/amdgpu: drop flood print in rlcg reg access function

PATCH In review Guchun Chen 2 participants 2 messages Jan 28, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: drop flood print in rlcg reg access function

A lot of below message are outputed in SRIOV case.
amdgpu: indirect registers access through rlcg is not supported

Also drop redundant ret set, as it's initialized to be false already.

Fixes d4cd09ca9bce("drm/amdgpu: add helper to query rlcg reg access flag")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +0 -3
index 80c25176c993..b56cafb26f4a 100644
@@ -849,9 +849,6 @@ static bool amdgpu_virt_get_rlcg_reg_access_flag(struct amdgpu_device *adev,
 		}
 		break;
 	default:
-		dev_err(adev->dev,
-			"indirect registers access through rlcg is not supported\n");
-		ret = false;
 		break;
 	}
 	return ret;
Signature · 1 line
2.17.1
maintainer Acked-by on v1 1/1
#1 lore raw

[Public]

________________________________
From: Chen, Guchun <[email protected]>
Sent: Friday, January 28, 2022 10:19 AM
To: [email protected] <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Pan, Xinhui <[email protected]>; Zhang, Hawking <[email protected]>
Cc: Chen, Guchun <[email protected]>
Subject: [PATCH] drm/amdgpu: drop flood print in rlcg reg access function

A lot of below message are outputed in SRIOV case.
amdgpu: indirect registers access through rlcg is not supported

Also drop redundant ret set, as it's initialized to be false already.

Fixes d4cd09ca9bce("drm/amdgpu: add helper to query rlcg reg access flag")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +0 -3
index 80c25176c993..b56cafb26f4a 100644
@@ -849,9 +849,6 @@ static bool amdgpu_virt_get_rlcg_reg_access_flag(struct amdgpu_device *adev,
                 }
                 break;
         default:
-               dev_err(adev->dev,
-                       "indirect registers access through rlcg is not supported\n");
-               ret = false;
                 break;
         }
         return ret;

--
2.17.1