arm: dts: imx8mq-pinfunc: add a define for the SION bit
Subsystems (2)
PATCH 1/1 arm: dts: imx8mq-pinfunc: add a define for the SION bit
SION (Software Input On Field) - force the select mode input path
--- arch/arm/dts/imx8mq-pinfunc.h | 1 + 1 file changed, 1 insertion(+)
arch/arm/dts/imx8mq-pinfunc.h +1 -0
@@ -7,6 +7,7 @@#ifndef __DTS_IMX8MQ_PINFUNC_H#define __DTS_IMX8MQ_PINFUNC_H +#define IMX_PAD_SION 0x40000000/* * The pin function ID is a tuple of * <mux_reg conf_reg input_reg mux_mode input_val>
Signature · 1 line
2.25.1
Fabio Estevam
reviewerHi Angus,
Quoted 13 lines · Angus Ainslie
SION (Software Input On Field) - force the select mode input path
Signed-off-by Angus Ainslie <[email protected]>--- arch/arm/dts/imx8mq-pinfunc.h | 1 + 1 file changed, 1 insertion(+)arch/arm/dts/imx8mq-pinfunc.h +0
-0
arch/arm/dts/imx8mq-pinfunc.h line 10
Quoted 4 lines
arch/arm/dts/imx8mq-pinfunc.h +1
-0@@ -7,6 +7,7 @@#ifndef __DTS_IMX8MQ_PINFUNC_H#define __DTS_IMX8MQ_PINFUNC_H +#define IMX_PAD_SION 0x40000000
We want to keep this file in sync with Linux.
If you need to pass IMX_PAD_SION in your board file, please use a different header file.
Also, can't you just set the sion bit via devicetree? The last time we discussed this issue, there seemed to be a DT problem.
Please let us know.
Hi Fabio,
Quoted 19 lines · Fabio Estevam
Hi Angus,
Quoted 16 lines · Angus Ainslie
SION (Software Input On Field) - force the select mode input path
Signed-off-by Angus Ainslie <[email protected]>--- arch/arm/dts/imx8mq-pinfunc.h | 1 + 1 file changed, 1 insertion(+)arch/arm/dts/imx8mq-pinfunc.h +0
-0@@ -7,6 +7,7 @@#ifndef __DTS_IMX8MQ_PINFUNC_H#define __DTS_IMX8MQ_PINFUNC_H
Quoted 7 lines
arch/arm/dts/imx8mq-pinfunc.h line 10
Quoted 1 line
arch/arm/dts/imx8mq-pinfunc.h +1
-0+#define IMX_PAD_SION 0x40000000We want to keep this file in sync with Linux.
If you need to pass
IMX_PAD_SIONin your board file, please use a different header file.
I added this because I wanted to use it in the SPL. I can put it in the header file for my board but I think it would be better in an imx8m header file. If not the pinfunc header is there another imx8m header you could suggest ?
Quoted 3 lines
Also, can't you just set the sion bit via devicetree? The last time we discussed this issue, there seemed to be a DT problem.
I can set the sion bit via the DT but I'm not using the DT n the SPL so it won't help much.
Thanks
Angus
Quoted 1 line
Please let us know.
Fabio Estevam
reviewerHi Angus,
Quoted 4 lines · Angus Ainslie
I added this because I wanted to use it in the SPL. I can put it in the header file for my board but I think it would be better in an imx8m header file. If not the pinfunc header is there another imx8m header you could suggest ?
What about arch/arm/include/asm/mach-imx/sys_proto.h ?
Quoted 2 lines
I can set the sion bit via the DT but I'm not using the DT n the SPL so it won't help much.
Ok, understood.
Quoted 11 lines · Fabio Estevam
Hi Angus,
Quoted 4 lines · Angus Ainslie
I added this because I wanted to use it in the SPL. I can put it in the header file for my board but I think it would be better in an imx8m header file. If not the pinfunc header is there another imx8m header you could suggest ?
What about
arch/arm/include/asm/mach-imx/sys_proto.h?
So it turns out it's already defined here
drivers/pinctrl/nxp/pinctrl-imx.h
Could that definition be moved here ?
arch/arm/include/asm/mach-imx/iomux-v3.h
Fabio Estevam
reviewerQuoted 7 lines · Angus Ainslie
So it turns out it's already defined here
drivers/pinctrl/nxp/pinctrl-imx.hCould that definition be moved here ?
arch/arm/include/asm/mach-imx/iomux-v3.h
Yes, that would work too.