Skip to contentSkip to conversation

srcu: make srcu_size_state_name static

PATCH In review Jiapeng Chong 2 participants 2 messages Jan 29, 2022 – Feb 1, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 srcu: make srcu_size_state_name static

This symbol is not used outside of srcutree.c, so marks it static.

Fixes the following sparse warning:

kernel/rcu/srcutree.c:1426:12: warning: symbol 'srcu_size_state_name' was not declared. Should it be static?

---
 kernel/rcu/srcutree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/srcutree.c +1 -1
index 4201815744d8..31dbd41332f6 100644
@@ -1423,7 +1423,7 @@ void srcutorture_get_gp_data(enum rcutorture_type test_type,
 }
 EXPORT_SYMBOL_GPL(srcutorture_get_gp_data);
 
-const char * const srcu_size_state_name[] =
+static const char * const srcu_size_state_name[] =
 {
 	"SRCU_SIZE_SMALL",
 	"SRCU_SIZE_ALLOC",
Signature · 1 line
2.20.1.7.g153144c
maintainer
#1 lore raw
Quoted 9 lines · Jiapeng Chong

This symbol is not used outside of srcutree.c, so marks it static.

Fixes the following sparse warning:

kernel/rcu/srcutree.c:1426:12: warning: symbol 'srcu_size_state_name' was not declared. Should it be static?

And I did queue and push this, good catch, thank you!

Thanx, Paul

Quoted 20 lines
---
 kernel/rcu/srcutree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/srcutree.c +1 -1
index 4201815744d8..31dbd41332f6 100644
@@ -1423,7 +1423,7 @@ void srcutorture_get_gp_data(enum rcutorture_type test_type,
 }
 EXPORT_SYMBOL_GPL(srcutorture_get_gp_data);
 
-const char * const srcu_size_state_name[] =
+static const char * const srcu_size_state_name[] =
 {
 	"SRCU_SIZE_SMALL",
 	"SRCU_SIZE_ALLOC",
Signature · 1 line
2.20.1.7.g153144c