package/efl: bump to version 1.26.1
PATCH 1/5 package/efl: bump to version 1.26.1
This is a bug-fix release.
See: https://www.enlightenment.org/news/2022-01-03-efl-1.26.1
--- package/efl/efl.hash | 4 ++-- package/efl/efl.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
package/efl/efl.hash +2 -2
@@ -1,5 +1,5 @@ -# From https://www.enlightenment.org/news/2021-12-26-efl-1.26.0 -sha256 a4a9bce45fd27f8541874e44a130f64550bee1f2f72feaa6c8a758d92eaf204c efl-1.26.0.tar.xz +# From https://www.enlightenment.org/news/2022-01-03-efl-1.26.1 +sha256 86a9677e3d48dd0c13a399ebb417bd417bd8d150d6b06cc491bc92275c88a642 efl-1.26.1.tar.xz sha256 d666b6b2df9f5b791f85c299c65516cb55528b02a807603de246f65f4918ae22 COMPLIANCE sha256 5bceb52d65debe420bc520f2992807740dc928b7fdc3c2e9a74b5889177ddf4c COPYING
package/efl/efl.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -EFL_VERSION = 1.26.0 +EFL_VERSION = 1.26.1 EFL_SOURCE = efl-$(EFL_VERSION).tar.xz EFL_SITE = https://download.enlightenment.org/rel/libs/efl EFL_LICENSE = BSD-2-Clause, LGPL-2.1+, GPL-2.0+, FTL, MIT
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 2/5 package/enlightenment: bump to version 0.25.1
This is the a bugfix release.
See:
https://www.enlightenment.org/news/2022-01-03-enlightenment-0.25.1
--- package/enlightenment/enlightenment.hash | 4 ++-- package/enlightenment/enlightenment.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
package/enlightenment/enlightenment.hash +2 -2
@@ -1,4 +1,4 @@ -# From https://www.enlightenment.org/news/2021-12-26-enlightenment-0.25.0 -sha256 7d6e72ceed5aca135b7a49c2a1c1eb9d8fde1318613517401d0418e0e5f6df06 enlightenment-0.25.0.tar.xz +# From https://www.enlightenment.org/news/2022-01-03-enlightenment-0.25.1 +sha256 2cf05fe3d96ef35e823619dbc0ac513ecabcae2186800ecd804924a637112444 enlightenment-0.25.1.tar.xz sha256 8d2fbc393e967cd6f5b8559d1744881a6a1ceb3ec6e1c2368c3916809ffccb8d COPYING sha256 cdc77ee1732455b203610f923fe4196046b3f7509038c48dc0b0c7e3492c23f3 src/modules/wl_weekeyboard/themes/default/fonts/LICENSE.txt
package/enlightenment/enlightenment.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -ENLIGHTENMENT_VERSION = 0.25.0 +ENLIGHTENMENT_VERSION = 0.25.1 ENLIGHTENMENT_SOURCE = enlightenment-$(ENLIGHTENMENT_VERSION).tar.xz ENLIGHTENMENT_SITE = https://download.enlightenment.org/rel/apps/enlightenment ENLIGHTENMENT_LICENSE = BSD-2-Clause, OFL-1.1 (font)
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 2/5] package/enlightenment: bump to version 0.25.1
Quoted 10 lines · On Sat, 29 Jan 2022 23:46:48 +0100 Romain Naour <[email protected]> wrote:
This is the a bugfix release.
See:
https://www.enlightenment.org/news/2022-01-03-enlightenment-0.25.1Signed-off-by Romain Naour <[email protected]>--- package/enlightenment/enlightenment.hash | 4 ++-- package/enlightenment/enlightenment.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 3/5 package/efl: rework eeze handling in Kconfig
In reply to Romain NaourCommit [1] added eeze dependency using "depends on" to several efl options (drm, libmount) instead of selecting eeze and propagate the udev reverse dependency.
The dependency between eeze, libinput, efl drm requires to add a new libinput option.
Rework eeze handling to use select BR2_PACKAGE_EFL_EEZE since the user is already aware of the udev dependency (BR2_PACKAGE_HAS_UDEV).
[1] e026c3bdb8f493b3fc21de7c45e3edbc47e03128
--- package/efl/Config.in | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
package/efl/Config.in +8 -6
@@ -115,7 +115,8 @@ config BR2_PACKAGE_EFL_PULSEAUDIO config BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT bool "Enable libmount support (recommended)" default y - depends on BR2_PACKAGE_EFL_EEZE + depends on BR2_PACKAGE_HAS_UDEV # eeze + select BR2_PACKAGE_EFL_EEZE select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT # libblkid is part of required tools, see EFL's README.
@@ -126,7 +127,7 @@ config BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT Enlightenment and its filemanager. comment "efl's libmount support needs udev /dev management (eeze)" - depends on !BR2_PACKAGE_EFL_EEZE + depends on !BR2_PACKAGE_HAS_UDEV config BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG bool
@@ -173,7 +174,7 @@ config BR2_PACKAGE_EFL_WAYLAND depends on BR2_PACKAGE_WAYLAND depends on BR2_TOOLCHAIN_HAS_THREADS # Evas DRM Engine -> libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine - depends on BR2_PACKAGE_EFL_EEZE # efl drm + depends on BR2_PACKAGE_HAS_UDEV # efl drm (eeze) depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput select BR2_PACKAGE_EFL_DRM
@@ -182,7 +183,7 @@ config BR2_PACKAGE_EFL_WAYLAND comment "Wayland support needs udev /dev management (eeze), OpenGL ES w/ EGL, threads, locales" depends on BR2_PACKAGE_WAYLAND depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \ - || !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE \ + || !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_HAS_UDEV \ || !BR2_ENABLE_LOCALE choice
@@ -215,9 +216,10 @@ endchoice # OpenGL support config BR2_PACKAGE_EFL_DRM bool "Evas DRM Engine" - depends on BR2_PACKAGE_EFL_EEZE + depends on BR2_PACKAGE_HAS_UDEV (eeze) depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d + select BR2_PACKAGE_EFL_EEZE select BR2_PACKAGE_LIBDRM select BR2_PACKAGE_LIBINPUT # For elput select BR2_PACKAGE_LIBXKBCOMMON
@@ -232,7 +234,7 @@ config BR2_PACKAGE_EFL_DRM comment "Evas DRM Engine needs udev /dev management (eeze), mesa3d w/ EGL support, threads" depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \ - || !BR2_PACKAGE_EFL_EEZE + || !BR2_PACKAGE_HAS_UDEV comment "libevas loaders"
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig
Quoted 3 lines · On Sat, 29 Jan 2022 23:46:49 +0100 Romain Naour <[email protected]> wrote:
Commit [1] added eeze dependency using "depends on" to several efl options (drm, libmount) instead of selecting eeze and propagate the udev reverse dependency.
I do agree with changing from a "depends on BR2_PACKAGE_EFL_EEZE" to a "depends BR2_PACKAGE_HAS_UDEV" + "select BR2_PACKAGE_EFL_EEZE". However...
Quoted 2 lines
The dependency between eeze, libinput, efl drm requires to add a new libinput option.
... I don't understand this justification. Could you clarify. Even after reading PATCH 4/5, I don't get the relationship. PATCH 4/5 could have been done (I guess using the same principle of "depends on BR2_PACKAGE_EFL_EEZE".
Quoted 2 lines
Rework eeze handling to use select
BR2_PACKAGE_EFL_EEZEsince the user is already aware of the udev dependency (BR2_PACKAGE_HAS_UDEV).
I don't understand why you say the user is already aware of the udev dependency? Thanks to the comments?
Quoted 1 line
comment "efl's libmount support needs udev /dev management (eeze)"
Remove the "eeze" between parenthesis here I believe.
Quoted 15 lines
package/efl/Config.in +2
-2- depends on !BR2_PACKAGE_EFL_EEZE + depends on !BR2_PACKAGE_HAS_UDEV config BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG bool@@ -173,7 +174,7 @@ config BR2_PACKAGE_EFL_WAYLAND depends on BR2_PACKAGE_WAYLAND depends on BR2_TOOLCHAIN_HAS_THREADS # Evas DRM Engine -> libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine - depends on BR2_PACKAGE_EFL_EEZE # efl drm + depends on BR2_PACKAGE_HAS_UDEV # efl drm (eeze) depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput select BR2_PACKAGE_EFL_DRM
package/efl/Config.in config BR2_PACKAGE_EFL_WAYLAND · line 183
Quoted 1 line
package/efl/Config.in +0
-0@@ -182,7 +183,7 @@ config BR2_PACKAGE_EFL_WAYLAND comment "Wayland support needs udev /dev management (eeze), OpenGL ES w/ EGL, threads, locales"
Ditto.
package/efl/Config.in endchoice # OpenGL support · line 219
Quoted 13 lines
package/efl/Config.in +2
-2depends on BR2_PACKAGE_WAYLAND depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \ - || !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE \ + || !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_HAS_UDEV \ || !BR2_ENABLE_LOCALE choice@@ -215,9 +216,10 @@ endchoice # OpenGL support config BR2_PACKAGE_EFL_DRM bool "Evas DRM Engine" - depends on BR2_PACKAGE_EFL_EEZE + depends on BR2_PACKAGE_HAS_UDEV (eeze)
Does this line really parses correctly?
package/efl/Config.in config BR2_PACKAGE_EFL_DRM · line 235
Quoted 9 lines
package/efl/Config.in +1
-0depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d + select BR2_PACKAGE_EFL_EEZE select BR2_PACKAGE_LIBDRM select BR2_PACKAGE_LIBINPUT # For elput select BR2_PACKAGE_LIBXKBCOMMON@@ -232,7 +234,7 @@ config BR2_PACKAGE_EFL_DRM comment "Evas DRM Engine needs udev /dev management (eeze), mesa3d w/ EGL support, threads"
Remove the "eeze" between parenthesis.
Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig
Hello Thomas,
Le 30/01/2022 à 15:02, Thomas Petazzoni a écrit :
Quoted 11 lines
Quoted 3 lines · On Sat, 29 Jan 2022 23:46:49 +0100 Romain Naour <[email protected]> wrote:
Commit [1] added eeze dependency using "depends on" to several efl options (drm, libmount) instead of selecting eeze and propagate the udev reverse dependency.
I do agree with changing from a "depends on
BR2_PACKAGE_EFL_EEZE" to a "dependsBR2_PACKAGE_HAS_UDEV" + "selectBR2_PACKAGE_EFL_EEZE". However...
Quoted 7 lines
Quoted 2 lines
The dependency between eeze, libinput, efl drm requires to add a new libinput option.
... I don't understand this justification. Could you clarify. Even after reading PATCH 4/5, I don't get the relationship. PATCH 4/5 could have been done (I guess using the same principle of "depends on
BR2_PACKAGE_EFL_EEZE".
AFAIK, efl drm needs libinput (elput) that requires udev (eeze).
Until now we don't have a libinput option to disable it when eeze is also disabled.
Quoted 6 lines
Quoted 3 lines
Rework eeze handling to use select
BR2_PACKAGE_EFL_EEZEsince the user is already aware of the udev dependency (BR2_PACKAGE_HAS_UDEV).I don't understand why you say the user is already aware of the udev dependency? Thanks to the comments?
I mean if eeze can be selected, it means that the used either selected systemd or eudev.
Quoted 48 lines
Quoted 2 lines
comment "efl's libmount support needs udev /dev management (eeze)"
Remove the "eeze" between parenthesis here I believe.
Quoted 15 lines
package/efl/Config.in +2
-2- depends on !BR2_PACKAGE_EFL_EEZE + depends on !BR2_PACKAGE_HAS_UDEV config BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG bool@@ -173,7 +174,7 @@ config BR2_PACKAGE_EFL_WAYLAND depends on BR2_PACKAGE_WAYLAND depends on BR2_TOOLCHAIN_HAS_THREADS # Evas DRM Engine -> libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine - depends on BR2_PACKAGE_EFL_EEZE # efl drm + depends on BR2_PACKAGE_HAS_UDEV # efl drm (eeze) depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput select BR2_PACKAGE_EFL_DRMpackage/efl/Config.in config BR2_PACKAGE_EFL_WAYLAND · line 183
Quoted 1 line
package/efl/Config.in +0
-0@@ -182,7 +183,7 @@ config BR2_PACKAGE_EFL_WAYLAND comment "Wayland support needs udev /dev management (eeze), OpenGL ES w/ EGL, threads, locales"Ditto.
package/efl/Config.in endchoice # OpenGL support · line 219
Quoted 13 lines
package/efl/Config.in +2
-2depends on BR2_PACKAGE_WAYLAND depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \ - || !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE \ + || !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_HAS_UDEV \ || !BR2_ENABLE_LOCALE choice@@ -215,9 +216,10 @@ endchoice # OpenGL support config BR2_PACKAGE_EFL_DRM bool "Evas DRM Engine" - depends on BR2_PACKAGE_EFL_EEZE + depends on BR2_PACKAGE_HAS_UDEV (eeze)Does this line really parses correctly?
Quoted 8 lines
package/efl/Config.in +1
-0depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d + select BR2_PACKAGE_EFL_EEZE select BR2_PACKAGE_LIBDRM select BR2_PACKAGE_LIBINPUT # For elput select BR2_PACKAGE_LIBXKBCOMMON@@ -232,7 +234,7 @@ config BR2_PACKAGE_EFL_DRM
Quoted 3 lines
package/efl/Config.in config BR2_PACKAGE_EFL_DRM · line 235
Quoted 1 line
package/efl/Config.in +0
-0comment "Evas DRM Engine needs udev /dev management (eeze), mesa3d w/ EGL support, threads"Remove the "eeze" between parenthesis.
Best regards,
Romain
Quoted 5 lines
Thanks!
Thomas
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig
Hello,
Quoted 15 lines · On Sun, 30 Jan 2022 18:40:39 +0100 Romain Naour <[email protected]> wrote:
Le 30/01/2022 à 15:02, Thomas Petazzoni a écrit :
Quoted 14 lines
Quoted 3 lines · On Sat, 29 Jan 2022 23:46:49 +0100 Romain Naour <[email protected]> wrote:
Commit [1] added eeze dependency using "depends on" to several efl options (drm, libmount) instead of selecting eeze and propagate the udev reverse dependency.
I do agree with changing from a "depends on
BR2_PACKAGE_EFL_EEZE" to a "dependsBR2_PACKAGE_HAS_UDEV" + "selectBR2_PACKAGE_EFL_EEZE". However...Quoted 2 lines
The dependency between eeze, libinput, efl drm requires to add a new libinput option.
Quoted 7 lines
Quoted 4 lines
... I don't understand this justification. Could you clarify. Even after reading PATCH 4/5, I don't get the relationship. PATCH 4/5 could have been done (I guess using the same principle of "depends on
BR2_PACKAGE_EFL_EEZE".AFAIK, efl drm needs libinput (elput) that requires udev (eeze).
Until now we don't have a libinput option to disable it when eeze is also disabled.
Right, and? How is that related to changing "depends on BR2_PACKAGE_EFL_EEZE" to "select BR2_PACKAGE_EFL_EEZE" ?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Rework eeze handling to use select
BR2_PACKAGE_EFL_EEZEsince the user is already aware of the udev dependency (BR2_PACKAGE_HAS_UDEV).I don't understand why you say the user is already aware of the udev dependency? Thanks to the comments?
I mean if eeze can be selected, it means that the used either selected systemd or eudev.
But that's just normal thing in Buildroot, no? I fail to understand this part of your commit log.
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 4/5 package/efl: handle input option
In reply to Romain NaourFrom: Fabrice Fontaine <[email protected]>
Commit 2d7a3e48c574c05346b66f79cdb75ecdfa7f074e forgot to manage input option on target which was added (and enabled by default) by
https://git.enlightenment.org/core/efl.git/commit/?id=0c2cf7e1bf7ca547655d25aaea30d081101b42be
resulting in the following build failure when eeze is disabled:
../output-1/build/efl-1.26.0/src/lib/elput/meson.build:1:0: ERROR: Unknown variable "eeze".
Fixes:
- http://autobuild.buildroot.org/results/4a840c54bad9748b5748738378a0352d02de1f7e
---
v2: rework BR2_PACKAGE_EFL_DRM
--- package/efl/Config.in | 19 +++++++++++++++---- package/efl/efl.mk | 7 +++++++ 2 files changed, 22 insertions(+), 4 deletions(-)
package/efl/Config.in +15 -4
@@ -85,6 +85,19 @@ config BR2_PACKAGE_EFL_LIBFRIBIDI so you may also trigger code paths with bugs that are never normally used. +config BR2_PACKAGE_EFL_LIBINPUT + bool "Enable libinput support (recommended)" + default y + depends on BR2_PACKAGE_HAS_UDEV # libinput + select BR2_PACKAGE_EFL_EEZE + select BR2_PACKAGE_LIBINPUT + select BR2_PACKAGE_LIBXKBCOMMON + help + Libinput is used to support gesture recognition. + +comment "libinput needs udev /dev management (eeze)" + depends on !BR2_PACKAGE_HAS_UDEV + config BR2_PACKAGE_EFL_LIBSNDFILE bool "Enable libsndfile support (recommended)" default y
@@ -216,13 +229,11 @@ endchoice # OpenGL support config BR2_PACKAGE_EFL_DRM bool "Evas DRM Engine" - depends on BR2_PACKAGE_HAS_UDEV (eeze) + depends on BR2_PACKAGE_HAS_UDEV # elput, eeze depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d - select BR2_PACKAGE_EFL_EEZE + select BR2_PACKAGE_EFL_LIBINPUT select BR2_PACKAGE_LIBDRM - select BR2_PACKAGE_LIBINPUT # For elput - select BR2_PACKAGE_LIBXKBCOMMON help This option enable building support for the Evas DRM Engine.
package/efl/efl.mk +7 -0
@@ -67,6 +67,13 @@ else EFL_CONF_OPTS += -Deeze=false endif +ifeq ($(BR2_PACKAGE_EFL_LIBINPUT),y) +EFL_DEPENDENCIES += libinput libxkbcommon +EFL_CONF_OPTS += -Dinput=true +else +EFL_CONF_OPTS += -Dinput=false +endif + ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y) EFL_DEPENDENCIES += util-linux EFL_CONF_OPTS += -Dlibmount=true
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 4/5] package/efl: handle input option
Hello,
package/efl/Config.in config BR2_PACKAGE_EFL_LIBFRIBIDI · line 91
Quoted 4 lines · On Sat, 29 Jan 2022 23:46:50 +0100 Romain Naour <[email protected]> wrote:
package/efl/Config.in +4
-0+config BR2_PACKAGE_EFL_LIBINPUT + bool "Enable libinput support (recommended)" + default y + depends on BR2_PACKAGE_HAS_UDEV # libinput
Should be:
depends on BR2_PACKAGE_HAS_UDEV # libinput, efl-eeze
Quoted 1 line
+comment "libinput needs udev /dev management (eeze)"
Drop "eeze" between parenthesis.
package/efl/Config.in endchoice # OpenGL support · line 232
Quoted 11 lines
package/efl/Config.in +3
-1+ depends on !BR2_PACKAGE_HAS_UDEV + config BR2_PACKAGE_EFL_LIBSNDFILE bool "Enable libsndfile support (recommended)" default y@@ -216,13 +229,11 @@ endchoice # OpenGL support config BR2_PACKAGE_EFL_DRM bool "Evas DRM Engine" - depends on BR2_PACKAGE_HAS_UDEV (eeze) + depends on BR2_PACKAGE_HAS_UDEV # elput, eeze
You fixed a bug from the previous commit here. What is "elput" ?
package/efl/Config.in endchoice # OpenGL support · line 235
Quoted 4 lines
package/efl/Config.in +1
-1depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d - select BR2_PACKAGE_EFL_EEZE + select BR2_PACKAGE_EFL_LIBINPUT
Is that the explanation for PATCH 3/5 ? But even that doesn't seem to justify PATCH 3/5: you could have done the same with a "depends on BR2_PACKAGE_EFL_EEZE".
Again: I agree with PATCH 3/5, and I think it's the right patch. I just don't understand the justification it has in its commit log.
package/efl/Config.in endchoice # OpenGL support · line 224
Quoted 2 lines
package/efl/Config.in +0
-1select BR2_PACKAGE_LIBDRM - select BR2_PACKAGE_LIBINPUT # For elput
What is "elput" ?
Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 5/5 docs/manual/adding-packages-directory.txt: reorder select/depends
In reply to Romain NaourFrom [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to understand when depends come first, followed by the selects."
Also, the Config.in example in the manual suggests to use this coding style [2]."
Use the correct coding style in the chapter "Choosing depends on or select" in the manual.
[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] https://nightly.buildroot.org/manual.html#_coding_style
--- docs/manual/adding-packages-directory.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
docs/manual/adding-packages-directory.txt +2 -2
@@ -196,13 +196,13 @@ config BR2_PACKAGE_E -------------------------- config BR2_PACKAGE_D bool "Package D" - select BR2_PACKAGE_B depends on BR2_PACKAGE_A + select BR2_PACKAGE_B config BR2_PACKAGE_E bool "Package E" - select BR2_PACKAGE_D depends on BR2_PACKAGE_A + select BR2_PACKAGE_D -------------------------- Overall, for package library dependencies, +select+ should be
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 5/5] docs/manual/adding-packages-directory.txt: reorder select/depends
Quoted 11 lines · On Sat, 29 Jan 2022 23:46:51 +0100 Romain Naour <[email protected]> wrote:
From [1]:
"Even though the ordering has absolutely no consequences inKconfig, it
is not logical (when reading). It is more logical and far easier to understand when depends come first, followed by the selects."Also, the Config.in example in the manual suggests to use this coding style [2]."
Use the correct coding style in the chapter "Choosing depends on or select" in the manual.
Quoted 7 lines
[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] https://nightly.buildroot.org/manual.html#_coding_styleSigned-off-by Romain Naour <[email protected]>--- docs/manual/adding-packages-directory.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedQuoted 9 lines · On Sat, 29 Jan 2022 23:46:47 +0100 Romain Naour <[email protected]> wrote:
This is a bug-fix release.
See: https://www.enlightenment.org/news/2022-01-03-efl-1.26.1
Signed-off-by Romain Naour <[email protected]>--- package/efl/efl.hash | 4 ++-- package/efl/efl.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot