Skip to contentSkip to conversation

acpi: require CRC32 to build

PATCH Applied Randy Dunlap 3 participants 3 messages Jan 30, 2022 – Jan 31, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acpi: require CRC32 to build

ACPI core now requires crc32() but the kernel build can fail when CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.

Fixes this build error:

ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'

Fixes 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
Cc Rafael J. Wysocki <[email protected]>
Cc Heikki Krogerus <[email protected]>
Cc Linus Torvalds <[email protected]>
---
 drivers/acpi/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/acpi/Kconfig +1 -0
@@ -11,6 +11,7 @@ menuconfig ACPI
 	depends on ARCH_SUPPORTS_ACPI
 	select PNP
 	select NLS
+	select CRC32
 	default y if X86
 	help
 	  Advanced Configuration and Power Interface (ACPI) support for 
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines · Randy Dunlap

ACPI core now requires crc32() but the kernel build can fail when CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.

Fixes this build error:

ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'

Quoted 6 lines
Fixes 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
Cc Rafael J. Wysocki <[email protected]>
Cc Heikki Krogerus <[email protected]>
Cc Linus Torvalds <[email protected]>
Quoted 14 lines
---
  drivers/acpi/Kconfig |    1 +
  1 file changed, 1 insertion(+)
drivers/acpi/Kconfig +1 -0
@@ -11,6 +11,7 @@ menuconfig ACPI
  	depends on ARCH_SUPPORTS_ACPI
  	select PNP
  	select NLS
+	select CRC32
  	default y if X86
  	help
  	  Advanced Configuration and Power Interface (ACPI) support for
#2 lore raw
Quoted 16 lines · Guenter Roeck
Quoted 8 lines · Randy Dunlap

ACPI core now requires crc32() but the kernel build can fail when CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.

Fixes this build error:

ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'

Quoted 6 lines
Fixes 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
Cc Rafael J. Wysocki <[email protected]>
Cc Heikki Krogerus <[email protected]>
Cc Linus Torvalds <[email protected]>
Quoted 3 lines

Applied as 5.17-rc material, thanks!

Quoted 15 lines
Quoted 14 lines

---
  drivers/acpi/Kconfig |    1 +

  1 file changed, 1 insertion(+)
drivers/acpi/Kconfig +0 -0
@@ -11,6 +11,7 @@ menuconfig ACPI

      depends on ARCH_SUPPORTS_ACPI
      select PNP
      select NLS
+    select CRC32
      default y if X86
      help
        Advanced Configuration and Power Interface (ACPI) support for