crypto: sl3516: remove redundant initializations of pointers in_sg and out_sg
Subsystems (4)
PATCH 1/1 crypto: sl3516: remove redundant initializations of pointers in_sg and out_sg
Pointers in_sg and out_sg are being initialized with values that are never read, they are being re-assigned the same values later on. The initializations are redundant, remove them in preference to the later assignments that are closer to when the pointers are being used.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/crypto/gemini/sl3516-ce-cipher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/gemini/sl3516-ce-cipher.c +2 -2
@@ -23,8 +23,8 @@ static bool sl3516_ce_need_fallback(struct skcipher_request *areq)struct crypto_skcipher *tfm =crypto_skcipher_reqtfm (areq);struct sl3516_ce_cipher_tfm_ctx *op =crypto_skcipher_ctx (tfm);struct sl3516_ce_dev *ce = op->ce; -struct scatterlist *in_sg = areq->src; -struct scatterlist *out_sg = areq->dst; +struct scatterlist *in_sg; +struct scatterlist *out_sg;struct scatterlist *sg;if (areq->cryptlen ==0 || areq->cryptlen %16 ) {
Signature · 1 line
2.34.1
Herbert Xu
maintainerQuoted 9 lines · Colin Ian King
Pointers
in_sgandout_sgare being initialized with values that are never read, they are being re-assigned the same values later on. The initializations are redundant, remove them in preference to the later assignments that are closer to when the pointers are being used.Signed-off-by Colin Ian King <[email protected]>--- drivers/crypto/gemini/sl3516-ce-cipher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt