Skip to contentSkip to conversation

block.h: remove outdated comment

PATCH Applied Emanuele Giuseppe Esposito 4 participants 4 messages Jan 31, 2022 – Feb 1, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block.h: remove outdated comment

The comment "disk I/O throttling" doesn't make any sense at all any more. It was added in commit 0563e191516 to describe bdrv_io_limits_enable()/disable(), which were removed in commit 97148076, so the comment is just a forgotten leftover.

---
 include/block/block.h | 1 -
 1 file changed, 1 deletion(-)
include/block/block.h +0 -1
index 9d4050220b..e1713ee306 100644
@@ -344,7 +344,6 @@ typedef unsigned int BdrvChildRole;
 char *bdrv_perm_names(uint64_t perm);
 uint64_t bdrv_qapi_perm_to_blk_perm(BlockPermission qapi_perm);
 
-/* disk I/O throttling */
 void bdrv_init(void);
 void bdrv_init_with_whitelist(void);
 bool bdrv_uses_whitelist(void);
Signature · 1 line
2.31.1
Reviewed-by Philippe Mathieu-Daudé on v1 1/1
#1 lore raw
Quoted 10 lines · Emanuele Giuseppe Esposito

The comment "disk I/O throttling" doesn't make any sense at all any more. It was added in commit 0563e191516 to describe bdrv_io_limits_enable()/disable(), which were removed in commit 97148076, so the comment is just a forgotten leftover.

---
  include/block/block.h | 1 -
  1 file changed, 1 deletion(-)
Applied
#2 lore raw
In reply to Emanuele Giuseppe Esposito
Quoted 10 lines · Emanuele Giuseppe Esposito

The comment "disk I/O throttling" doesn't make any sense at all any more. It was added in commit 0563e191516 to describe bdrv_io_limits_enable()/disable(), which were removed in commit 97148076, so the comment is just a forgotten leftover.

---
  include/block/block.h | 1 -
  1 file changed, 1 deletion(-)

Thanks, applied to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block

Applied
#3 lore raw
In reply to Emanuele Giuseppe Esposito

Am 31.01.2022 um 13:56 hat Emanuele Giuseppe Esposito geschrieben:

Quoted 7 lines

The comment "disk I/O throttling" doesn't make any sense at all any more. It was added in commit 0563e191516 to describe bdrv_io_limits_enable()/disable(), which were removed in commit 97148076, so the comment is just a forgotten leftover.

Thanks, applied to the block branch.

Kevin