Skip to contentSkip to conversation

scripts/dtc: Call pkg-config POSIXly correct

PATCH In review Thomas Bracht Laumann Jespersen 2 participants 3 messages Jan 31, 2022 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/dtc: Call pkg-config POSIXly correct

Running with POSIXLY_CORRECT=1 in the environment the scripts/dtc build fails, because pkg-config doesn't output anything when the flags come after the arguments.

Fixes f8d8b46cd20e ("scripts/dtc: use pkg-config to include <yaml.h> in non-standard path")

---
I'm aware that the full kernel doesn't build with POSIXLY_CORRECT set, but I asked around and was told just to submit a patch.

This is based on the v5.17-rc2 tag, not sure if that's the right tree to work from, I'll happily cherry-pick to another tree if desired.

 scripts/dtc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/dtc/Makefile +1 -1
index 95aaf7431bff..1cba78e1dce6 100644
@@ -29,7 +29,7 @@ dtc-objs	+= yamltree.o
 # To include <yaml.h> installed in a non-default path
 HOSTCFLAGS_yamltree.o := $(shell pkg-config --cflags yaml-0.1)
 # To link libyaml installed in a non-default path
-HOSTLDLIBS_dtc	:= $(shell pkg-config yaml-0.1 --libs)
+HOSTLDLIBS_dtc	:= $(shell pkg-config --libs yaml-0.1)
 endif
 
 # Generated files need one more search path to include headers in source tree
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Thomas Bracht Laumann Jespersen

Running with POSIXLY_CORRECT=1 in the environment the scripts/dtc build fails, because pkg-config doesn't output anything when the flags come after the arguments.

Fixes f8d8b46cd20e ("scripts/dtc: use pkg-config to include <yaml.h> in non-standard path")

It's actually 067c650c456e ("dtc: Use pkg-config to locate libyaml") that you are fixing.

I can fix when applying.

Rob

#2 lore raw
Quoted 4 lines

It's actually 067c650c456e ("dtc: Use pkg-config to locate libyaml") that you are fixing.

I can fix when applying.

You are correct, my bad! Thanks.

-- Thomas