Skip to contentSkip to conversation

drm/amdgpu/display: remove statement with no effect

PATCH In review Alex Deucher 2 participants 2 messages Jan 31, 2022

Subsystems (3)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/display: remove statement with no effect

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c: In function ‘dcn10_link_encoder_dp_set_lane_settings’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:1123:49: warning: statement with no effect [-Wunused-value]

 1123 |                                                 LINK_RATE_REF_FREQ_IN_KHZ;
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
Fixes f2581998d9eb5e ("drm/amd/display: add set dp lane settings to link_hwss")
---
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c +0 -1
index 779110a2d948..ca39361f71c8 100644
@@ -1120,7 +1120,6 @@ void dcn10_link_encoder_dp_set_lane_settings(
 	cntl.lanes_number = link_settings->lane_count;
 	cntl.hpd_sel = enc10->base.hpd_source;
 	cntl.pixel_clock = link_settings->link_rate * LINK_RATE_REF_FREQ_IN_KHZ;
-						LINK_RATE_REF_FREQ_IN_KHZ;
 
 	for (lane = 0; lane < link_settings->lane_count; lane++) {
 		/* translate lane settings */
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Alex Deucher

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c: In function ‘dcn10_link_encoder_dp_set_lane_settings’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:1123:49: warning: statement with no effect [-Wunused-value]

 1123 |                                                 LINK_RATE_REF_FREQ_IN_KHZ;
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
Fixes f2581998d9eb5e ("drm/amd/display: add set dp lane settings to link_hwss")

Harry

Quoted 16 lines
---
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c +0 -1
index 779110a2d948..ca39361f71c8 100644
@@ -1120,7 +1120,6 @@ void dcn10_link_encoder_dp_set_lane_settings(
 	cntl.lanes_number = link_settings->lane_count;
 	cntl.hpd_sel = enc10->base.hpd_source;
 	cntl.pixel_clock = link_settings->link_rate * LINK_RATE_REF_FREQ_IN_KHZ;
-						LINK_RATE_REF_FREQ_IN_KHZ;
 
 	for (lane = 0; lane < link_settings->lane_count; lane++) {
 		/* translate lane settings */