mm/page_alloc: Don't pass pfn to free_unref_page_commit()
Subsystems (2)
PATCH 1/1 mm/page_alloc: Don't pass pfn to free_unref_page_commit()
free_unref_page_commit() doesn't make use of its pfn argument, so get rid of it.
Signed-off-by Nicolas Saenz Julienne <[email protected]>
Reviewed-by Vlastimil Babka <[email protected]>
---
NOTE:
This first appeared here, where Vlastimil gave his Reviewed-by:
https://lore.kernel.org/lkml/[email protected]/
The rest of the series was discarded, but this patch has value on its own.
mm/page_alloc.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-)
mm/page_alloc.c +6 -11
@@ -3422,8 +3422,8 @@ static int nr_pcp_high(struct per_cpu_pages *pcp, struct zone *zone)return min (READ_ONCE (pcp->batch) <<2 , high); } -static void free_unref_page_commit (struct page *page,unsigned long pfn, -int migratetype,unsigned int order) +static void free_unref_page_commit (struct page *page,int migratetype, +unsigned int order) {struct zone *zone =page_zone (page);struct per_cpu_pages *pcp;
@@ -3472,7 +3472,7 @@ void free_unref_page(struct page *page, unsigned int order) }local_lock_irqsave (&pagesets.lock, flags); -free_unref_page_commit (page, pfn, migratetype, order); +free_unref_page_commit (page, migratetype, order);local_unlock_irqrestore (&pagesets.lock, flags); }
@@ -3482,13 +3482,13 @@ void free_unref_page(struct page *page, unsigned int order)void free_unref_page_list (struct list_head *list) {struct page *page, *next; -unsigned long flags, pfn; +unsigned long flags;int batch_count =0 ;int migratetype;/* Prepare pages for freeing */ list_for_each_entry_safe (page, next, list, lru) { - pfn =page_to_pfn (page); +unsigned long pfn =page_to_pfn (page);if (!free_unref_page_prepare (page, pfn,0 )) {list_del (&page->lru);continue ;
@@ -3504,15 +3504,10 @@ void free_unref_page_list(struct list_head *list)free_one_page (page_zone (page), page, pfn,0 , migratetype,FPI_NONE );continue ; } - -set_page_private (page, pfn); }local_lock_irqsave (&pagesets.lock, flags);list_for_each_entry_safe (page, next, list, lru) { - pfn =page_private (page); -set_page_private (page,0 ); -/* * Non-isolated types over MIGRATE_PCPTYPES get added * to the MIGRATE_MOVABLE pcp list.
@@ -3522,7 +3517,7 @@ void free_unref_page_list(struct list_head *list) migratetype =MIGRATE_MOVABLE ;trace_mm_page_free_batched (page); -free_unref_page_commit (page, pfn, migratetype,0 ); +free_unref_page_commit (page, migratetype,0 );/* * Guard against excessive IRQ disabled times when we get
Signature · 1 line
2.34.1
Quoted 5 lines · Nicolas Saenz Julienne
free_unref_page_commit()doesn't make use of its pfn argument, so get rid of it.Signed-off-by Nicolas Saenz Julienne <[email protected]>Reviewed-by Vlastimil Babka <[email protected]>
Reviewed-by Matthew Wilcox (Oracle) <[email protected]>