Skip to contentSkip to conversation

media: i2c: Fix pixel array positions in ov8865

PATCH Superseded Daniel Scally 1 participant 2 messages Feb 3, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: i2c: Fix pixel array positions in ov8865

The ov8865's datasheet gives the pixel array as 3296x2528, and the active portion as the centre 3264x2448. This makes for a top offset of 40 and a left offset of 16, not 32 and 80.

Fixes acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")
---
 drivers/media/i2c/ov8865.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/i2c/ov8865.c +2 -2
index d9d016cfa9ac..53e21ae8e886 100644
@@ -457,8 +457,8 @@
 
 #define OV8865_NATIVE_WIDTH			3296
 #define OV8865_NATIVE_HEIGHT			2528
-#define OV8865_ACTIVE_START_TOP			32
-#define OV8865_ACTIVE_START_LEFT		80
+#define OV8865_ACTIVE_START_TOP			40
+#define OV8865_ACTIVE_START_LEFT		16
 #define OV8865_ACTIVE_WIDTH			3264
 #define OV8865_ACTIVE_HEIGHT			2448
 
Signature · 1 line
2.25.1
#1 lore raw

Sorry all, missed media...let me resend this.

Quoted 27 lines · Daniel Scally

The ov8865's datasheet gives the pixel array as 3296x2528, and the active portion as the centre 3264x2448. This makes for a top offset of 40 and a left offset of 16, not 32 and 80.

Fixes acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")
---
 drivers/media/i2c/ov8865.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/i2c/ov8865.c +2 -2
index d9d016cfa9ac..53e21ae8e886 100644
@@ -457,8 +457,8 @@
 
 #define OV8865_NATIVE_WIDTH			3296
 #define OV8865_NATIVE_HEIGHT			2528
-#define OV8865_ACTIVE_START_TOP			32
-#define OV8865_ACTIVE_START_LEFT		80
+#define OV8865_ACTIVE_START_TOP			40
+#define OV8865_ACTIVE_START_LEFT		16
 #define OV8865_ACTIVE_WIDTH			3264
 #define OV8865_ACTIVE_HEIGHT			2448