Skip to contentSkip to conversation

RDMA/ucma: RDMA/ucma: fix a kernel-infoleak in ucma_init_qp_attr()

PATCH In review Dan Carpenter 2 participants 3 messages Feb 4, 2022 – Feb 5, 2022 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 RDMA/ucma: RDMA/ucma: fix a kernel-infoleak in ucma_init_qp_attr()

From: Haimin Zhang <[email protected]>

The ib_copy_ah_attr_to_user() function only initializes "resp.grh" if the "resp.is_global" flag is set. Unfortunately, this data is copied to the user and copying uninitialized stack data to the user is an information leak. Zero out the whole "resp" struct to be safe.

As a clean up, zero out both "resp" and "qp_attr" in the initializers.

[ This patch has been highly edited from the original that Haimin Zhang
sent, so if there are any complaints please blame Dan Carpenter and Leon Romanovsky ]

Fixes 4ba66093bdc6 ("IB/core: Check for global flag when using ah_attr")

---
v2: Style changes

 drivers/infiniband/core/ucma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/infiniband/core/ucma.c +2 -4
index 9d6ac9dff39a..4b90ee14b015 100644
@@ -1214,9 +1214,9 @@ static ssize_t ucma_init_qp_attr(struct ucma_file *file,
 				 int in_len, int out_len)
 {
 	struct rdma_ucm_init_qp_attr cmd;
-	struct ib_uverbs_qp_attr resp;
+	struct ib_uverbs_qp_attr resp = {};
 	struct ucma_context *ctx;
-	struct ib_qp_attr qp_attr;
+	struct ib_qp_attr qp_attr = {};
 	int ret;
 
 	if (out_len < sizeof(resp))
@@ -1232,8 +1232,6 @@ static ssize_t ucma_init_qp_attr(struct ucma_file *file,
 	if (IS_ERR(ctx))
 		return PTR_ERR(ctx);
 
-	resp.qp_attr_mask = 0;
-	memset(&qp_attr, 0, sizeof qp_attr);
 	qp_attr.qp_state = cmd.qp_state;
 	mutex_lock(&ctx->mutex);
 	ret = rdma_init_qp_attr(ctx->cm_id, &qp_attr, &resp.qp_attr_mask);
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 6 lines · Dan Carpenter

From: Haimin Zhang <[email protected]>

The ib_copy_ah_attr_to_user() function only initializes "resp.grh" if the "resp.is_global" flag is set. Unfortunately, this data is copied to the user and copying uninitialized stack data to the user is an information leak. Zero out the whole "resp" struct to be safe.

Hasn't this already been fixed, and more comprehensively too?

commit b35a0f4dd544eaa6162b6d2f13a2557a121ae5fd

Author: Leon Romanovsky <[email protected]>
Date:   Tue Jan 4 14:21:52 2022 +0200

RDMA/core: Don't infoleak GRH fields

If dst->is_global field is not set, the GRH fields are not cleared and the following infoleak is reported.

Jason

#2 lore raw
Quoted 14 lines · Jason Gunthorpe
Quoted 6 lines · Dan Carpenter

From: Haimin Zhang <[email protected]>

The ib_copy_ah_attr_to_user() function only initializes "resp.grh" if the "resp.is_global" flag is set. Unfortunately, this data is copied to the user and copying uninitialized stack data to the user is an information leak. Zero out the whole "resp" struct to be safe.

Hasn't this already been fixed, and more comprehensively too?

commit b35a0f4dd544eaa6162b6d2f13a2557a121ae5fd

Author: Leon Romanovsky <[email protected]>
Date:   Tue Jan 4 14:21:52 2022 +0200
Quoted 6 lines

RDMA/core: Don't infoleak GRH fields

If dst->is_global field is not set, the GRH fields are not cleared and the following infoleak is reported.

Jason

That does fix the bug. It's unfortunate that Haimin Zhang doesn't get the reported by tag on this. That was my screw up. Sorry.

regards,
dan carpenter