Skip to contentSkip to conversation

Add warning for nesting dma_fence containers

PATCH In review Christian König 4 participants 17 messages Feb 4, 2022 – Feb 9, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

Hi everyone,

Since some operations can then lead to recursive handling nesting dma_fence containers into each other is only allowed under some restrictions.

dma_fence_array containers can be attached to dma_fence_chain containers and dma_fence_chain containers by chaining them together.

In all other cases the individual fences should be extracted with the appropriate iterators and added to the new containers individually.

I've separated the i915 cleanup from this change since it is generally a different functionality and the build bots complained about some issues with those patches.

Most patches are already reviewd, but especially the first one still needs an rb tag.

Please review and comment,
Christian.

#1 lore raw

PATCH 1/6 dma-buf: consolidate dma_fence subclass checking

Consolidate the wrapper functions to check for dma_fence subclasses in the dma_fence header.

This makes it easier to document and also check the different requirements for fence containers in the subclasses.

---
 include/linux/dma-fence-array.h | 15 +------------
 include/linux/dma-fence-chain.h |  3 +--
 include/linux/dma-fence.h       | 38 +++++++++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 16 deletions(-)
include/linux/dma-fence-array.h +1 -14
index 303dd712220f..fec374f69e12 100644
@@ -45,19 +45,6 @@ struct dma_fence_array {
 	struct irq_work work;
 };
 
-extern const struct dma_fence_ops dma_fence_array_ops;
-
-/**
- * dma_fence_is_array - check if a fence is from the array subsclass
- * @fence: fence to test
- *
- * Return true if it is a dma_fence_array and false otherwise.
- */
-static inline bool dma_fence_is_array(struct dma_fence *fence)
-{
-	return fence->ops == &dma_fence_array_ops;
-}
-
 /**
  * to_dma_fence_array - cast a fence to a dma_fence_array
  * @fence: fence to cast to a dma_fence_array
@@ -68,7 +55,7 @@ static inline bool dma_fence_is_array(struct dma_fence *fence)
 static inline struct dma_fence_array *
 to_dma_fence_array(struct dma_fence *fence)
 {
-	if (fence->ops != &dma_fence_array_ops)
+	if (!fence || !dma_fence_is_array(fence))
 		return NULL;
 
 	return container_of(fence, struct dma_fence_array, base);
include/linux/dma-fence-chain.h +1 -2
index 54fe3443fd2c..ee906b659694 100644
@@ -49,7 +49,6 @@ struct dma_fence_chain {
 	spinlock_t lock;
 };
 
-extern const struct dma_fence_ops dma_fence_chain_ops;
 
 /**
  * to_dma_fence_chain - cast a fence to a dma_fence_chain
@@ -61,7 +60,7 @@ extern const struct dma_fence_ops dma_fence_chain_ops;
 static inline struct dma_fence_chain *
 to_dma_fence_chain(struct dma_fence *fence)
 {
-	if (!fence || fence->ops != &dma_fence_chain_ops)
+	if (!fence || !dma_fence_is_chain(fence))
 		return NULL;
 
 	return container_of(fence, struct dma_fence_chain, base);
include/linux/dma-fence.h +38 -0
index 1ea691753bd3..775cdc0b4f24 100644
@@ -587,4 +587,42 @@ struct dma_fence *dma_fence_get_stub(void);
 struct dma_fence *dma_fence_allocate_private_stub(void);
 u64 dma_fence_context_alloc(unsigned num);
 
+extern const struct dma_fence_ops dma_fence_array_ops;
+extern const struct dma_fence_ops dma_fence_chain_ops;
+
+/**
+ * dma_fence_is_array - check if a fence is from the array subclass
+ * @fence: the fence to test
+ *
+ * Return true if it is a dma_fence_array and false otherwise.
+ */
+static inline bool dma_fence_is_array(struct dma_fence *fence)
+{
+	return fence->ops == &dma_fence_array_ops;
+}
+
+/**
+ * dma_fence_is_chain - check if a fence is from the chain subclass
+ * @fence: the fence to test
+ *
+ * Return true if it is a dma_fence_chain and false otherwise.
+ */
+static inline bool dma_fence_is_chain(struct dma_fence *fence)
+{
+	return fence->ops == &dma_fence_chain_ops;
+}
+
+/**
+ * dma_fence_is_container - check if a fence is a container for other fences
+ * @fence: the fence to test
+ *
+ * Return true if this fence is a container for other fences, false otherwise.
+ * This is important since we can't build up large fence structure or otherwise
+ * we run into recursion during operation on those fences.
+ */
+static inline bool dma_fence_is_container(struct dma_fence *fence)
+{
+	return dma_fence_is_array(fence) || dma_fence_is_chain(fence);
+}
+
 #endif /* __LINUX_DMA_FENCE_H */
Signature · 1 line
2.25.1
Reviewed-by on v1 1/6
#2 lore raw

Re: [PATCH 1/6] dma-buf: consolidate dma_fence subclass checking

Quoted 7 lines · Christian König

Consolidate the wrapper functions to check for dma_fence subclasses in the dma_fence header.

This makes it easier to document and also check the different requirements for fence containers in the subclasses.

I'd probably still opt for a fence ops is_container member, but won't insist.

Quoted 116 lines

---
 include/linux/dma-fence-array.h | 15 +------------ include/linux/dma-fence-chain.h |  3 +-- include/linux/dma-fence.h       | 38
+++++++++++++++++++++++++++++++++

 3 files changed, 40 insertions(+), 16 deletions(-)
include/linux/dma- renamed from include/linux/dma-fence-array.h +0 -0

fence-array.h
index 303dd712220f..fec374f69e12 100644

include/linux/dma-fence-array.h +0 -0
@@ -45,19 +45,6 @@ struct dma_fence_array {
         struct irq_work work;
  };

include/linux/dma-fence-array.h +0 -13
-extern const struct dma_fence_ops dma_fence_array_ops;
-
-/**
- * dma_fence_is_array - check if a fence is from the array subsclass
- * @fence: fence to test
- *
- * Return true if it is a dma_fence_array and false otherwise.
- */
-static inline bool dma_fence_is_array(struct dma_fence *fence)
-{
-       return fence->ops == &dma_fence_array_ops;
-}
-

 /**
  * to_dma_fence_array - cast a fence to a dma_fence_array
  * @fence: fence to cast to a dma_fence_array

include/linux/dma-fence-array.h +0 -0
@@ -68,7 +55,7 @@ static inline bool dma_fence_is_array(struct
 dma_fence *fence)

 static inline struct dma_fence_array * to_dma_fence_array(struct dma_fence *fence)
 {
-       if (fence->ops != &dma_fence_array_ops)
+       if (!fence || !dma_fence_is_array(fence)) return NULL;

        return container_of(fence, struct dma_fence_array, base);

include/linux/dma- renamed from include/linux/dma-fence-chain.h +0 -0

fence-chain.h
index 54fe3443fd2c..ee906b659694 100644

include/linux/dma-fence-chain.h +0 -0
@@ -49,7 +49,6 @@ struct dma_fence_chain {
         spinlock_t lock;
  };


-extern const struct dma_fence_ops dma_fence_chain_ops;
 /**
  * to_dma_fence_chain - cast a fence to a dma_fence_chain

include/linux/dma-fence-chain.h +0 -0
@@ -61,7 +60,7 @@ extern const struct dma_fence_ops
 dma_fence_chain_ops;

 static inline struct dma_fence_chain *
 to_dma_fence_chain(struct dma_fence *fence)
 {

-       if (!fence || fence->ops != &dma_fence_chain_ops)
+       if (!fence || !dma_fence_is_chain(fence))

                return NULL;

        return container_of(fence, struct dma_fence_chain, base);

include/linux/dma-fence.h +0 -0
index 1ea691753bd3..775cdc0b4f24 100644
@@ -587,4 +587,42 @@ struct dma_fence *dma_fence_get_stub(void);
  struct dma_fence *dma_fence_allocate_private_stub(void);
  u64 dma_fence_context_alloc(unsigned num);

include/linux/dma-fence.h +27 -0
+extern const struct dma_fence_ops dma_fence_array_ops;
+extern const struct dma_fence_ops dma_fence_chain_ops;
+
+/**
+ * dma_fence_is_array - check if a fence is from the array subclass
+ * @fence: the fence to test
+ *
+ * Return true if it is a dma_fence_array and false otherwise.
+ */
+static inline bool dma_fence_is_array(struct dma_fence *fence)
+{
+       return fence->ops == &dma_fence_array_ops;
+}
+
+/**
+ * dma_fence_is_chain - check if a fence is from the chain subclass
+ * @fence: the fence to test
+ *
+ * Return true if it is a dma_fence_chain and false otherwise.
+ */
+static inline bool dma_fence_is_chain(struct dma_fence *fence)
+{
+       return fence->ops == &dma_fence_chain_ops;
+}
+
+/**
+ * dma_fence_is_container - check if a fence is a container for

other fences
+ * @fence: the fence to test
+ *
+ * Return true if this fence is a container for other fences, false otherwise.
+ * This is important since we can't build up large fence structure or otherwise
+ * we run into recursion during operation on those fences.
+ */

include/linux/dma-fence.h +3 -0
+static inline bool dma_fence_is_container(struct dma_fence *fence)
+{
+       return dma_fence_is_array(fence) ||

dma_fence_is_chain(fence);

include/linux/dma-fence.h +2 -0
+}
+

 #endif /* __LINUX_DMA_FENCE_H */

#3 lore raw

PATCH 2/6 dma-buf: warn about dma_fence_array container rules v2

In reply to Christian König

It's not allowed to nest another dma_fence container into a dma_fence_array or otherwise we can run into recursion.

Warn about that when we create a dma_fence_array.

v2: fix comment style and typo in the warning pointed out by Thomas

---
 drivers/dma-buf/dma-fence-array.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/dma-buf/dma-fence-array.c +14 -0
index 3e07f961e2f3..cb1bacb5a42b 100644
@@ -176,6 +176,20 @@ struct dma_fence_array *dma_fence_array_create(int num_fences,
 
 	array->base.error = PENDING_ERROR;
 
+	/*
+	 * dma_fence_array objects should never contain any other fence
+	 * containers or otherwise we run into recursion and potential kernel
+	 * stack overflow on operations on the dma_fence_array.
+	 *
+	 * The correct way of handling this is to flatten out the array by the
+	 * caller instead.
+	 *
+	 * Enforce this here by checking that we don't create a dma_fence_array
+	 * with any container inside.
+	 */
+	while (num_fences--)
+		WARN_ON(dma_fence_is_container(fences[num_fences]));
+
 	return array;
 }
 EXPORT_SYMBOL(dma_fence_array_create);
Signature · 1 line
2.25.1
#4 lore raw

PATCH 3/6 dma-buf: Warn about dma_fence_chain container rules v2

In reply to Christian König

Chaining of dma_fence_chain objects is only allowed through the prev fence and not through the contained fence.

Warn about that when we create a dma_fence_chain.

v2: fix comment style

---
 drivers/dma-buf/dma-fence-chain.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/dma-buf/dma-fence-chain.c +9 -0
index 1b4cb3e5cec9..084c6927b735 100644
@@ -254,5 +254,14 @@ void dma_fence_chain_init(struct dma_fence_chain *chain,
 
 	dma_fence_init(&chain->base, &dma_fence_chain_ops,
 		       &chain->lock, context, seqno);
+
+	/*
+	 * Chaining dma_fence_chain container together is only allowed through
+	 * the prev fence and not through the contained fence.
+	 *
+	 * The correct way of handling this is to flatten out the fence
+	 * structure into a dma_fence_array by the caller instead.
+	 */
+	WARN_ON(dma_fence_is_chain(fence));
 }
 EXPORT_SYMBOL(dma_fence_chain_init);
Signature · 1 line
2.25.1
#5 lore raw

Re: [PATCH 3/6] dma-buf: Warn about dma_fence_chain container rules v2

Quoted 10 lines · Christian König

Chaining of dma_fence_chain objects is only allowed through the prev fence and not through the contained fence.

Warn about that when we create a dma_fence_chain.

v2: fix comment style

It looks like this blows up in generic drm code...

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22201/shard-skl10/igt@[email protected]

/Thomas

#6 lore raw

Re: [PATCH 3/6] dma-buf: Warn about dma_fence_chain container rules v2

Am 09.02.22 um 15:02 schrieb Thomas Hellström:

Quoted 6 lines · Christian König
Quoted 5 lines

Chaining of dma_fence_chain objects is only allowed through the prev fence and not through the contained fence.

Warn about that when we create a dma_fence_chain.

Quoted 8 lines
Quoted 5 lines

v2: fix comment style

It looks like this blows up in generic drm code...

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22201/shard-skl10/igt@[email protected]

Thanks for the notice.  Going to take a look.

I'm wondering why the last CI report I've got didn't showed that.

Christian.

Quoted 4 lines

/Thomas

#7 lore raw

PATCH 4/6 dma-buf: warn about containers in dma_resv object

In reply to Christian König

Drivers should not add containers as shared fences to the dma_resv object, instead each fence should be added individually.

---
 drivers/dma-buf/dma-resv.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/dma-buf/dma-resv.c +5 -0
index ee31f15d633a..b51416405e86 100644
@@ -256,6 +256,11 @@ void dma_resv_add_shared_fence(struct dma_resv *obj, struct dma_fence *fence)
 
 	dma_resv_assert_held(obj);
 
+	/* Drivers should not add containers here, instead add each fence
+	 * individually.
+	 */
+	WARN_ON(dma_fence_is_container(fence));
+
 	fobj = dma_resv_shared_list(obj);
 	count = fobj->shared_count;
 
Signature · 1 line
2.25.1
#8 lore raw

PATCH 5/6 dma-buf: add dma_fence_chain_contained helper

In reply to Christian König

It's a reoccurring pattern that we need to extract the fence from a dma_fence_chain object. Add a helper for this.

---
 drivers/dma-buf/dma-fence-chain.c |  6 ++----
 include/linux/dma-fence-chain.h   | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 4 deletions(-)
drivers/dma-buf/dma-fence-chain.c +2 -4
index 084c6927b735..06f8ef97c6e8 100644
@@ -148,8 +148,7 @@ static bool dma_fence_chain_enable_signaling(struct dma_fence *fence)
 
 	dma_fence_get(&head->base);
 	dma_fence_chain_for_each(fence, &head->base) {
-		struct dma_fence_chain *chain = to_dma_fence_chain(fence);
-		struct dma_fence *f = chain ? chain->fence : fence;
+		struct dma_fence *f = dma_fence_chain_contained(fence);
 
 		dma_fence_get(f);
 		if (!dma_fence_add_callback(f, &head->cb, dma_fence_chain_cb)) {
@@ -165,8 +164,7 @@ static bool dma_fence_chain_enable_signaling(struct dma_fence *fence)
 static bool dma_fence_chain_signaled(struct dma_fence *fence)
 {
 	dma_fence_chain_for_each(fence, fence) {
-		struct dma_fence_chain *chain = to_dma_fence_chain(fence);
-		struct dma_fence *f = chain ? chain->fence : fence;
+		struct dma_fence *f = dma_fence_chain_contained(fence);
 
 		if (!dma_fence_is_signaled(f)) {
 			dma_fence_put(fence);
include/linux/dma-fence-chain.h +15 -0
index ee906b659694..10d51bcdf7b7 100644
@@ -66,6 +66,21 @@ to_dma_fence_chain(struct dma_fence *fence)
 	return container_of(fence, struct dma_fence_chain, base);
 }
 
+/**
+ * dma_fence_chain_contained - return the contained fence
+ * @fence: the fence to test
+ *
+ * If the fence is a dma_fence_chain the function returns the fence contained
+ * inside the chain object, otherwise it returns the fence itself.
+ */
+static inline struct dma_fence *
+dma_fence_chain_contained(struct dma_fence *fence)
+{
+	struct dma_fence_chain *chain = to_dma_fence_chain(fence);
+
+	return chain ? chain->fence : fence;
+}
+
 /**
  * dma_fence_chain_alloc
  *
Signature · 1 line
2.25.1
Reviewed-by on v1 5/6
#9 lore raw

Re: [PATCH 5/6] dma-buf: add dma_fence_chain_contained helper

Quoted 4 lines · Christian König

It's a reoccurring pattern that we need to extract the fence from a dma_fence_chain object. Add a helper for this.

I thought I'd reviewed this one already, but in case I didn't

Quoted 65 lines

---
 drivers/dma-buf/dma-fence-chain.c |  6 ++---- include/linux/dma-fence-chain.h   | 15 +++++++++++++++

 2 files changed, 17 insertions(+), 4 deletions(-)
drivers/dma-buf/dma- renamed from drivers/dma-buf/dma-fence-chain.c +0 -0

fence-chain.c
index 084c6927b735..06f8ef97c6e8 100644

drivers/dma-buf/dma-fence-chain.c +0 -0
@@ -148,8 +148,7 @@ static bool
 dma_fence_chain_enable_signaling(struct dma_fence *fence)


        dma_fence_get(&head->base); dma_fence_chain_for_each(fence, &head->base) {
-               struct dma_fence_chain *chain = to_dma_fence_chain(fence);
-               struct dma_fence *f = chain ? chain->fence : fence; +               struct dma_fence *f = dma_fence_chain_contained(fence);

                dma_fence_get(f);
                if (!dma_fence_add_callback(f, &head->cb, dma_fence_chain_cb)) {

drivers/dma-buf/dma-fence-chain.c +1 -2
@@ -165,8 +164,7 @@ static bool
 dma_fence_chain_enable_signaling(struct dma_fence *fence)
  static bool dma_fence_chain_signaled(struct dma_fence *fence)
  {
         dma_fence_chain_for_each(fence, fence) {
-               struct dma_fence_chain *chain =
 to_dma_fence_chain(fence);
-               struct dma_fence *f = chain ? chain->fence : fence;
+               struct dma_fence *f =
 dma_fence_chain_contained(fence);


                if (!dma_fence_is_signaled(f)) {
                        dma_fence_put(fence);

include/linux/dma- renamed from include/linux/dma-fence-chain.h +0 -0

fence-chain.h
index ee906b659694..10d51bcdf7b7 100644

include/linux/dma-fence-chain.h +0 -0
@@ -66,6 +66,21 @@ to_dma_fence_chain(struct dma_fence *fence)
         return container_of(fence, struct dma_fence_chain, base);
  }


+/**
+ * dma_fence_chain_contained - return the contained fence
+ * @fence: the fence to test
+ *
+ * If the fence is a dma_fence_chain the function returns the fence contained
+ * inside the chain object, otherwise it returns the fence itself.
+ */

include/linux/dma-fence-chain.h +8 -0
+static inline struct dma_fence *
+dma_fence_chain_contained(struct dma_fence *fence)
+{
+       struct dma_fence_chain *chain = to_dma_fence_chain(fence);
+
+       return chain ? chain->fence : fence;
+}
+

 /**
  * dma_fence_chain_alloc
  *

#10 lore raw

PATCH 6/6 drm/amdgpu: use dma_fence_chain_contained

In reply to Christian König

Instead of manually extracting the fence.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c +2 -3
index f7d8487799b2..40e06745fae9 100644
@@ -261,10 +261,9 @@ int amdgpu_sync_resv(struct amdgpu_device *adev, struct amdgpu_sync *sync,
 
 	dma_resv_for_each_fence(&cursor, resv, true, f) {
 		dma_fence_chain_for_each(f, f) {
-			struct dma_fence_chain *chain = to_dma_fence_chain(f);
+			struct dma_fence *tmp = dma_fence_chain_contained(f);
 
-			if (amdgpu_sync_test_fence(adev, mode, owner, chain ?
-						   chain->fence : f)) {
+			if (amdgpu_sync_test_fence(adev, mode, owner, tmp)) {
 				r = amdgpu_sync_fence(sync, f);
 				dma_fence_put(f);
 				if (r)
Signature · 1 line
2.25.1
Reviewed-by on v1 6/6
#11 lore raw

Re: [PATCH 6/6] drm/amdgpu: use dma_fence_chain_contained

Quoted 4 lines · Christian König

Instead of manually extracting the fence.

Quoted 24 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c +2 -4
index f7d8487799b2..40e06745fae9 100644
@@ -261,10 +261,9 @@ int amdgpu_sync_resv(struct amdgpu_device *adev, struct amdgpu_sync *sync,
 
        dma_resv_for_each_fence(&cursor, resv, true, f) {
                dma_fence_chain_for_each(f, f) {
-                       struct dma_fence_chain *chain = to_dma_fence_chain(f);
+                       struct dma_fence *tmp = dma_fence_chain_contained(f);
 
-                       if (amdgpu_sync_test_fence(adev, mode, owner, chain ?
-                                                  chain->fence : f)) {
+                       if (amdgpu_sync_test_fence(adev, mode, owner, tmp)) {
                                r = amdgpu_sync_fence(sync, f);
                                dma_fence_put(f);
                                if (r)
--

2.25.1

#12 lore raw
In reply to Christian König
Quoted 13 lines · Christian König

Hi everyone,

Since some operations can then lead to recursive handling nesting dma_fence containers into each other is only allowed under some restrictions.

dma_fence_array containers can be attached to dma_fence_chain containers and dma_fence_chain containers by chaining them together.

In all other cases the individual fences should be extracted with the appropriate iterators and added to the new containers individually.

Quoted 8 lines

I've separated the i915 cleanup from this change since it is generally a different functionality and the build bots complained about some issues with those patches.

Most patches are already reviewd, but especially the first one still needs an rb tag.

Please review and comment,

I see you dropped the i915 patch (probably due to lack of reviews?), Got distracted with other things, but I'll see if I can resurrect that and get it reviewed and merged.

Thanks,
Thomas

Quoted 3 lines

Christian.

#13 lore raw

Am 04.02.22 um 11:40 schrieb Thomas Hellström:

Quoted 18 lines · Christian König
Quoted 17 lines

Hi everyone,

Since some operations can then lead to recursive handling nesting dma_fence containers into each other is only allowed under some restrictions.

dma_fence_array containers can be attached to dma_fence_chain containers and dma_fence_chain containers by chaining them together.

In all other cases the individual fences should be extracted with the appropriate iterators and added to the new containers individually.

I've separated the i915 cleanup from this change since it is generally a different functionality and the build bots complained about some issues with those patches.

Quoted 7 lines
Quoted 4 lines

Most patches are already reviewd, but especially the first one still needs an rb tag.

Please review and comment,

I see you dropped the i915 patch (probably due to lack of reviews?), Got distracted with other things, but I'll see if I can resurrect that and get it reviewed and merged.

I was about to send out the i915 patch when that one here is merged.

The CI systems yielded some strange error with that one and I wanted to double check what's that all about.

Regards,
Christian.

Quoted 9 lines

Thanks,
Thomas

Quoted 3 lines

Christian.

#14 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] dma-buf: consolidate dma_fence subclass checking

In reply to Christian König
== Series Details ==

== Series Details ==

Series: series starting with [1/6] dma-buf: consolidate dma_fence subclass checking
URL : https://patchwork.freedesktop.org/series/99700/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
45d3d4ee83aa dma-buf: consolidate dma_fence subclass checking
-:117: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <[email protected]>' != 'Signed-off-by: Christian König <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 84 lines checked
942f0dd6ef1f dma-buf: warn about dma_fence_array container rules v2
-:44: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <[email protected]>' != 'Signed-off-by: Christian König <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 20 lines checked
3bb498287ec8 dma-buf: Warn about dma_fence_chain container rules v2
-:38: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <[email protected]>' != 'Signed-off-by: Christian König <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
df4941cd23d4 dma-buf: warn about containers in dma_resv object
-:31: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <[email protected]>' != 'Signed-off-by: Christian König <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 11 lines checked
0dc0287ffbd9 dma-buf: add dma_fence_chain_contained helper
-:63: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <[email protected]>' != 'Signed-off-by: Christian König <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 39 lines checked
ecce7db0b390 drm/amdgpu: use dma_fence_chain_contained
-:29: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <[email protected]>' != 'Signed-off-by: Christian König <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 12 lines checked

#15 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] dma-buf: consolidate dma_fence subclass checking

In reply to Christian König
== Series Details ==

== Series Details ==

Series: series starting with [1/6] dma-buf: consolidate dma_fence subclass checking
URL : https://patchwork.freedesktop.org/series/99700/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
#16 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] dma-buf: consolidate dma_fence subclass checking

In reply to Christian König
== Series Details ==

== Series Details ==

Series: series starting with [1/6] dma-buf: consolidate dma_fence subclass checking
URL : https://patchwork.freedesktop.org/series/99700/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11189 -> Patchwork_22176
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_22176 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_22176, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/index.html

Participating hosts (47 -> 44)
------------------------------

Additional (3): fi-kbl-soraka fi-icl-u2 bat-adlp-4
Missing (6): fi-bxt-dsi fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus fi-skl-6600u

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_22176:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-rkl-guc/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-rkl-guc/igt@i915_selftest@[email protected]
- bat-dg1-6: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/bat-dg1-6/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-dg1-6/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@debugfs_test@read_all_entries:
- fi-apl-guc: [DMESG-WARN][5] ([i915#1610]) -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-apl-guc/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-apl-guc/igt@debugfs_test@read_all_entries.html

Known issues
------------

Here are the changes found in Patchwork_22176 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([fdo#109315]) +17 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@nop-compute0:
- fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +17 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-pnv-d510/igt@amdgpu/[email protected]

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-kbl-soraka/igt@gem_exec_fence@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#2190])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-kbl-soraka/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][11] ([i915#2190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- bat-adlp-4: NOTRUN -> [SKIP][12] ([i915#4613]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([i915#4613]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-kbl-soraka/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#3282])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@gem_tiled_pread_basic.html

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][16] ([i915#1886] / [i915#2291])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@kms_chamelium@dp-edid-read:
- fi-kbl-soraka: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +8 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-kbl-soraka/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][18] ([fdo#111827]) +8 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@vga-hpd-fast:
- bat-adlp-4: NOTRUN -> [SKIP][19] ([fdo#111827]) +8 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: NOTRUN -> [SKIP][20] ([fdo#109278]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-4: NOTRUN -> [SKIP][21] ([i915#4103]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][22] ([fdo#109285])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][23] ([fdo#109285])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#533])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-kbl-soraka/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-4: NOTRUN -> [SKIP][25] ([i915#3291] / [i915#3708]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][26] ([i915#3301] / [i915#3708])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-adlp-4/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][27] ([i915#3301])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-icl-u2/igt@[email protected]

* igt@runner@aborted:
- bat-dg1-6: NOTRUN -> [FAIL][28] ([i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/bat-dg1-6/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [FAIL][29] ([i915#2426] / [i915#4312])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-bdw-5557u/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [INCOMPLETE][30] ([i915#146]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][32] ([i915#2927] / [i915#4528]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-pnv-d510/igt@i915_selftest@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][34] ([i915#4269]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-cml-u2/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/fi-cml-u2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* Linux: CI_DRM_11189 -> Patchwork_22176

CI-20190529: 20190529
CI_DRM_11189: c0fc917bc92837300b1991d53b835c6876f465a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6339: 9cd99d763440ae75d9981ce4e361d3deb5edb4e4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22176: ecce7db0b3906d3ba38d90ca266840696be5da47 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ecce7db0b390 drm/amdgpu: use dma_fence_chain_contained 0dc0287ffbd9 dma-buf: add dma_fence_chain_contained helper df4941cd23d4 dma-buf: warn about containers in dma_resv object 3bb498287ec8 dma-buf: Warn about dma_fence_chain container rules v2 942f0dd6ef1f dma-buf: warn about dma_fence_array container rules v2 45d3d4ee83aa dma-buf: consolidate dma_fence subclass checking

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22176/index.html