Skip to contentSkip to conversation

btrfs: send: in case of IO error log inode

PATCH Superseded Dāvis Mosāns 2 participants 7 messages Feb 2, 2022 – Feb 8, 2022 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: send: in case of IO error log inode

Currently if we get IO error while doing send then we abort without logging information about which file caused issue.
So log inode to help with debugging.

---
 fs/btrfs/send.c | 1 +
 1 file changed, 1 insertion(+)
fs/btrfs/send.c +1 -0
index d8ccb62aa7d2..945d9c01d902 100644
@@ -5000,6 +5000,7 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
 			if (!PageUptodate(page)) {
 				unlock_page(page);
 				put_page(page);
+				btrfs_err(fs_info, "received IO error for inode=%llu", sctx->cur_ino);
 				ret = -EIO;
 				break;
 			}
Signature · 1 line
2.35.1
#1 lore raw
Quoted 3 lines · Dāvis Mosāns

Currently if we get IO error while doing send then we abort without logging information about which file caused issue.
So log inode to help with debugging.

The Signed-off-by tag is missing.

fs/btrfs/send.c static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len) · line 5003

Quoted 13 lines
---
 fs/btrfs/send.c | 1 +
 1 file changed, 1 insertion(+)
fs/btrfs/send.c +1 -0
index d8ccb62aa7d2..945d9c01d902 100644
@@ -5000,6 +5000,7 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
 			if (!PageUptodate(page)) {
 				unlock_page(page);
 				put_page(page);
+				btrfs_err(fs_info, "received IO error for inode=%llu", sctx->cur_ino);

A message here makes sense. I'd make it more explicit that it's for send (the word "received" is kind of confusing), the inode number is not unique identifier so the root id should be also printed, it's available from the sctx->send_root and maybe also the file offset (taken from the associated page by page_offset()).

#2 lore raw

piektd., 2022. g. 4. febr., plkst. 18:29 — lietotājs David Sterba (<[email protected]>) rakstīja:

Quoted 8 lines · Dāvis Mosāns
Quoted 3 lines

Currently if we get IO error while doing send then we abort without logging information about which file caused issue.
So log inode to help with debugging.

The Signed-off-by tag is missing.

Yeah I forgot.

Quoted 4 lines
Quoted 4 lines
---
 fs/btrfs/send.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

fs/btrfs/send.c static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len) · line 5003

Quoted 9 lines
fs/btrfs/send.c +1 -0
index d8ccb62aa7d2..945d9c01d902 100644
@@ -5000,6 +5000,7 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
                      if (!PageUptodate(page)) {
                              unlock_page(page);
                              put_page(page);
+                             btrfs_err(fs_info, "received IO error for inode=%llu", sctx->cur_ino);

A message here makes sense. I'd make it more explicit that it's for send (the word "received" is kind of confusing), the inode number is not unique identifier so the root id should be also printed, it's available from the sctx->send_root and maybe also the file offset (taken from the associated page by page_offset()).

Thanks! Will submit v2

#3 lore raw

PATCH v2 1/1 btrfs: send: in case of IO error log it

In reply to Dāvis Mosāns

Currently if we get IO error while doing send then we abort without logging information about which file caused issue.
So log it to help with debugging.

---
 fs/btrfs/send.c | 2 ++
 1 file changed, 2 insertions(+)
fs/btrfs/send.c +2 -0
index d8ccb62aa7d2..a1fd449a5ecc 100644
@@ -5000,6 +5000,8 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
 			if (!PageUptodate(page)) {
 				unlock_page(page);
 				put_page(page);
+				btrfs_err(fs_info, "send: IO error at offset=%llu for inode=%llu root=%llu",
+					page_offset(page), sctx->cur_ino, sctx->send_root->root_key.objectid);
 				ret = -EIO;
 				break;
 			}
Signature · 1 line
2.35.1
#4 lore raw

Re: [PATCH v2] btrfs: send: in case of IO error log it

fs/btrfs/send.c static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len) · line 5004

Quoted 10 lines
fs/btrfs/send.c +2 -0
index d8ccb62aa7d2..a1fd449a5ecc 100644
@@ -5000,6 +5000,8 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
                        if (!PageUptodate(page)) {
                                unlock_page(page);
                                put_page(page);
+                               btrfs_err(fs_info, "send: IO error at offset=%llu for inode=%llu root=%llu",
+                                       page_offset(page), sctx->cur_ino, sctx->send_root->root_key.objectid);

Thought more about this and I'm guessing using page after put_page is probably wrong but it did work fine. Submitted v3.

#5 lore raw

PATCH v3 1/1 btrfs: send: in case of IO error log it

In reply to Dāvis Mosāns

Currently if we get IO error while doing send then we abort without logging information about which file caused issue.
So log it to help with debugging.

---
 fs/btrfs/send.c | 2 ++
 1 file changed, 2 insertions(+)
fs/btrfs/send.c +2 -0
index d8ccb62aa7d2..b1f75fde4a19 100644
@@ -4999,6 +4999,8 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
 			lock_page(page);
 			if (!PageUptodate(page)) {
 				unlock_page(page);
+				btrfs_err(fs_info, "send: IO error at offset=%llu for inode=%llu root=%llu",
+					page_offset(page), sctx->cur_ino, sctx->send_root->root_key.objectid);
 				put_page(page);
 				ret = -EIO;
 				break;
Signature · 1 line
2.35.1
#6 lore raw

Re: [PATCH v3] btrfs: send: in case of IO error log it

Quoted 5 lines · Dāvis Mosāns

Currently if we get IO error while doing send then we abort without logging information about which file caused issue.
So log it to help with debugging.

Added to misc-next, thanks.

Quoted 9 lines
---
 fs/btrfs/send.c | 2 ++
 1 file changed, 2 insertions(+)
fs/btrfs/send.c +0 -0
index d8ccb62aa7d2..b1f75fde4a19 100644

fs/btrfs/send.c static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len) · line 5004

Quoted 6 lines
fs/btrfs/send.c +2 -0
@@ -4999,6 +4999,8 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
 			lock_page(page);
 			if (!PageUptodate(page)) {
 				unlock_page(page);
+				btrfs_err(fs_info, "send: IO error at offset=%llu for inode=%llu root=%llu",
+					page_offset(page), sctx->cur_ino, sctx->send_root->root_key.objectid);
 				put_page(page);

Good point in v2, using page must be before put_page. I've slightly reformatted the message so the lines fit to the limit.