Skip to contentSkip to conversation

clk: imx: select [SPL_]CLK_COMPOSITE_CCF for imxrt10{20|50}

PATCH In review Heiko Thiery 3 participants 6 messages Jan 30, 2022 – Feb 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 clk: imx: select [SPL_]CLK_COMPOSITE_CCF for imxrt10{20|50}

The clock composite is required when using the clock framework. So select it automatically.

---
 drivers/clk/imx/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
drivers/clk/imx/Kconfig +4 -0
index a2cd0347c3..cdd348020b 100644
@@ -76,6 +76,7 @@ config SPL_CLK_IMXRT1020
 	depends on ARCH_IMXRT && SPL
 	select SPL_CLK
 	select SPL_CLK_CCF
+	select SPL_CLK_COMPOSITE_CCF
 	help
 	  This enables SPL DM/DTS support for clock driver in i.MXRT1020
 
@@ -84,6 +85,7 @@ config CLK_IMXRT1020
 	depends on ARCH_IMXRT
 	select CLK
 	select CLK_CCF
+	select CLK_COMPOSITE_CCF
 	help
 	  This enables support clock driver for i.MXRT1020 platforms.
 
@@ -92,6 +94,7 @@ config SPL_CLK_IMXRT1050
 	depends on ARCH_IMXRT && SPL
 	select SPL_CLK
 	select SPL_CLK_CCF
+	select SPL_CLK_COMPOSITE_CCF
 	help
 	  This enables SPL DM/DTS support for clock driver in i.MXRT1050
 
@@ -100,5 +103,6 @@ config CLK_IMXRT1050
 	depends on ARCH_IMXRT
 	select CLK
 	select CLK_CCF
+	select CLK_COMPOSITE_CCF
 	help
 	  This enables support clock driver for i.MXRT1050 platforms.
Signature · 1 line
2.30.2
#1 lore raw

PATCH 2/2 configs/*imxrt10*: remove [SPL_]CLK_COMPOSITE_CCF

This option is selected implicitly when [SPL_]CLK_IMXRT10{20|50} is selected.

---
 configs/imxrt1020-evk_defconfig | 2 --
 configs/imxrt1050-evk_defconfig | 2 --
 2 files changed, 4 deletions(-)
configs/imxrt1020-evk_defconfig +0 -2
index 22cb5cbea7..dafa4a505a 100644
@@ -45,8 +45,6 @@ CONFIG_TFTP_BLOCKSIZE=512
 CONFIG_SPL_DM=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 # CONFIG_OF_TRANSLATE is not set
-CONFIG_SPL_CLK_COMPOSITE_CCF=y
-CONFIG_CLK_COMPOSITE_CCF=y
 CONFIG_SPL_CLK_IMXRT1020=y
 CONFIG_CLK_IMXRT1020=y
 # CONFIG_SPL_DM_GPIO is not set
configs/imxrt1050-evk_defconfig +0 -2
index 044b984f14..09dcc9e6e3 100644
@@ -49,8 +49,6 @@ CONFIG_TFTP_BLOCKSIZE=512
 CONFIG_SPL_DM=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 # CONFIG_OF_TRANSLATE is not set
-CONFIG_SPL_CLK_COMPOSITE_CCF=y
-CONFIG_CLK_COMPOSITE_CCF=y
 CONFIG_SPL_CLK_IMXRT1050=y
 CONFIG_CLK_IMXRT1050=y
 # CONFIG_SPL_DM_GPIO is not set
Signature · 1 line
2.30.2
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] configs/*imxrt10*: remove [SPL_]CLK_COMPOSITE_CCF

Hi Heiko,

Quoted 5 lines

Il giorno 30 gen 2022, alle ore 07:39, Heiko Thiery <[email protected]> ha scritto:

This option is selected implicitly when [SPL_]CLK_IMXRT10{20|50} is selected.

Thank you

Best regards
—-
Giulio Benetti
Benetti Engineering sas

Quoted 34 lines

---
configs/imxrt1020-evk_defconfig | 2 --
configs/imxrt1050-evk_defconfig | 2 --

2 files changed, 4 deletions(-)
configs/imxrt1020-evk_defconfig +0 -0
index 22cb5cbea7..dafa4a505a 100644
@@ -45,8 +45,6 @@ CONFIG_TFTP_BLOCKSIZE=512

CONFIG_SPL_DM=y
CONFIG_SPL_DM_SEQ_ALIAS=y
# CONFIG_OF_TRANSLATE is not set

configs/imxrt1020-evk_defconfig +0 -2
-CONFIG_SPL_CLK_COMPOSITE_CCF=y
-CONFIG_CLK_COMPOSITE_CCF=y

CONFIG_SPL_CLK_IMXRT1020=y
CONFIG_CLK_IMXRT1020=y
# CONFIG_SPL_DM_GPIO is not set

configs/imxrt1050-evk_defconfig +0 -0
index 044b984f14..09dcc9e6e3 100644
@@ -49,8 +49,6 @@ CONFIG_TFTP_BLOCKSIZE=512

CONFIG_SPL_DM=y
CONFIG_SPL_DM_SEQ_ALIAS=y
# CONFIG_OF_TRANSLATE is not set

configs/imxrt1050-evk_defconfig +0 -2
-CONFIG_SPL_CLK_COMPOSITE_CCF=y
-CONFIG_CLK_COMPOSITE_CCF=y

CONFIG_SPL_CLK_IMXRT1050=y
CONFIG_CLK_IMXRT1050=y
# CONFIG_SPL_DM_GPIO is not set

Signature · 1 line
2.30.2
#3 lore raw

PATCH 2/2 configs/*imxrt10*: remove [SPL_]CLK_COMPOSITE_CCF

In reply to Heiko Thiery
Quoted 3 lines

This option is selected implicitly when [SPL_]CLK_IMXRT10{20|50} is selected.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Reviewed-by on v1 1/2
#4 lore raw
In reply to Heiko Thiery

Hi Heiko,

Quoted 6 lines

Il giorno 30 gen 2022, alle ore 07:38, Heiko Thiery <[email protected]> ha scritto:

The clock composite is required when using the clock framework. So select it automatically.

Thank you

Best regards
—-
Giulio Benetti
Benetti Engineering sas

Quoted 42 lines

---
drivers/clk/imx/Kconfig | 4 ++++

1 file changed, 4 insertions(+)
drivers/clk/imx/Kconfig +4 -0
index a2cd0347c3..cdd348020b 100644
@@ -76,6 +76,7 @@ config SPL_CLK_IMXRT1020
   depends on ARCH_IMXRT && SPL
   select SPL_CLK
   select SPL_CLK_CCF
+    select SPL_CLK_COMPOSITE_CCF
   help
     This enables SPL DM/DTS support for clock driver in i.MXRT1020
 
@@ -84,6 +85,7 @@ config CLK_IMXRT1020
   depends on ARCH_IMXRT
   select CLK
   select CLK_CCF
+    select CLK_COMPOSITE_CCF
   help
     This enables support clock driver for i.MXRT1020 platforms.
 
@@ -92,6 +94,7 @@ config SPL_CLK_IMXRT1050
   depends on ARCH_IMXRT && SPL
   select SPL_CLK
   select SPL_CLK_CCF
+    select SPL_CLK_COMPOSITE_CCF
   help
     This enables SPL DM/DTS support for clock driver in i.MXRT1050
 
@@ -100,5 +103,6 @@ config CLK_IMXRT1050
   depends on ARCH_IMXRT
   select CLK
   select CLK_CCF
+    select CLK_COMPOSITE_CCF
   help
     This enables support clock driver for i.MXRT1050 platforms.
Signature · 1 line
2.30.2
#5 lore raw

PATCH 1/2 clk: imx: select [SPL_]CLK_COMPOSITE_CCF for imxrt10{20|50}

In reply to Heiko Thiery
Quoted 4 lines

The clock composite is required when using the clock framework. So select it automatically.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================