Skip to contentSkip to conversation

Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled

PATCH In review Marek Vasut 3 participants 3 messages Jan 1, 2022 – Feb 5, 2022 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled

Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates the flash.bin again and produces corrupted result.

---
 Makefile | 1 -
 1 file changed, 1 deletion(-)
Makefile +0 -1
index ae9bfab91ac..c04caaebc8e 100644
@@ -1517,7 +1517,6 @@ else
 ifeq ($(CONFIG_BINMAN),y)
 flash.bin: spl/u-boot-spl.bin $(INPUTS-y) FORCE
 	$(call if_changed,binman)
-	$(Q)$(MAKE) $(build)=arch/arm/mach-imx $@
 else
 flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE
 	$(Q)$(MAKE) $(build)=arch/arm/mach-imx $@
Signature · 1 line
2.34.1
#2 lore raw

PATCH 1/1 Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled

In reply to Marek Vasut
Quoted 7 lines

Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates the flash.bin again and produces corrupted result.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================