package/nfs-utils: nfsiostat used python3, not python2
PATCH 1/1 package/nfs-utils: nfsiostat used python3, not python2
nfsiostat is a python3 script, so keep it if python3 is enabled and not python2:
head -n 1 target/usr/sbin/nfsiostat
#!/usr/bin/python3
--- package/nfs-utils/nfs-utils.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/nfs-utils/nfs-utils.mk +1 -1
@@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT endef # nfsiostat is interpreted python, so remove it unless it's in the target -NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT) +NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT) define HOST_NFS_UTILS_BUILD_CMDS $(MAKE) -C $(@D)/tools/rpcgen
Signature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
s/used/uses/ in the subject naturally.
Quoted 26 lines
nfsiostat is a python3 script, so keep it if python3 is enabled and not python2:
head -n 1 target/usr/sbin/nfsiostat
#!/usr/bin/python3Signed-off-by Peter Korsgaard <[email protected]>--- package/nfs-utils/nfs-utils.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/nfs-utils/nfs-utils.mk +1
-1@@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT endef # nfsiostat is interpreted python, so remove it unless it's in the target -NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT) +NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT) define HOST_NFS_UTILS_BUILD_CMDS $(MAKE) -C $(@D)/tools/rpcgenSignature · 1 line
2.20.1
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Petr Vorel
Reviewed-byHi Peter,
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
s/used/uses/ in the subject naturally.
+1
Quoted 2 lines
Quoted 2 lines
nfsiostat is a python3 script, so keep it if python3 is enabled and not python2:
Good catch, thanks!
Kind regards,
Petr
Quoted 15 lines
Quoted 14 lines
head -n 1 target/usr/sbin/nfsiostat
#!/usr/bin/python3Signed-off-by Peter Korsgaard <[email protected]>--- package/nfs-utils/nfs-utils.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/nfs-utils/nfs-utils.mk +0
-0@@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT endef
Quoted 8 lines
Quoted 8 lines
package/nfs-utils/nfs-utils.mk +1
-1# nfsiostat is interpreted python, so remove it unless it's in the target -NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT) +NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT) define HOST_NFS_UTILS_BUILD_CMDS $(MAKE) -C $(@D)/tools/rpcgenSignature · 1 line
2.20.1
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Petr" == Petr Vorel <[email protected]> writes:
Hi Peter,
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
s/used/uses/ in the subject naturally.
Quoted 7 lines
+1
Quoted 2 lines
Quoted 2 lines
nfsiostat is a python3 script, so keep it if python3 is enabled and not python2:
Good catch, thanks!
Reviewed-by Petr Vorel <[email protected]>
Committed, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 12 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
"Peter" == Peter Korsgaard <[email protected]> writes:
"Peter" == Peter Korsgaard <[email protected]> writes:
s/used/uses/ in the subject naturally.
Quoted 7 lines
nfsiostat is a python3 script, so keep it if python3 is enabled and not python2:
head -n 1 target/usr/sbin/nfsiostat
#!/usr/bin/python3Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2021.02.x and 2021.11.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot