Skip to contentSkip to conversation

qla2xxx: fix error status checking in qla24xx_modify_vp_config()

PATCH New Dirk Müller 1 participant 1 message Feb 6, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 qla2xxx: fix error status checking in qla24xx_modify_vp_config()

The function was checking vpmod->comp_status and reported it as error status, which is however already checked a few lines below.

Guessing from other occurrences it was supposed to check entry_status instead.

Fixes 2c3dfe3f6ad8 ("[SCSI] qla2xxx: add support for NPIV")
---
 drivers/scsi/qla2xxx/qla_mbx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_mbx.c +2 -2
index 10d2655ef676..28fdd80e1e4d 100644
@@ -4253,10 +4253,10 @@ qla24xx_modify_vp_config(scsi_qla_host_t *vha)
 	if (rval != QLA_SUCCESS) {
 		ql_dbg(ql_dbg_mbx, vha, 0x10bd,
 		    "Failed to issue VP config IOCB (%x).\n", rval);
-	} else if (vpmod->comp_status != 0) {
+	} else if (vpmod->entry_status != 0) {
 		ql_dbg(ql_dbg_mbx, vha, 0x10be,
 		    "Failed to complete IOCB -- error status (%x).\n",
-		    vpmod->comp_status);
+		    vpmod->entry_status);
 		rval = QLA_FUNCTION_FAILED;
 	} else if (vpmod->comp_status != cpu_to_le16(CS_COMPLETE)) {
 		ql_dbg(ql_dbg_mbx, vha, 0x10bf,
Signature · 1 line
2.35.1