drm: mxsfb: Implement LCDIF scanout CRC32 support
Subsystems (4)
Marek Vasut
maintainerRFC PATCH 1/1 drm: mxsfb: Implement LCDIF scanout CRC32 support
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a CRC_STAT register, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is likely meant as a functional safety register.
Unfortunatelly, there is zero documentation on how the CRC32 is calculated, there is no documentation of the polynomial, the init value, nor on which data is the checksum applied.
By applying brute-force on 8 pixel / 2 line frame, which is the minimum size LCDIF would work with, it turns out the polynomial is CRC32_POLY_LE 0xedb88320 , init value is 0xffffffff , the input data are bitrev32() of the entire frame and the resulting CRC has to be also bitrev32()ed.
Doing this calculation in software for each frame is unrealistic due to the CPU demand, implement at least a sysfs attribute which permits testing the current frame on demand.
Unfortunatelly, this functionality has another problem. On all of those SoCs, it is possible to overload interconnect e.g. by concurrent USB and uSDHC transfers, at which point the LCDIF LFIFO suffers an UNDERFLOW condition, which results in the image being shifted to the right by exactly LFIFO size pixels. On i.MX8M Mini, the LFIFO is 76x256 bits = 2432 Byte ~= 810 pixel at 24bpp. In this case, the LCDIF does not assert UNDERFLOW_IRQ bit, the frame CRC32 indicated in CRC_STAT register matches the CRC32 of the frame in DRAM, the RECOVER_ON_UNDERFLOW bit has no effect, so if this mode of failure occurs, the failure gets undetected and uncorrected.
--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 38 ++++++++++++++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 3 +++ drivers/gpu/drm/mxsfb/mxsfb_kms.c | 11 +++++---- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 1 + 4 files changed, 49 insertions(+), 4 deletions(-)
drivers/gpu/drm/mxsfb/mxsfb_drv.c +38 -0
@@ -9,6 +9,7 @@*/ #include <linux/clk.h> +#include <linux/crc32.h> #include <linux/dma-mapping.h> #include <linux/io.h> #include <linux/module.h>
@@ -292,6 +293,37 @@ static void mxsfb_unload(struct drm_device *drm)pm_runtime_disable (drm->dev); } +static ssize_t mxsfb_frame_checksum_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct drm_device *drm =dev_get_drvdata (dev); +struct mxsfb_drm_private *mxsfb = drm->dev_private; +u32 hwcrc =readl (mxsfb->base,LCDC_V4_CRC_STAT ); +u32 swcrc =0xffffffff ; +int i; + +if (mxsfb->gem_vaddr) { +for (i =0 ; i < mxsfb->gem_size /4 ; i++) { +u32 data =bitrev32 (((u32 *)mxsfb->gem_vaddr)[i]); + swcrc =crc32 (swcrc, &data,4 ); + } + swcrc =bitrev32 (swcrc); + } + +return sysfs_emit (buf,"HW:%08x,SW:%08x,OK:%d\n" , hwcrc, swcrc, hwcrc == swcrc); +} +static DEVICE_ATTR(frame_checksum, 0444, mxsfb_frame_checksum_show, NULL); + +static struct attribute *mxsfb_attributes[] = { + &dev_attr_frame_checksum.attr, +NULL , +}; + +static const struct attribute_group mxsfb_attr_group = { + .attrs = mxsfb_attributes, +}; +DEFINE_DRM_GEM_CMA_FOPS (fops);static const struct drm_driver mxsfb_driver = {
@@ -335,10 +367,16 @@ static int mxsfb_probe(struct platform_device *pdev)if (ret) goto err_unload; + ret =devm_device_add_group (drm->dev, &mxsfb_attr_group); +if (ret) + goto err_attr; +drm_fbdev_generic_setup (drm,32 );return 0 ; +err_attr: +drm_dev_unregister (drm); err_unload:mxsfb_unload (drm); err_free:
drivers/gpu/drm/mxsfb/mxsfb_drv.h +3 -0
@@ -44,6 +44,9 @@ struct mxsfb_drm_private {struct drm_encoder encoder;struct drm_connector *connector;struct drm_bridge *bridge; + +void *gem_vaddr; +size_t gem_size; }; static inline struct mxsfb_drm_private *
drivers/gpu/drm/mxsfb/mxsfb_kms.c +7 -4
@@ -196,7 +196,7 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb)return clear_poll_bit (mxsfb->base +LCDC_CTRL ,CTRL_CLKGATE ); } -static dma_addr_t mxsfb_get_fb_paddr (struct drm_plane *plane) +static dma_addr_t mxsfb_get_fb_paddr (struct mxsfb_drm_private *mxsfb,struct drm_plane *plane) {struct drm_framebuffer *fb = plane->state->fb;struct drm_gem_cma_object *gem;
@@ -208,6 +208,9 @@ static dma_addr_t mxsfb_get_fb_paddr(struct drm_plane *plane)if (!gem)return 0 ; + mxsfb->gem_vaddr = gem->vaddr; + mxsfb->gem_size = gem->base.size; +return gem->paddr; }
@@ -370,7 +373,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,mxsfb_crtc_mode_set_nofb (mxsfb, bus_format);/* Write cur_buf as well to avoid an initial corrupt frame */ - paddr =mxsfb_get_fb_paddr (crtc->primary); + paddr =mxsfb_get_fb_paddr (mxsfb, crtc->primary);if (paddr) {writel (paddr, mxsfb->base + mxsfb->devdata->cur_buf);writel (paddr, mxsfb->base + mxsfb->devdata->next_buf);
@@ -476,7 +479,7 @@ static void mxsfb_plane_primary_atomic_update(struct drm_plane *plane,struct mxsfb_drm_private *mxsfb =to_mxsfb_drm_private (plane->dev);dma_addr_t paddr; - paddr =mxsfb_get_fb_paddr (plane); + paddr =mxsfb_get_fb_paddr (mxsfb, plane);if (paddr)writel (paddr, mxsfb->base + mxsfb->devdata->next_buf); }
@@ -492,7 +495,7 @@ static void mxsfb_plane_overlay_atomic_update(struct drm_plane *plane,dma_addr_t paddr;u32 ctrl; - paddr =mxsfb_get_fb_paddr (plane); + paddr =mxsfb_get_fb_paddr (mxsfb, plane);if (!paddr) {writel (0 , mxsfb->base +LCDC_AS_CTRL );return ;
drivers/gpu/drm/mxsfb/mxsfb_regs.h +1 -0
@@ -26,6 +26,7 @@#define LCDC_VDCTRL2 0x90#define LCDC_VDCTRL3 0xa0#define LCDC_VDCTRL4 0xb0 +#define LCDC_V4_CRC_STAT 0x1a0#define LCDC_V4_DEBUG0 0x1d0#define LCDC_V3_DEBUG0 0x1f0#define LCDC_AS_CTRL 0x210
Signature · 1 line
2.34.1
kernel test robot
build bot[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
Hi Marek,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc2 next-20220204] [cannot apply to airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808 base: git://anongit.freedesktop.org/drm/drm drm-next config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220207/202202070546.PJcFF726-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6daaf5a44925592c764c59219b0024ee06317028)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/75b77e11a90d2a041b405a10dce7e1be6aab61a0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808 git checkout 75b77e11a90d2a041b405a10dce7e1be6aab61a0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/mxsfb/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:33: error: too many arguments to function call, expected single argument 'addr', have 2 arguments
u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
~~~~~ ^~~~~~~~~~~~~~~~
drivers/gpu/drm/mxsfb/mxsfb_regs.h:29:27: note: expanded from macro 'LCDC_V4_CRC_STAT'
#define LCDC_V4_CRC_STAT 0x1a0
^~~~~
arch/x86/include/asm/io.h:60:17: note: 'readl' declared here
build_mmio_read(readl, "l", unsigned int, "=r", :"memory")
^1 error generated.
vim +/addr +324 drivers/gpu/drm/mxsfb/mxsfb_drv.c
317
318 static ssize_t mxsfb_frame_checksum_show(struct device *dev,
319 struct device_attribute *attr,
320 char *buf)
321 {
322 struct drm_device *drm = dev_get_drvdata(dev);
323 struct mxsfb_drm_private *mxsfb = drm->dev_private;
> 324 u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
325 u32 swcrc = 0xffffffff;
326 int i;
327
328 if (mxsfb->gem_vaddr) {
329 for (i = 0; i < mxsfb->gem_size / 4; i++) {
330 u32 data = bitrev32(((u32 *)mxsfb->gem_vaddr)[i]);
331 swcrc = crc32(swcrc, &data, 4);
332 }
333 swcrc = bitrev32(swcrc);
334 }
335
336 return sysfs_emit(buf, "HW:%08x,SW:%08x,OK:%d\n", hwcrc, swcrc, hwcrc == swcrc);
337 }
338 static DEVICE_ATTR(frame_checksum, 0444, mxsfb_frame_checksum_show, NULL);
339
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build bot[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
Hi Marek,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm/drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc2 next-20220204] [cannot apply to airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808 base: git://anongit.freedesktop.org/drm/drm drm-next config: riscv-randconfig-r031-20220207 (https://download.01.org/0day-ci/archive/20220207/202202070617.cZxa0dIi-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6daaf5a44925592c764c59219b0024ee06317028)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/75b77e11a90d2a041b405a10dce7e1be6aab61a0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220207-025808 git checkout 75b77e11a90d2a041b405a10dce7e1be6aab61a0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpu/drm/mxsfb/
If you fix the issue, kindly add following tag as appropriate
All error/warnings (new ones prefixed by >>):
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:33: error: too many arguments provided to function-like macro invocation
u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
^
arch/riscv/include/asm/mmio.h:140:9: note: macro 'readl' defined here
#define readl(c) ({ u32 __v; __io_br(); __v = readl_cpu(c); __io_ar(__v); __v; })
^
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:14: error: use of undeclared identifier 'readl'; did you mean 'vread'?
u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
^~~~~
vread
include/linux/vmalloc.h:251:13: note: 'vread' declared here
extern long vread(char *buf, char *addr, unsigned long count);
^
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c:324:6: warning: incompatible pointer to integer conversion initializing 'u32' (aka 'unsigned int') with an expression of type 'long (char *, char *, unsigned long)' [-Wint-conversion]
u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
^ ~~~~~1 warning and 2 errors generated.
vim +324 drivers/gpu/drm/mxsfb/mxsfb_drv.c
317
318 static ssize_t mxsfb_frame_checksum_show(struct device *dev,
319 struct device_attribute *attr,
320 char *buf)
321 {
322 struct drm_device *drm = dev_get_drvdata(dev);
323 struct mxsfb_drm_private *mxsfb = drm->dev_private;
> 324 u32 hwcrc = readl(mxsfb->base, LCDC_V4_CRC_STAT);
325 u32 swcrc = 0xffffffff;
326 int i;
327
328 if (mxsfb->gem_vaddr) {
329 for (i = 0; i < mxsfb->gem_size / 4; i++) {
330 u32 data = bitrev32(((u32 *)mxsfb->gem_vaddr)[i]);
331 swcrc = crc32(swcrc, &data, 4);
332 }
333 swcrc = bitrev32(swcrc);
334 }
335
336 return sysfs_emit(buf, "HW:%08x,SW:%08x,OK:%d\n", hwcrc, swcrc, hwcrc == swcrc);
337 }
338 static DEVICE_ATTR(frame_checksum, 0444, mxsfb_frame_checksum_show, NULL);
339
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Hi Marek,
Quoted 5 lines · Marek Vasut
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STATregister, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is likely meant as a functional safety register.
Quoted 8 lines
Unfortunatelly, there is zero documentation on how the CRC32 is calculated, there is no documentation of the polynomial, the init value, nor on which data is the checksum applied.
By applying brute-force on 8 pixel / 2 line frame, which is the minimum size LCDIF would work with, it turns out the polynomial is
CRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()of the entire frame and the resulting CRC has to be also bitrev32()ed.
No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.
Quoted 4 lines
Doing this calculation in software for each frame is unrealistic due to the CPU demand, implement at least a sysfs attribute which permits testing the current frame on demand.
Why not using the existing debugfs CRC support implemented in drivers/gpu/drm/drm_debugfs_crc.c?
Quoted 10 lines
Unfortunatelly, this functionality has another problem. On all of those SoCs, it is possible to overload interconnect e.g. by concurrent USB and uSDHC transfers, at which point the LCDIF LFIFO suffers an UNDERFLOW condition, which results in the image being shifted to the right by exactly LFIFO size pixels. On i.MX8M Mini, the LFIFO is 76x256 bits = 2432 Byte ~= 810 pixel at 24bpp. In this case, the LCDIF does not assert
UNDERFLOW_IRQbit, the frame CRC32 indicated inCRC_STATregister matches the CRC32 of the frame in DRAM, theRECOVER_ON_UNDERFLOWbit has no effect, so if this mode of failure occurs, the failure gets undetected and uncorrected.
Hmmm, interesting, no UNDERFLOW_IRQ bit asserted when LCDIF suffers an UNDERFLOW condition? Are you sure LCDIF really underflows? If the shifted image is seen on a MIPI DSI display, could that be a MIPI DSI or DPHY issue, like wrong horizontal parameter(s)?
Quoted 29 lines
Signed-off-by Marek Vasut <[email protected]>Cc Alexander Stein <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Lucas Stach <[email protected]>Cc Peng Fan <[email protected]>Cc Robby Cai <[email protected]>Cc Sam Ravnborg <[email protected]>Cc Stefan Agner <[email protected]>--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 38 ++++++++++++++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 3 +++ drivers/gpu/drm/mxsfb/mxsfb_kms.c | 11 +++++---- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 1 + 4 files changed, 49 insertions(+), 4 deletions(-)drivers/gpu/drm/mxsfb/mxsfb_drv.c +1
-0@@ -9,6 +9,7 @@*/ #include <linux/clk.h> +#include <linux/crc32.h> #include <linux/dma-mapping.h> #include <linux/io.h> #include <linux/module.h>
drivers/gpu/drm/mxsfb/mxsfb_drv.c static void mxsfb_unload(struct drm_device *drm) · line 302
Quoted 10 lines
drivers/gpu/drm/mxsfb/mxsfb_drv.c +7
-0@@ -292,6 +293,37 @@ static void mxsfb_unload(struct drm_device *drm)pm_runtime_disable (drm->dev); } +static ssize_t mxsfb_frame_checksum_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct drm_device *drm =dev_get_drvdata (dev); +struct mxsfb_drm_private *mxsfb = drm->dev_private; +u32 hwcrc =readl (mxsfb->base,LCDC_V4_CRC_STAT );
Access register without relevant clock(s) enabled?
LCDC_V4_CRC_STAT seems to hint that there should be some verion control logic for MXSFB_V3/4/6.
Regards,
Liu Ying
Quoted 120 lines
drivers/gpu/drm/mxsfb/mxsfb_drv.c +30
-0+u32 swcrc =0xffffffff ; +int i; + +if (mxsfb->gem_vaddr) { +for (i =0 ; i < mxsfb->gem_size /4 ; i++) { +u32 data =bitrev32 (((u32 *)mxsfb->gem_vaddr)[i]); + swcrc =crc32 (swcrc, &data,4 ); + } + swcrc =bitrev32 (swcrc); + } + +return sysfs_emit (buf,"HW:%08x,SW:%08x,OK:%d\n" , hwcrc, swcrc, hwcrc == swcrc); +} +static DEVICE_ATTR(frame_checksum, 0444, mxsfb_frame_checksum_show, NULL); + +static struct attribute *mxsfb_attributes[] = { + &dev_attr_frame_checksum.attr, +NULL , +}; + +static const struct attribute_group mxsfb_attr_group = { + .attrs = mxsfb_attributes, +}; +DEFINE_DRM_GEM_CMA_FOPS (fops);static const struct drm_driver mxsfb_driver = {@@ -335,10 +367,16 @@ static int mxsfb_probe(struct platform_device *pdev)if (ret) goto err_unload; + ret =devm_device_add_group (drm->dev, &mxsfb_attr_group); +if (ret) + goto err_attr; +drm_fbdev_generic_setup (drm,32 );return 0 ; +err_attr: +drm_dev_unregister (drm); err_unload:mxsfb_unload (drm); err_free:drivers/gpu/drm/mxsfb/mxsfb_drv.h +3
-0@@ -44,6 +44,9 @@ struct mxsfb_drm_private {struct drm_encoder encoder;struct drm_connector *connector;struct drm_bridge *bridge; + +void *gem_vaddr; +size_t gem_size; }; static inline struct mxsfb_drm_private *drivers/gpu/drm/mxsfb/mxsfb_kms.c +7
-4@@ -196,7 +196,7 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb)return clear_poll_bit (mxsfb->base +LCDC_CTRL ,CTRL_CLKGATE ); } -static dma_addr_t mxsfb_get_fb_paddr (struct drm_plane *plane) +static dma_addr_t mxsfb_get_fb_paddr (struct mxsfb_drm_private *mxsfb,struct drm_plane *plane) {struct drm_framebuffer *fb = plane->state->fb;struct drm_gem_cma_object *gem;@@ -208,6 +208,9 @@ static dma_addr_t mxsfb_get_fb_paddr(struct drm_plane *plane)if (!gem)return 0 ; + mxsfb->gem_vaddr = gem->vaddr; + mxsfb->gem_size = gem->base.size; +return gem->paddr; }@@ -370,7 +373,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,mxsfb_crtc_mode_set_nofb (mxsfb, bus_format);/* Write cur_buf as well to avoid an initial corrupt frame */ - paddr =mxsfb_get_fb_paddr (crtc->primary); + paddr =mxsfb_get_fb_paddr (mxsfb, crtc->primary);if (paddr) {writel (paddr, mxsfb->base + mxsfb->devdata->cur_buf);writel (paddr, mxsfb->base + mxsfb->devdata->next_buf);@@ -476,7 +479,7 @@ static void mxsfb_plane_primary_atomic_update(struct drm_plane *plane,struct mxsfb_drm_private *mxsfb =to_mxsfb_drm_private (plane->dev);dma_addr_t paddr; - paddr =mxsfb_get_fb_paddr (plane); + paddr =mxsfb_get_fb_paddr (mxsfb, plane);if (paddr)writel (paddr, mxsfb->base + mxsfb->devdata->next_buf); }@@ -492,7 +495,7 @@ static void mxsfb_plane_overlay_atomic_update(struct drm_plane *plane,dma_addr_t paddr;u32 ctrl; - paddr =mxsfb_get_fb_paddr (plane); + paddr =mxsfb_get_fb_paddr (mxsfb, plane);if (!paddr) {writel (0 , mxsfb->base +LCDC_AS_CTRL );return ;drivers/gpu/drm/mxsfb/mxsfb_regs.h +1
-0@@ -26,6 +26,7 @@#define LCDC_VDCTRL2 0x90#define LCDC_VDCTRL3 0xa0#define LCDC_VDCTRL4 0xb0 +#define LCDC_V4_CRC_STAT 0x1a0#define LCDC_V4_DEBUG0 0x1d0#define LCDC_V3_DEBUG0 0x1f0#define LCDC_AS_CTRL 0x210
Marek Vasut
maintainerQuoted 1 line · Liu Ying
Hi Marek,
Hi,
Quoted 10 lines · Marek Vasut
Quoted 9 lines
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STATregister, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is likely meant as a functional safety register.Unfortunatelly, there is zero documentation on how the CRC32 is calculated, there is no documentation of the polynomial, the init value, nor on which data is the checksum applied.
Quoted 7 lines
Quoted 4 lines
By applying brute-force on 8 pixel / 2 line frame, which is the minimum size LCDIF would work with, it turns out the polynomial is
CRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()of the entire frame and the resulting CRC has to be also bitrev32()ed.No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.
It would be nice if the datasheet could be improved.
There are many blank areas which are undocumented, this LCDIF CRC32 feature, i.MX8M Mini Arteris NOC at 0x32700000 , the ARM GPV NIC-301 at 0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping. The NOC and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring the NOC/NIC QoS would help mitigate this shift issue described below (*).
Do you know if there is some additional NOC/NIC documentation for i.MX8M Mini available ?
Quoted 6 lines
Quoted 3 lines
Doing this calculation in software for each frame is unrealistic due to the CPU demand, implement at least a sysfs attribute which permits testing the current frame on demand.
Why not using the existing debugfs CRC support implemented in
drivers/gpu/drm/drm_debugfs_crc.c?
I wasn't aware of that, thanks.
Quoted 10 lines
Quoted 9 lines
Unfortunatelly, this functionality has another problem. On all of those SoCs, it is possible to overload interconnect e.g. by concurrent USB and uSDHC transfers, at which point the LCDIF LFIFO suffers an UNDERFLOW condition, which results in the image being shifted to the right by exactly LFIFO size pixels. On i.MX8M Mini, the LFIFO is 76x256 bits = 2432 Byte ~= 810 pixel at 24bpp. In this case, the LCDIF does not assert
UNDERFLOW_IRQbit, the frame CRC32 indicated inCRC_STATregister matches the CRC32 of the frame in DRAM, theRECOVER_ON_UNDERFLOWbit has no effect, so if this mode of failure occurs, the failure gets undetected and uncorrected.
Quoted 2 lines
Hmmm, interesting, no
UNDERFLOW_IRQbit asserted when LCDIF suffers an UNDERFLOW condition?
Yes
Quoted 1 line
Are you sure LCDIF really underflows?
Mostly sure.
This problem occurs also on i.MX6SX which has no DSIM.
The failure is triggered by many short writes into DRAM to different addresses (I was successful at triggering it by using i.MX8M Mini with ASIX 88772 USB ethernet adapter, running iperf3 on the device, iperf3 -c ... -t 0 -R -P 16 on the PC). This effectively makes the CI HDRC behave as a DRAM thrashing AXI master, since it triggers a lot of short USB qTD READs from DRAM and a lot of short ethernet packet WRITEs to DRAM. And that either clogs the DRAM itself, or the NOC or DISPLAY/HSIO NIC-301, and prevents LCDIF from getting data long enough for this underflow condition to happen, LFIFO to underflow, and this shift to appear. And the shift does not disappear automatically itself, it just stays there until the LCDIF is reinitialized.
And it apparently also happens on iMXRT, where a suggestion was made to tweak the QoS settings of the interconnect (which cannot be tested on i.MX8M Mini, because neither of that documentation is available, see above (*)):
https://community.nxp.com/t5/i-MX-RT/iMXRT1052-LCD-Screen-shifted/td-p/1069978
Quoted 2 lines
If the shifted image is seen on a MIPI DSI display, could that be a MIPI DSI or DPHY issue, like wrong horizontal parameter(s)?
No, it happens also on i.MX6SX without DSIM, so this is LCDIF problem.
Quoted 29 lines · Marek Vasut
Quoted 1 line · Liu Ying
Hi Marek,
Hi,
Quoted 24 lines · Marek Vasut
Quoted 22 lines
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STAT
register, which contains CRC32 of the frame as it was clocked out of the
DPI interface of the LCDIF. This is likely meant as a functional safety
register.Unfortunatelly, there is zero documentation on how the CRC32 is calculated,
there is no documentation of the polynomial, the init value, nor on which
data is the checksum applied.By applying brute-force on 8 pixel / 2 line frame, which is the minimum
size LCDIF would work with, it turns out the polynomial isCRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()
of the entire frame and the resulting CRC has to be also bitrev32()ed.
Quoted 4 lines
Quoted 2 lines
No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.It would be nice if the datasheet could be improved.
Agreed.
Quoted 10 lines
There are many blank areas which are undocumented, this LCDIF CRC32 feature, i.MX8M Mini Arteris NOC at
0x32700000, the ARM GPV NIC-301 at
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping. The NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring the
NOC/NIC QoS would help mitigate this shift issue described below (*).
I also think the QoS would help if it is configureable.
Quoted 4 lines
Do you know if there is some additional NOC/NIC documentation for i.MX8M
Mini available ?
No.
Quoted 11 lines
Quoted 9 lines
Quoted 6 lines
Doing this calculation in software for each frame is unrealistic due to
the CPU demand, implement at least a sysfs attribute which permits testing
the current frame on demand.Why not using the existing debugfs CRC support implemented in
drivers/gpu/drm/drm_debugfs_crc.c?I wasn't aware of that, thanks.
No problem.
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Unfortunatelly, this functionality has another problem. On all of those SoCs,
it is possible to overload interconnect e.g. by concurrent USB and uSDHC
transfers, at which point the LCDIF LFIFO suffers an UNDERFLOW condition,
which results in the image being shifted to the right by exactly LFIFO size
pixels. On i.MX8M Mini, the LFIFO is 76x256 bits = 2432 Byte ~= 810 pixel
at 24bpp. In this case, the LCDIF does not assertUNDERFLOW_IRQbit, the
frame CRC32 indicated inCRC_STATregister matches the CRC32 of the frame
in DRAM, theRECOVER_ON_UNDERFLOWbit has no effect, so if this mode of
failure occurs, the failure gets undetected and uncorrected.
Quoted 5 lines
Quoted 3 lines
Hmmm, interesting, no
UNDERFLOW_IRQbit asserted when LCDIF suffers an
UNDERFLOW condition?Yes
Did you ever see UNDERFLOW_IRQ bit asserted in any case?
Liu Ying
Marek Vasut
maintainerOn 2/7/22 10:18, Liu Ying wrote:
Hi,
Quoted 42 lines
Quoted 24 lines
Quoted 24 lines · Marek Vasut
Quoted 22 lines
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STAT
register, which contains CRC32 of the frame as it was clocked out of the
DPI interface of the LCDIF. This is likely meant as a functional safety
register.Unfortunatelly, there is zero documentation on how the CRC32 is calculated,
there is no documentation of the polynomial, the init value, nor on which
data is the checksum applied.By applying brute-force on 8 pixel / 2 line frame, which is the minimum
size LCDIF would work with, it turns out the polynomial isCRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()
of the entire frame and the resulting CRC has to be also bitrev32()ed.Quoted 4 lines
Quoted 2 lines
No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.It would be nice if the datasheet could be improved.
Agreed.
Quoted 10 lines
There are many blank areas which are undocumented, this LCDIF CRC32 feature, i.MX8M Mini Arteris NOC at
0x32700000, the ARM GPV NIC-301 at
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping. The NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring the
NOC/NIC QoS would help mitigate this shift issue described below (*).
Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 5 lines
Quoted 3 lines
Do you know if there is some additional NOC/NIC documentation for i.MX8M
Mini available ?No.
Can you ask someone internally in NXP maybe ?
Quoted 32 lines
Quoted 10 lines
Quoted 8 lines
Quoted 5 lines
Doing this calculation in software for each frame is unrealistic due to
the CPU demand, implement at least a sysfs attribute which permits testing
the current frame on demand.Why not using the existing debugfs CRC support implemented in
drivers/gpu/drm/drm_debugfs_crc.c?I wasn't aware of that, thanks.
No problem.
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Unfortunatelly, this functionality has another problem. On all of those SoCs,
it is possible to overload interconnect e.g. by concurrent USB and uSDHC
transfers, at which point the LCDIF LFIFO suffers an UNDERFLOW condition,
which results in the image being shifted to the right by exactly LFIFO size
pixels. On i.MX8M Mini, the LFIFO is 76x256 bits = 2432 Byte ~= 810 pixel
at 24bpp. In this case, the LCDIF does not assertUNDERFLOW_IRQbit, the
frame CRC32 indicated inCRC_STATregister matches the CRC32 of the frame
in DRAM, theRECOVER_ON_UNDERFLOWbit has no effect, so if this mode of
failure occurs, the failure gets undetected and uncorrected.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Hmmm, interesting, no
UNDERFLOW_IRQbit asserted when LCDIF suffers an
UNDERFLOW condition?Yes
Did you ever see
UNDERFLOW_IRQbit asserted in any case?
I didn't see the UNDERFLOW_IRQ bit asserted during my tests, either with this IRQ enabled (UNDERFLOW_IRQ_EN=1) or with the IRQ disabled (UNDERFLOW_IRQ_EN=0) by reading the CTRL1 register in interrupt handler when CUR_FRAME_DONE_IRQ triggered the IRQ handler.
I did see a few auto-recoveries of the panel back into non-shifted image, that happened once in some 100-200 tests. Mostly the LCDIF does not recover automatically.
Quoted 61 lines · Marek Vasut
On 2/7/22 10:18, Liu Ying wrote:
Hi,
Quoted 53 lines
Quoted 30 lines
Quoted 30 lines · Marek Vasut
Quoted 28 lines
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STAT
register, which contains CRC32 of the frame as it was clocked out
of the
DPI interface of the LCDIF. This is likely meant as a functional
safety
register.Unfortunatelly, there is zero documentation on how the CRC32 is
calculated,
there is no documentation of the polynomial, the init value, nor
on which
data is the checksum applied.By applying brute-force on 8 pixel / 2 line frame, which is the
minimum
size LCDIF would work with, it turns out the polynomial isCRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()
of the entire frame and the resulting CRC has to be also bitrev32()ed.Quoted 4 lines
Quoted 2 lines
No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.It would be nice if the datasheet could be improved.
Agreed.
Quoted 15 lines
There are many blank areas which are undocumented, this LCDIF CRC32
feature, i.MX8M Mini Arteris NOC at0x32700000, the ARM GPV NIC- 301
at
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping. The
NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring
the
NOC/NIC QoS would help mitigate this shift issue described below (*).Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Do you know if there is some additional NOC/NIC documentation for i.MX8M
Mini available ?No.
Can you ask someone internally in NXP maybe ?
Maybe, you may try community.nxp.com, like the i.MXRT case.
Liu Ying
Hello Liu Ying,
Quoted 36 lines · Liu Ying
Quoted 35 lines · Marek Vasut
Quoted 30 lines · Liu Ying
Quoted 15 lines
Quoted 15 lines · Marek Vasut
Quoted 13 lines
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STATregister, which contains CRC32 of the frame as it was clocked out of the DPI interface of the LCDIF. This is likely meant as a functional safety register.Unfortunatelly, there is zero documentation on how the CRC32 is calculated, there is no documentation of the polynomial, the init value, nor on which data is the checksum applied.
By applying brute-force on 8 pixel / 2 line frame, which is the minimum size LCDIF would work with, it turns out the polynomial is
CRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()of the entire frame and the resulting CRC has to be also bitrev32()ed.Quoted 4 lines
Quoted 2 lines
No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.It would be nice if the datasheet could be improved.
Agreed.
Quoted 7 lines
There are many blank areas which are undocumented, this LCDIF CRC32 feature, i.MX8M Mini Arteris NOC at
0x32700000, the ARM GPV NIC-301 at 0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping. The NOC and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring the NOC/NIC QoS would help mitigate this shift issue described below (*).Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Do you know if there is some additional NOC/NIC documentation for i.MX8M Mini available ?
No.
Can you ask someone internally in NXP maybe ?
Maybe, you may try community.nxp.com, like the i.MXRT case.
Overall we seem to have had little luck with community.nxp.com. I wonder if it would be possible for key community members to get some more direct access to support when working on upstream drivers. I'm pretty sure nobody will try to abuse it :-)
Signature · 3 lines
Regards, Laurent Pinchart
Hello Laurent,
Quoted 62 lines · Laurent Pinchart
Hello Liu Ying,
Quoted 59 lines · Liu Ying
Quoted 57 lines · Marek Vasut
Quoted 44 lines · Liu Ying
Quoted 24 lines
Quoted 24 lines · Marek Vasut
Quoted 22 lines
The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano has a
CRC_STAT
register, which contains CRC32 of the frame as it was clocked out of the
DPI interface of the LCDIF. This is likely meant as a functional safety
register.Unfortunatelly, there is zero documentation on how the CRC32 is calculated,
there is no documentation of the polynomial, the init value, nor on which
data is the checksum applied.By applying brute-force on 8 pixel / 2 line frame, which is the minimum
size LCDIF would work with, it turns out the polynomial isCRC32_POLY_LE0xedb88320, init value is0xffffffff, the input data arebitrev32()
of the entire frame and the resulting CRC has to be also bitrev32()ed.Quoted 4 lines
Quoted 2 lines
No idea how the HW calculates the CRC value.
I didn't hear anyone internal tried this feature.It would be nice if the datasheet could be improved.
Agreed.
Quoted 4 lines
There are many blank areas which are undocumented, this LCDIF CRC32
feature, i.MX8M Mini Arteris NOC at0x32700000, the ARM GPV NIC-301 atQuoted 8 lines
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping. The NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring the
NOC/NIC QoS would help mitigate this shift issue described below
(*).Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 5 lines
Quoted 3 lines
Do you know if there is some additional NOC/NIC documentation for i.MX8M
Mini available ?No.
Can you ask someone internally in NXP maybe ?
Quoted 7 lines
Quoted 1 line
Maybe, you may try community.nxp.com, like the i.MXRT case.
Overall we seem to have had little luck with community.nxp.com. I wonder
if it would be possible for key community members to get some more direct access to support when working on upstream drivers. I'm pretty sure nobody will try to abuse it :-)
I'm not sure if it is possible. It's not a bad idea in my personal opinion.
Liu Ying
Marek Vasut
maintainerOn 2/8/22 03:41, Liu Ying wrote:
Hello everyone,
Quoted 23 lines
Quoted 23 lines
Quoted 15 lines
Quoted 6 lines
There are many blank areas which are undocumented, this LCDIF CRC32
feature, i.MX8M Mini Arteris NOC at0x32700000, the ARM GPV NIC- 301
at
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping.Quoted 8 lines
The
NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring
the
NOC/NIC QoS would help mitigate this shift issue described below (*).Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 4 lines
Quoted 3 lines
Do you know if there is some additional NOC/NIC documentation for i.MX8M
Mini available ?
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
No.
Can you ask someone internally in NXP maybe ?
Maybe, you may try community.nxp.com, like the i.MXRT case.
The community.nxp.com is unhelpful, the i.MXRT case it a good example -- the solution to the problem has been found by the person who asked the question on their own, and elsewhere too.
But note that the i.MXRT interconnect documentation is available in the i.MXRT datasheet, which made that possible in the first place. On i.MX, all that information has been removed from the datasheet in i.MX7 and i.MX8M, so I cannot even help myself, even if I wanted to. This is very bad.
Quoted 32 lines · Marek Vasut
On 2/8/22 03:41, Liu Ying wrote:
Hello everyone,
Quoted 28 lines
Quoted 28 lines
Quoted 18 lines
Quoted 9 lines
There are many blank areas which are undocumented, this LCDIF CRC32
feature, i.MX8M Mini Arteris NOC at0x32700000, the ARM GPV NIC-
301
at
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping.
TheQuoted 8 lines
NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring
the
NOC/NIC QoS would help mitigate this shift issue described below
(*).Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 5 lines
Quoted 4 lines
Do you know if there is some additional NOC/NIC documentation for
i.MX8M
Mini available ?
Quoted 11 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
No.
Can you ask someone internally in NXP maybe ?
Maybe, you may try community.nxp.com, like the i.MXRT case.
The community.nxp.com is unhelpful, the i.MXRT case it a good example
Signature · 3 lines
the solution to the problem has been found by the person who asked the question on their own, and elsewhere too.
AFAIK, there are questions answered by internal support team and RnD team at that community. I personally take it as a resource to use.
Quoted 9 lines
But note that the i.MXRT interconnect documentation is available in the
i.MXRT datasheet, which made that possible in the first place. On i.MX,
all that information has been removed from the datasheet in i.MX7 and
i.MX8M, so I cannot even help myself, even if I wanted to. This is very bad.
I'm not familiar with the documention in that area, so I personally will not be helpful at the documention topic. The main purpose I jumped in this thread is to review the patch and share the idea to use the existing drm debugfs crc support instead of creating a sysfs attribute.
Liu Ying
Marek Vasut
maintainerOn 2/10/22 06:22, Liu Ying wrote:
Hi,
[...]
Quoted 34 lines
Quoted 34 lines
Quoted 33 lines
Quoted 23 lines
Quoted 18 lines
Quoted 9 lines
There are many blank areas which are undocumented, this LCDIF CRC32
feature, i.MX8M Mini Arteris NOC at0x32700000, the ARM GPV NIC-
301
at
0x32{0,1,2,3,4,5,6,8}00000 and their master/slave port mapping.
TheQuoted 8 lines
NOC
and NICs were documented at least up to i.MX6QP and then that information disappeared from NXP datasheets. I think reconfiguring
the
NOC/NIC QoS would help mitigate this shift issue described below
(*).Quoted 1 line
I also think the QoS would help if it is configureable.
It is programmable, it's just the port mapping which is undocumented.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Do you know if there is some additional NOC/NIC documentation for
i.MX8M
Mini available ?No.
Can you ask someone internally in NXP maybe ?
Maybe, you may try community.nxp.com, like the i.MXRT case.
Quoted 8 lines
Quoted 5 lines
The community.nxp.com is unhelpful, the i.MXRT case it a good example
Signature · 3 lines
the solution to the problem has been found by the person who asked the question on their own, and elsewhere too.AFAIK, there are questions answered by internal support team and RnD team at that community. I personally take it as a resource to use.
Sure, here is a list of links to similar problem triggered by various people using the NXP BSP, neither of them in answered:
https://community.nxp.com/t5/i-MX-Processors/Image-shift-right-for-LVDS/td-p/969581
https://community.nxp.com/t5/i-MX-Processors/iMX8M-display-shifted-after-playing-decoded-video-with-gstreamer/td-p/928269
https://community.nxp.com/t5/i-MX-Processors/Display-Wrap-Around-Issue/td-p/1084052
https://community.nxp.com/t5/i-MX-Processors/Display-Vertically-shifted-IMX8mq-evk-board-in-dual-display-use/m-p/965726
https://community.nxp.com/t5/i-MX-RT/iMXRT1052-LCD-Screen-shifted/td-p/1069978
Quoted 9 lines
Quoted 8 lines
But note that the i.MXRT interconnect documentation is available in the
i.MXRT datasheet, which made that possible in the first place. On i.MX,
all that information has been removed from the datasheet in i.MX7 and
i.MX8M, so I cannot even help myself, even if I wanted to. This is very bad.
Quoted 5 lines
I'm not familiar with the documention in that area, so I personally will not be helpful at the documention topic. The main purpose I jumped in this thread is to review the patch and share the idea to use the existing drm debugfs crc support instead of creating a sysfs attribute.
Can you maybe ask someone inside NXP about this problem ?