Skip to contentSkip to conversation

pinctrl: aspeed: Improve debug output

bug report Dan Carpenter 1 participant 1 message Feb 7, 2022

lore
Share & tools
lore
#0 lore raw

Hello Andrew Jeffery,

This is a semi-automatic email about new static checker warnings.

The patch aa639e443704: "pinctrl: aspeed: Improve debug output" from Jul 1, 2020, leads to the following Smatch complaint:

./drivers/pinctrl/aspeed/pinctrl-aspeed.c:241 aspeed_pinmux_set_mux()
warn: variable dereferenced before check 'pdesc' (see line 239)

./drivers/pinctrl/aspeed/pinctrl-aspeed.c
238

   239			pr_debug("Muxing pin %s for %s\n", pdesc->name, pfunc->name);
                                                           ^^^^^^^^^^^

Dereference

240
241 if (!pdesc)

                             ^^^^^

Checked too late.

242 return -EINVAL;
243

regards,
dan carpenter