drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

PATCH In review Lyude Paul 4 participants 7 messages Feb 7, 2022 – Feb 8, 2022

Subsystems (4)

Stable branch DRM drivers Intel i915 Intel DRM display for xe and i915 drivers

lore

Share & tools

lore

Lyude Paul

author

2022-02-07 21:39 UTC #0 lore raw

PATCH 1/1 drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues is to just move the cursor around the left border of the screen (suspicious…).

So, fix people's displays again and turn PSR2 selective fetch off for all steppings of Tigerlake. This can be re-enabled again if someone from Intel finds the time to fix this functionality on OEM machines.

Signed-off-by Lyude Paul <[email protected]>

Fixes 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch by default")

Cc Gwan-gyeong Mun <[email protected]>

Cc Ville Syrjälä <[email protected]>

Cc José Roberto de Souza <[email protected]>

Cc Jani Nikula <[email protected]>

Cc Rodrigo Vivi <[email protected]>

Cc [email protected]

Cc <[email protected]> # v5.16+

---
 drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/gpu/drm/i915/display/intel_psr.c +7 -3

index a1a663f362e7..25c16abcd9cd 100644
@@ -737,10 +737,14 @@ static bool intel_psr2_sel_fetch_config_valid(struct intel_dp *intel_dp,
 		return false;
 	}
 
-	/* Wa_14010254185 Wa_14010103792 */
-	if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) {
+	/*
+	 * There's two things stopping this from being enabled on TGL:
+	 * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792 are missing
+	 * For all steps: PSR2 selective fetch causes screen flickering
+	 */
+	if (IS_TIGERLAKE(dev_priv)) {
 		drm_dbg_kms(&dev_priv->drm,
-			    "PSR2 sel fetch not enabled, missing the implementation of WAs\n");
+			    "PSR2 sel fetch not enabled, currently broken on TGL\n");
 		return false;
 	}

Signature · 1 line

2.34.1

Patchwork

2022-02-07 23:43 UTC #1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

== Series Details ==

Series: drm/i915/psr: Disable PSR2 selective fetch for all TGL steps
URL : https://patchwork.freedesktop.org/series/99796/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11198 -> Patchwork_22194
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/index.html

Participating hosts (48 -> 44)
------------------------------

Additional (1): fi-icl-u2
Missing (5): shard-tglu fi-bsw-cyan fi-pnv-d510 shard-dg1 bat-jsl-2

Known issues
------------

Here are the changes found in Patchwork_22194 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@amdgpu/[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([fdo#109278]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-connector-state:
- fi-cfl-8109u: [PASS][6] -> [DMESG-WARN][7] ([i915#165]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/fi-cfl-8109u/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-cfl-8109u/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([fdo#109285])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-cfl-8109u: [PASS][9] -> [DMESG-WARN][10] ([i915#165] / [i915#295]) +13 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/fi-cfl-8109u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-cfl-8109u/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][11] ([i915#3301])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-icl-u2/igt@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][12] ([i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-skl-6600u/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gem_contexts:
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#2867]) -> [PASS][14] +17 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/fi-tgl-dsi/igt@i915_selftest@live@gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-tgl-dsi/igt@i915_selftest@live@gem_contexts.html

* igt@i915_selftest@live@gt_pm:
- {fi-jsl-1}: [DMESG-FAIL][15] ([i915#1886]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/fi-jsl-1/igt@i915_selftest@live@gt_pm.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-jsl-1/igt@i915_selftest@live@gt_pm.html

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][17] ([i915#4269]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/fi-cml-u2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/fi-cml-u2/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][19] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][20] ([i915#4957])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/bat-dg1-6/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/bat-dg1-6/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes
-------------

* Linux: CI_DRM_11198 -> Patchwork_22194

CI-20190529: 20190529
CI_DRM_11198: 125ad93ed42690fefbc273e4195f8d705d29c8c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6340: 2401624349fecc8213d7d394a84ad91cf04241f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22194: f6d38c61577b0f6754bbd4c89eae86b9b70b607d @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

f6d38c61577b drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/index.html

Patchwork

2022-02-08 02:29 UTC #2 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

In reply to Lyude Paul

== Series Details ==

Series: drm/i915/psr: Disable PSR2 selective fetch for all TGL steps
URL : https://patchwork.freedesktop.org/series/99796/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11198_full -> Patchwork_22194_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (13 -> 12)
------------------------------

Missing (1): shard-rkl

Known issues
------------

Here are the changes found in Patchwork_22194_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@chamelium:
- shard-iclb: NOTRUN -> [SKIP][1] ([fdo#111827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][2] -> [FAIL][3] ([i915#232])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-tglb6/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb5/igt@[email protected]

* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: NOTRUN -> [SKIP][4] ([i915#4525])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-glk8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-glk2/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][7] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl4/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-tglb1/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-tglb: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#2842]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-kbl6/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-glk1/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-kbl6/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random:
- shard-kbl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@[email protected]

* igt@gem_lmem_swapping@parallel-multi:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@[email protected]

* igt@gem_pxp@create-valid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#4270])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#4270])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#3297])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#180]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-apl6/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl8/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][26] -> [DMESG-WARN][27] ([i915#1436] / [i915#716])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl10/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl4/igt@[email protected]

* igt@gen9_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2856])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@gen9_exec_parse@bb-start-param:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#2527] / [i915#2856]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#1904])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#4387])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][32] -> [FAIL][33] ([i915#2521])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl7/igt@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271]) +91 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3777]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3777])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111615])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3886]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-bad-pixel-format-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111615] / [i915#3689])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@kms_ccs@pipe-a-bad-pixel-format-yf_tiled_ccs.html

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#3689]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#3886]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689] / [i915#3886]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb2/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271]) +49 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271]) +94 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl4/igt@[email protected]

* igt@kms_color@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [i915#1149])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +9 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827]) +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3116] / [i915#3299])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109300] / [fdo#111066])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@kms_content_protection@mei_interface.html

* igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109278] / [fdo#109279])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#3319])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3359]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109279] / [i915#3359])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#109278])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#533]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@[email protected]

* igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109274] / [fdo#111825]) +7 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109274])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#2122])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-glk1/igt@kms_flip@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: NOTRUN -> [FAIL][66] ([i915#2122]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [PASS][67] -> [SKIP][68] ([i915#3701])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109280] / [fdo#111825]) +11 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109280]) +5 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-render.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][71] -> [DMESG-WARN][72] ([i915#180]) +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-kbl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl7/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][74] ([i915#265])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][75] ([fdo#108145] / [i915#265])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][76] ([fdo#108145] / [i915#265])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][77] -> [FAIL][78] ([fdo#108145] / [i915#265]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl10/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl4/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3536]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_plane_lowres@pipe-d-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278]) +9 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#2920])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl8/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@kms_psr2_su@page_flip-nv12.html
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][85] -> [SKIP][86] ([fdo#109441]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_primary_blt:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109441])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb5/igt@kms_psr@psr2_primary_blt.html

* igt@kms_vrr@flip-dpms:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#109502])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@kms_writeback@writeback-pixel-formats:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2437])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl1/igt@[email protected]

* igt@prime_nv_api@i915_self_import_to_different_fd:
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109291]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb2/igt@prime_nv_api@i915_self_import_to_different_fd.html

* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@[email protected]

* igt@sysfs_clients@split-50:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#2994])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb1/igt@[email protected]

* igt@sysfs_preempt_timeout@timeout@rcs0:
- shard-skl: [PASS][94] -> [FAIL][95] ([i915#3259])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl9/igt@sysfs_preempt_timeout@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl4/igt@sysfs_preempt_timeout@[email protected]

#### Possible fixes ####

* igt@gem_eio@kms:
- shard-tglb: [FAIL][96] ([i915#232]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-tglb2/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][98] ([i915#4525]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb7/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb4/igt@[email protected]

* igt@gem_exec_endless@dispatch@rcs0:
- shard-skl: [INCOMPLETE][100] ([i915#3778]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl10/igt@gem_exec_endless@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl9/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][102] ([i915#2842]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb5/igt@gem_exec_fair@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][104] ([i915#2842]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-kbl6/igt@gem_exec_fair@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl7/igt@gem_exec_fair@[email protected]
- shard-apl: [FAIL][106] ([i915#2842]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-apl1/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][108] ([i915#2849]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb8/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][110] ([i915#118]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-glk3/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-glk1/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- {shard-dg1}: [SKIP][112] ([i915#1397]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-dg1-15/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-dg1-18/igt@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-180:
- {shard-tglu}: [DMESG-WARN][114] ([i915#402]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-tglu-3/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-tglu-8/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [FAIL][116] ([i915#2346]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-skl: [FAIL][118] ([i915#2346] / [i915#533]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][120] ([i915#180]) -> [PASS][121] +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-kbl6/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl3/igt@[email protected]
- shard-apl: [DMESG-WARN][122] ([i915#180]) -> [PASS][123] +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-apl6/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- {shard-dg1}: [DMESG-WARN][124] -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-dg1-15/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-dg1-16/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][126] ([fdo#108145] / [i915#265]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-skl8/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-skl10/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][128] ([fdo#109441]) -> [PASS][129] +2 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-glk: [FAIL][130] ([i915#31]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-glk9/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-glk5/igt@[email protected]

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [INCOMPLETE][132] ([i915#2828]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-kbl4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-kbl1/igt@[email protected]

* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: [FAIL][134] ([i915#43]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-glk9/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-glk5/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][136] ([i915#2684]) -> [FAIL][137] ([i915#2680])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11198/shard-iclb8/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/shard-iclb6/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling:
- shard-skl: [SKIP][138] ([fdo#109271] / [i915#1888]) -> [SKIP][139] ([fdo#109271])
[138]:

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22194/index.html

Hogander, Jouni

2022-02-08 11:08 UTC #3 lore raw

In reply to Lyude Paul

Hello Paul,

Quoted 8 lines · Lyude Paul

As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this
ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues is to just move the cursor around the left border
of the screen (suspicious…).

Sorry to hear you have this bad experience with i915 PSR2 selective fetch support. There is already some discussion about these problems and possible root causes here:

https://gitlab.freedesktop.org/drm/intel/-/issues/4951

I have Dell XPS 13 7390 which has panel supporting PSR2. Luckily I'm not facing these problems with it.

Quoted 46 lines

So, fix people's displays again and turn PSR2 selective fetch off for all
steppings of Tigerlake. This can be re-enabled again if someone from Intel
finds the time to fix this functionality on OEM machines.
Signed-off-by Lyude Paul <[email protected]>
Fixes 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch
by default")
Cc: Gwan-gyeong Mun <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Cc: José Roberto de Souza <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Cc: [email protected]
Cc: <[email protected]> # v5.16+
---
 drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +3 -2
index a1a663f362e7..25c16abcd9cd 100644
@@ -737,10 +737,14 @@ static bool
 intel_psr2_sel_fetch_config_valid(struct intel_dp *intel_dp,
 		return false;
 	}
 
-	/* Wa_14010254185 Wa_14010103792 */
-	if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) {
+	/*
+	 * There's two things stopping this from being enabled on TGL:
+	 * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792
are missing
drivers/gpu/drm/i915/display/intel_psr.c +3 -1
+	 * For all steps: PSR2 selective fetch causes screen flickering
+	 */
+	if (IS_TIGERLAKE(dev_priv)) {
 		drm_dbg_kms(&dev_priv->drm,
-			    "PSR2 sel fetch not enabled, missing the
implementation of WAs\n");
drivers/gpu/drm/i915/display/intel_psr.c +1 -0
+			    "PSR2 sel fetch not enabled, currently
broken on TGL\n");

drivers/gpu/drm/i915/display/intel_psr.c

Quoted 2 lines

drivers/gpu/drm/i915/display/intel_psr.c +0 -0
 		return false;
 	}

BR,

Jouni Högander

Souza, Jose

2022-02-08 13:06 UTC #4 lore raw

In reply to Lyude Paul

Quoted 6 lines · Lyude Paul

As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues is to just move the cursor around the left border of the screen (suspicious…).

Where is the bug for that? Where is the logs?
We can't go from enabled to disabled without any debug and because of a single device. In the mean time you have the option to set the i915 parameter to disable it.

Quoted 40 lines

So, fix people's displays again and turn PSR2 selective fetch off for all steppings of Tigerlake. This can be re-enabled again if someone from Intel finds the time to fix this functionality on OEM machines.
Signed-off-by Lyude Paul <[email protected]>
Fixes 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch by default")
Cc Gwan-gyeong Mun <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc José Roberto de Souza <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc [email protected]
Cc <[email protected]> # v5.16+
---
 drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +7 -3
index a1a663f362e7..25c16abcd9cd 100644
@@ -737,10 +737,14 @@ static bool intel_psr2_sel_fetch_config_valid(struct intel_dp *intel_dp,
 		return false;
 	}
 
-	/* Wa_14010254185 Wa_14010103792 */
-	if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) {
+	/*
+	 * There's two things stopping this from being enabled on TGL:
+	 * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792 are missing
+	 * For all steps: PSR2 selective fetch causes screen flickering
+	 */
+	if (IS_TIGERLAKE(dev_priv)) {
 		drm_dbg_kms(&dev_priv->drm,
-			    "PSR2 sel fetch not enabled, missing the implementation of WAs\n");
+			    "PSR2 sel fetch not enabled, currently broken on TGL\n");
 		return false;
 	}
 

Lyude Paul

author

2022-02-08 18:09 UTC #5 lore raw

Quoted 9 lines · Jose

Quoted 6 lines · Lyude Paul
As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues is to just move the cursor around the left border of the screen (suspicious…).
Where is the bug for that? Where is the logs?

I'm happy to open up a bug and include some logs, will do it in just a moment

Quoted 4 lines

We can't go from enabled to disabled without any debug and because of a single device.
In the mean time you have the option to set the i915 parameter to disable it.

I mean - I totally understand the hesistance with the lack of debug info, I'll go open up an issue with said info in a bit. FWIW is a machine currently being sold with Linux pre-installs which is expected to work out of the box, so it's not exactly an uncommon laptop to be running Linux. Also I don't have any problem with us trying to fix the issue before flat out disabling things - I sent the revert hoping that would happen, and also because I needed to write the revert anyway since I had to disable this in Fedora's kernel.

Quoted 48 lines

Quoted 47 lines
So, fix people's displays again and turn PSR2 selective fetch off for all steppings of Tigerlake. This can be re-enabled again if someone from Intel finds the time to fix this functionality on OEM machines.
Signed-off-by Lyude Paul <[email protected]>
Fixes 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch by
default")
Cc: Gwan-gyeong Mun <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Cc: José Roberto de Souza <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Cc: [email protected]
Cc: <[email protected]> # v5.16+
---
drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +0 -0
index a1a663f362e7..25c16abcd9cd 100644
@@ -737,10 +737,14 @@ static bool intel_psr2_sel_fetch_config_valid(struct
 intel_dp *intel_dp,
                 return false;
         }
-       /* Wa_14010254185 Wa_14010103792 */
-       if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) { +       /*
+        * There's two things stopping this from being enabled on TGL:
+        * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792 are missing
+        * For all steps: PSR2 selective fetch causes screen flickering +        */
+       if (IS_TIGERLAKE(dev_priv)) { drm_dbg_kms(&dev_priv->drm,
-                           "PSR2 sel fetch not enabled, missing the implementation of WAs\n");
+                           "PSR2 sel fetch not enabled, currently broken on TGL\n");
                return false;
        }

Signature · 3 lines

Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat

Lyude Paul

author

2022-02-08 22:02 UTC #6 lore raw

In reply to Souza, Jose

Opened the issue at https://gitlab.freedesktop.org/drm/intel/-/issues/5077 , included dmesg + video. Feel free to let me know if you need any more info, or need me to try any patches

Quoted 61 lines · Jose

Quoted 6 lines · Lyude Paul
As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues is to just move the cursor around the left border of the screen (suspicious…).
Where is the bug for that? Where is the logs?
We can't go from enabled to disabled without any debug and because of a single device.
In the mean time you have the option to set the i915 parameter to disable it.
Quoted 46 lines
So, fix people's displays again and turn PSR2 selective fetch off for all steppings of Tigerlake. This can be re-enabled again if someone from Intel finds the time to fix this functionality on OEM machines.
Signed-off-by Lyude Paul <[email protected]>
Fixes 7f6002e58025 ("drm/i915/display: Enable PSR2 selective fetch by
default")
Cc: Gwan-gyeong Mun <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Cc: José Roberto de Souza <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Cc: [email protected]
Cc: <[email protected]> # v5.16+
---
drivers/gpu/drm/i915/display/intel_psr.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +0 -0
index a1a663f362e7..25c16abcd9cd 100644
@@ -737,10 +737,14 @@ static bool intel_psr2_sel_fetch_config_valid(struct
 intel_dp *intel_dp,
                 return false;
         }
-       /* Wa_14010254185 Wa_14010103792 */
-       if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_C0)) { +       /*
+        * There's two things stopping this from being enabled on TGL:
+        * For steps A0-C0: workarounds Wa_14010254185 Wa_14010103792 are missing
+        * For all steps: PSR2 selective fetch causes screen flickering +        */
+       if (IS_TIGERLAKE(dev_priv)) { drm_dbg_kms(&dev_priv->drm,
-                           "PSR2 sel fetch not enabled, missing the implementation of WAs\n");
+                           "PSR2 sel fetch not enabled, currently broken on TGL\n");
                return false;
        }

Signature · 3 lines

Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat