Skip to contentSkip to conversation

ARM: dts: imx6dl: Add a label to cpu1 node

PATCH RESEND In review Yunus Bas 2 participants 3 messages Feb 9, 2022 – Feb 13, 2022

Subsystems (2)
lore
Share & tools
lore

Yunus Bas

author
#0 lore raw

PATCH RESEND 1/2 ARM: dts: imx6dl: Add a label to cpu1 node

The cpu1 is missing a label for further reference. Since cpu0 has already a label, add also one for cpu1 node, so it can be referenced to add or modify cpu specific properties the same way as cpu0.

---
 arch/arm/boot/dts/imx6dl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6dl.dtsi +1 -1
index fdd81fdc3f35..d49a9b99f33f 100644
@@ -48,7 +48,7 @@ cpu0: cpu@0 {
 			nvmem-cell-names = "speed_grade";
 		};
 
-		cpu@1 {
+		cpu1: cpu@1 {
 			compatible = "arm,cortex-a9";
 			device_type = "cpu";
 			reg = <1>;
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH RESEND 2/2 ARM: dts: imx6qdl: phycore-som: Add custom volt/freq table

The PHYTEC phyCORE-i.MX6QDL SOM-modules are operating with a slightly different voltage and frequency values in contrast to the generic i.MX6Q/DL tables. The values have been adjusted to achieve the most stable condition for the PHYTEC-modules. Introduce imx6q- and imx6dl-phycore dtsi files with the modified power tables.

---
 .../boot/dts/imx6dl-phytec-mira-rdk-nand.dts  |  2 +-
 .../boot/dts/imx6dl-phytec-phycore-som.dtsi   | 25 ++++++
 .../boot/dts/imx6q-phytec-mira-rdk-emmc.dts   |  2 +-
 .../boot/dts/imx6q-phytec-mira-rdk-nand.dts   |  2 +-
 .../boot/dts/imx6q-phytec-phycore-som.dtsi    | 83 +++++++++++++++++++
 5 files changed, 111 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi
 create mode 100644 arch/arm/boot/dts/imx6q-phytec-phycore-som.dtsi
arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts +1 -1
index d906a7f05aaa..8ec27080ca1e 100644
@@ -6,7 +6,7 @@
 
 /dts-v1/;
 #include "imx6dl.dtsi"
-#include "imx6qdl-phytec-phycore-som.dtsi"
+#include "imx6dl-phytec-phycore-som.dtsi"
 #include "imx6qdl-phytec-mira.dtsi"
 #include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
 #include "imx6qdl-phytec-mira-peb-av-02.dtsi"
arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi new file +25 -0
new file mode 100644
index 000000000000..0985453b5ad6
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2021 PHYTEC Messtechnik GmbH
+ * Author: Yunus Bas <[email protected]>
+ */
+
+#include "imx6qdl-phytec-phycore-som.dtsi"
+
+&cpu0 {
+	operating-points = <
+		/* kHz    uV */
+		996000  1275000
+		792000  1175000
+		396000  1150000
+	>;
+};
+
+&cpu1 {
+	operating-points = <
+		/* kHz    uV */
+		996000  1275000
+		792000  1175000
+		396000  1150000
+	>;
+};
arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts +1 -1
index 322f071d972f..7d947762f3b9 100644
@@ -6,7 +6,7 @@
 
 /dts-v1/;
 #include "imx6q.dtsi"
-#include "imx6qdl-phytec-phycore-som.dtsi"
+#include "imx6q-phytec-phycore-som.dtsi"
 #include "imx6qdl-phytec-mira.dtsi"
 #include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
 #include "imx6qdl-phytec-mira-peb-av-02.dtsi"
arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts +1 -1
index 3f13726c8058..afbb6681a6b5 100644
@@ -6,7 +6,7 @@
 
 /dts-v1/;
 #include "imx6q.dtsi"
-#include "imx6qdl-phytec-phycore-som.dtsi"
+#include "imx6q-phytec-phycore-som.dtsi"
 #include "imx6qdl-phytec-mira.dtsi"
 #include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
 #include "imx6qdl-phytec-mira-peb-av-02.dtsi"
arch/arm/boot/dts/imx6q-phytec-phycore-som.dtsi new file +83 -0

83 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: phycore-som: Add custom volt/freq table

Quoted 41 lines · Yunus Bas

The PHYTEC phyCORE-i.MX6QDL SOM-modules are operating with a slightly different voltage and frequency values in contrast to the generic i.MX6Q/DL tables. The values have been adjusted to achieve the most stable condition for the PHYTEC-modules. Introduce imx6q- and imx6dl-phycore dtsi files with the modified power tables.

---
 .../boot/dts/imx6dl-phytec-mira-rdk-nand.dts  |  2 +-
 .../boot/dts/imx6dl-phytec-phycore-som.dtsi   | 25 ++++++
 .../boot/dts/imx6q-phytec-mira-rdk-emmc.dts   |  2 +-
 .../boot/dts/imx6q-phytec-mira-rdk-nand.dts   |  2 +-
 .../boot/dts/imx6q-phytec-phycore-som.dtsi    | 83 +++++++++++++++++++
 5 files changed, 111 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi
 create mode 100644 arch/arm/boot/dts/imx6q-phytec-phycore-som.dtsi
arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts +1 -1
index d906a7f05aaa..8ec27080ca1e 100644
@@ -6,7 +6,7 @@
 
 /dts-v1/;
 #include "imx6dl.dtsi"
-#include "imx6qdl-phytec-phycore-som.dtsi"
+#include "imx6dl-phytec-phycore-som.dtsi"
 #include "imx6qdl-phytec-mira.dtsi"
 #include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
 #include "imx6qdl-phytec-mira-peb-av-02.dtsi"
arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi new file +5 -0
new file mode 100644
index 000000000000..0985453b5ad6
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2021 PHYTEC Messtechnik GmbH
+ * Author: Yunus Bas <[email protected]>
+ */

arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi line 15

Quoted 10 lines
arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi new file +10 -0
+
+#include "imx6qdl-phytec-phycore-som.dtsi"
+
+&cpu0 {
+	operating-points = <
+		/* kHz    uV */
+		996000  1275000
+		792000  1175000
+		396000  1150000
+	>;

Check Documentation/devicetree/bindings/opp/opp-v1.yaml to see how this property should be coded properly.

Shawn

Quoted 128 lines
arch/arm/boot/dts/imx6dl-phytec-phycore-som.dtsi new file +10 -0
+};
+
+&cpu1 {
+	operating-points = <
+		/* kHz    uV */
+		996000  1275000
+		792000  1175000
+		396000  1150000
+	>;
+};
arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts +1 -1
index 322f071d972f..7d947762f3b9 100644
@@ -6,7 +6,7 @@
 
 /dts-v1/;
 #include "imx6q.dtsi"
-#include "imx6qdl-phytec-phycore-som.dtsi"
+#include "imx6q-phytec-phycore-som.dtsi"
 #include "imx6qdl-phytec-mira.dtsi"
 #include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
 #include "imx6qdl-phytec-mira-peb-av-02.dtsi"
arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts +1 -1
index 3f13726c8058..afbb6681a6b5 100644
@@ -6,7 +6,7 @@
 
 /dts-v1/;
 #include "imx6q.dtsi"
-#include "imx6qdl-phytec-phycore-som.dtsi"
+#include "imx6q-phytec-phycore-som.dtsi"
 #include "imx6qdl-phytec-mira.dtsi"
 #include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
 #include "imx6qdl-phytec-mira-peb-av-02.dtsi"
arch/arm/boot/dts/imx6q-phytec-phycore-som.dtsi new file +83 -0
new file mode 100644
index 000000000000..3ecb94379c8b
@@ -0,0 +1,83 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2021 PHYTEC Messtechnik GmbH
+ * Author: Yunus Bas <[email protected]>
+ */
+
+#include "imx6qdl-phytec-phycore-som.dtsi"
+
+&cpu0 {
+	operating-points = <
+		/* KHz  uV */
+		1200000 1300000
+		996000  1250000
+		852000  1250000
+		792000  1175000
+		396000  1075000
+	>;
+	fsl,soc-operating-points = <
+		/* ARM kHz  SOC-PU uV */
+		1200000 1275000
+		996000	1250000
+		852000	1250000
+		792000	1250000
+		396000	1250000
+	>;
+};
+
+&cpu1 {
+	operating-points = <
+		/* KHz  uV */
+		1200000 1300000
+		996000  1250000
+		852000  1250000
+		792000  1175000
+		396000  1075000
+	>;
+	fsl,soc-operating-points = <
+		/* ARM kHz  SOC-PU uV */
+		1200000 1275000
+		996000	1250000
+		852000	1250000
+		792000	1250000
+		396000	1250000
+	>;
+};
+
+&cpu2 {
+	operating-points = <
+		/* KHz  uV */
+		1200000 1300000
+		996000  1250000
+		852000  1250000
+		792000  1175000
+		396000  1075000
+	>;
+	fsl,soc-operating-points = <
+		/* ARM kHz  SOC-PU uV */
+		1200000 1275000
+		996000	1250000
+		852000	1250000
+		792000	1250000
+		396000	1250000
+	>;
+};
+
+&cpu3 {
+	operating-points = <
+		/* KHz  uV */
+		1200000 1300000
+		996000  1250000
+		852000  1250000
+		792000  1175000
+		396000  1075000
+	>;
+	fsl,soc-operating-points = <
+		/* ARM kHz  SOC-PU uV */
+		1200000 1275000
+		996000	1250000
+		852000	1250000
+		792000	1250000
+		396000	1250000
+	>;
+};
Signature · 1 line
2.25.1