fstat_02: Increase test coverage by creating hard link to file and validate using fstat
PATCH v3 1/1 fstat_02: Increase test coverage by creating hard link to file and validate using fstat
Please ignore patch v2, I think that is wrong.
Fix format specfiers and cast to correct type when printing.
Implements: #517
--- testcases/kernel/syscalls/fstat/fstat02.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
testcases/kernel/syscalls/fstat/fstat02.c +10 -0
@@ -17,8 +17,10 @@#include "tst_safe_macros.h" #define TESTFILE "test_file" +#define LINK_TESTFILE "link_test_file"#define FILE_SIZE 1024#define FILE_MODE 0644 +#define NLINK 2static struct stat stat_buf;static uid_t user_id;
@@ -61,6 +63,12 @@ static void run(void) fail++; } +if (stat_buf.st_nlink !=NLINK ) { +tst_res (TFAIL ,"stat_buf.st_nlink = %i expected %i" , + (int )stat_buf.st_nlink,NLINK ); + fail++; + } +if (fail)return ;
@@ -78,6 +86,8 @@ static void setup(void)if (tst_fill_file (TESTFILE ,'a' ,FILE_SIZE ,1 ))tst_brk (TBROK ,"Could not fill Testfile!" ); + +SAFE_LINK (TESTFILE ,LINK_TESTFILE ); }static void cleanup (void )
Signature · 5 lines
2.25.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 3 lines
Please ignore patch v2, I think that is wrong.
Fix format specfiers and cast to correct type when printing.
Well either it's %li and cast to (long) or %i and cast to (int) both will work fine in this case.
However the points stated in v2 still apply to this patch as well.
Quoted 48 lines
Implements: #517
--- testcases/kernel/syscalls/fstat/fstat02.c | 10 ++++++++++ 1 file changed, 10 insertions(+)testcases/kernel/syscalls/fstat/fstat02.c +10
-0@@ -17,8 +17,10 @@#include "tst_safe_macros.h" #define TESTFILE "test_file" +#define LINK_TESTFILE "link_test_file"#define FILE_SIZE 1024#define FILE_MODE 0644 +#define NLINK 2static struct stat stat_buf;static uid_t user_id;@@ -61,6 +63,12 @@ static void run(void) fail++; } +if (stat_buf.st_nlink !=NLINK ) { +tst_res (TFAIL ,"stat_buf.st_nlink = %i expected %i" , + (int )stat_buf.st_nlink,NLINK ); + fail++; + } +if (fail)return ;@@ -78,6 +86,8 @@ static void setup(void)if (tst_fill_file (TESTFILE ,'a' ,FILE_SIZE ,1 ))tst_brk (TBROK ,"Could not fill Testfile!" ); + +SAFE_LINK (TESTFILE ,LINK_TESTFILE ); }static void cleanup (void )Signature · 5 lines
2.25.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp